From 16f8eb52891cd868ca97ecb2f96182fa376afbdf Mon Sep 17 00:00:00 2001 From: Vansh Negi Date: Sun, 1 Mar 2026 07:06:48 +0000 Subject: [PATCH 1/2] comment: show name field in floating toolbar --- TeXmacs/plugins/comment/progs/various/comment-menu.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/TeXmacs/plugins/comment/progs/various/comment-menu.scm b/TeXmacs/plugins/comment/progs/various/comment-menu.scm index 3352c8f00e..926622f748 100644 --- a/TeXmacs/plugins/comment/progs/various/comment-menu.scm +++ b/TeXmacs/plugins/comment/progs/various/comment-menu.scm @@ -68,7 +68,8 @@ (dynamic (comment-color-menu type by val))))) (tm-menu (focus-hidden-icons t) - (:require (any-comment-context? t))) + (:require (any-comment-context? t)) + (dynamic (string-input-icon t 3))) (tm-menu (focus-extra-icons t) (:require (any-comment-context? t)) From bacdd476e67c1b060c996c74b9dd25c86687fecd Mon Sep 17 00:00:00 2001 From: Vansh Negi Date: Sun, 1 Mar 2026 07:40:54 +0000 Subject: [PATCH 2/2] devel: add changelog for 202_109 --- devel/202_109.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 devel/202_109.md diff --git a/devel/202_109.md b/devel/202_109.md new file mode 100644 index 0000000000..4bb19ba762 --- /dev/null +++ b/devel/202_109.md @@ -0,0 +1,35 @@ +# 202_109 Show name field in Comment plugin floating toolbar + +### What +The `focus-hidden-icons` override for the Comment plugin had an empty body, which +suppressed all hidden child input widgets from the focus toolbar. Added +`(dynamic (string-input-icon t 3))` to show the author name (by) field at child +index 3, allowing users to modify the comment author name directly from the +floating toolbar. + +### Why +The name (by field) of a comment could not be modified from the floating toolbar, +requiring users to use workarounds to change the comment author. + +### How +In `TeXmacs/plugins/comment/progs/various/comment-menu.scm` (line 70-72), the +`focus-hidden-icons` menu for comments had an empty body that suppressed all +hidden child inputs from the toolbar. Added `(dynamic (string-input-icon t 3))` +to render the author name input widget: + +```diff + (tm-menu (focus-hidden-icons t) +- (:require (any-comment-context? t))) ++ (:require (any-comment-context? t)) ++ (dynamic (string-input-icon t 3))) +``` + +Child index 3 corresponds to the `by` (author name) field in the comment tag +structure: `(unique-id mirror-id type by time src body)`. + +## How to test +1. Open Mogan and ensure the `comment` style package is loaded +2. Insert an unfolded comment via `Insert -> Note -> Unfolded comment` +3. Click on the comment so the focus toolbar appears at the top +4. Verify that a "By:" input field is now visible in the floating toolbar +5. Change the name in the input field and confirm the change is applied to the comment \ No newline at end of file