From b996775e8248c041970da2e99cfd8a37ed1380f5 Mon Sep 17 00:00:00 2001 From: Andrew Dodson Date: Tue, 14 Jun 2022 13:23:34 +0100 Subject: [PATCH] perf: filter by empty array should not run a query, [skip ci] --- test/integration/get.spec.js | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/test/integration/get.spec.js b/test/integration/get.spec.js index dfbc58fc..b3e574b2 100644 --- a/test/integration/get.spec.js +++ b/test/integration/get.spec.js @@ -1,5 +1,6 @@ import Dare from '../../src/index.js'; -// DEBUG import mysql from 'mysql2/promise'; +// Import mysql from 'mysql2/promise'; + const {db} = global; const models = { @@ -41,7 +42,7 @@ const schema = { // eslint-disable-next-line arrow-body-style dare.execute = query => { - // DEBUG console.log(mysql.format(query.sql, query.values)); + // Console.log(mysql.format(query.sql, query.values)); return db.query(query); @@ -183,6 +184,25 @@ const schema = { }); + it('Can ignore empty set of values', async () => { + + // Create user + await dare.post('users', [{username: 'user123'}]); + + // Same Structure + const resp = await dare.get({ + table: 'users', + fields: ['username'], + filter: { + 'username': [] + }, + limit: 1 + }); + + expect(resp).to.deep.equal([]); + + }); + }); });