ESMX Build Fails with ESMF v8.9.0 (fix included)

[danrosen25]

I ran fire_behavior tests within the ESMF v8.9.0 container and the ESMX test failed.
https://hub.docker.com/r/esmf/esmf-build-release/tags

The release of v8.9.0 modified the library linking system for components within an ESMX build and this caused a build failure because the linker did not link firelib. The quick solution is to explicitly add the firelib to the library dependencies to the esmfBuild file (see the following diff).

Note that this could be a change to the CMake version and not the ESMF version. I have not tested that. UPDATE: I have tested CMake v3.31.8 and ESMF v8.8.0 and this passed. Then I updated ESMF v8.9.0 and it failed.

diff --git a/nuopc/esmxBuild.yaml b/nuopc/esmxBuild.yaml
index b14fd7c..3fa22cc 100644
--- a/nuopc/esmxBuild.yaml
+++ b/nuopc/esmxBuild.yaml
@@ -4,10 +4,10 @@ application:
 components:
   fire_behavior:
     build_type: none
-    libraries: fire_behavior_nuopc
+    libraries: fire_behavior_nuopc firelib
     fort_module: fire_behavior_nuopc.mod
 
   wrfdata:
     build_type:  none
-    libraries: fire_behavior_wrfnuopc
+    libraries: fire_behavior_wrfnuopc firelib
     fort_module: wrf_nuopc.mod