From 75b67868f23b6bc9d5c1da1d5d485d78176a092d Mon Sep 17 00:00:00 2001 From: mgmobrien Date: Sun, 1 Feb 2026 19:16:02 -0700 Subject: [PATCH 1/2] Add data-page attribute for E2E test selectors Adds a data-page attribute to the settings container that exposes which view is currently active. This gives E2E tests a stable way to detect the current page without fingerprint-matching on content. Values: relay-home, relay-detail, folder-detail, shared-folder-orphan No user-visible changes - just a data attribute for test automation. --- src/components/PluginSettings.svelte | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/PluginSettings.svelte b/src/components/PluginSettings.svelte index ed00149..d9e8ac5 100644 --- a/src/components/PluginSettings.svelte +++ b/src/components/PluginSettings.svelte @@ -273,7 +273,8 @@ {:else if !Platform.isMobile} {/if} -
+ +
{#if remoteFolder} Date: Sun, 1 Feb 2026 20:23:17 -0700 Subject: [PATCH 2/2] Refactor: move data-view attributes to individual view components Per review feedback, each view component now owns its own data-view attribute rather than having the parent calculate it. This is cleaner because: - Each component owns its identity - No central routing logic needed for test selectors - Adding new views doesn't require touching PluginSettings Attributes: - Relays.svelte: data-view="relays" - ManageRelay.svelte: data-view="manage-relay" - ManageSharedFolder.svelte: data-view="manage-shared-folder" - ManageRemoteFolder.svelte: data-view="manage-remote-folder" Co-Authored-By: Claude Opus 4.5 --- src/components/ManageRelay.svelte | 3 +++ src/components/ManageRemoteFolder.svelte | 3 +++ src/components/ManageSharedFolder.svelte | 3 +++ src/components/PluginSettings.svelte | 3 +-- src/components/Relays.svelte | 4 ++++ 5 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/components/ManageRelay.svelte b/src/components/ManageRelay.svelte index 77eea89..1fa5267 100644 --- a/src/components/ManageRelay.svelte +++ b/src/components/ManageRelay.svelte @@ -519,6 +519,8 @@ }); + +
+