Caching access token

[stevemit]

This is a great little piece of code, but it connects to AWS twice for each Maven request, including metadata requests. Have you considered caching the access token and an expiration timestamp, say in a system property (one access per 'mvn' process)?

[OneGeek]

I did try to use the "singleton" lifecycle for the wagon to at least reuse the client instance, but ran into issues. A cache is doable, but I think I would need to a cache that maps the repo "url" to the token for it.

[stevemit]

Maybe cache the token and its timestamp in system properties named "aws-code-wgn-XXXXXX-token" and "aws-code-wgn-XXXXXX-timestamp" where XXXXXX is the repo id or a hash of the URL. Consider using the actual http URL configured in settings.xml -- it needn't be dynamic.

[OneGeek]

What do you mean the actual http URL configured in settings.xml? The http url is determined dynamically using the AWS SDK.

[stevemit]

The URL is available from the AWS SDK and the web console, but it is static and follows a fixed pattern -- something like
https://domain-account.d.codeartifact.region.amazonaws.com/maven/repository/