Skip to content

Diversion Records - need to handle approved status #48

@smalers

Description

@smalers

Some automated tests are failing, when comparing HydroBase database with web services. Doug Stenzel said the following:

  • For your Diversion Record comparisons, I think the differences are caused by the fact that in the snapshot we do not include any provisionally published data; however, in the web services we do. You would want to only use REST data with an approval_status of 'Approved' in your checks.

I'm a bit confused by this because some of the differences appear to be in older data. Isn't provisional data status only for recent data and then it gets changed to approved when reviewed?

TSTool time series identifier commands don't have a way to specify command parameters so this could cause problems for testing if the default is to include provisional data. I can update the ReadColoradoHydroBaseRest command to default to only approved and allow requesting provisional data. This would allow TSID command defaults from HydroBase database and web services to be compared in tests.

What does the State think about the default command parameter for the status?

Metadata

Metadata

Assignees

Labels

SSize: day or lessenhancementNew feature or requesthighPriority: next release if possible

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions