From a3c83e2d5228d96228058b81f61e5a01ac8368d4 Mon Sep 17 00:00:00 2001 From: Tajudeen Date: Sat, 3 Jan 2026 11:20:27 +0000 Subject: [PATCH] fix: add missing X11 dependencies for Linux CI and build dependencies step for macOS CI - Add libx11-dev and libx11-xcb-dev to Linux test workflow to fix native-keymap build failure - Add missing 'Install build dependencies' step to macOS test workflow to ensure build/ folder dependencies are installed before main dependencies --- .github/workflows/pr-darwin-test.yml | 17 +++++++++++++++++ .github/workflows/pr-linux-test.yml | 2 ++ 2 files changed, 19 insertions(+) diff --git a/.github/workflows/pr-darwin-test.yml b/.github/workflows/pr-darwin-test.yml index e48140b9569..6fce35247a6 100644 --- a/.github/workflows/pr-darwin-test.yml +++ b/.github/workflows/pr-darwin-test.yml @@ -45,6 +45,23 @@ jobs: if: steps.cache-node-modules.outputs.cache-hit == 'true' run: tar -xzf .build/node_modules_cache/cache.tgz + - name: Install build dependencies + if: steps.cache-node-modules.outputs.cache-hit != 'true' + working-directory: build + run: | + set -e + + for i in {1..5}; do # try 5 times + npm ci && break + if [ $i -eq 5 ]; then + echo "Npm install failed too many times" >&2 + exit 1 + fi + echo "Npm install failed $i, trying again..." + done + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' run: | diff --git a/.github/workflows/pr-linux-test.yml b/.github/workflows/pr-linux-test.yml index 1861abf3792..521a038d6d5 100644 --- a/.github/workflows/pr-linux-test.yml +++ b/.github/workflows/pr-linux-test.yml @@ -39,6 +39,8 @@ jobs: ./build/azure-pipelines/linux/apt-retry.sh sudo apt-get install -y pkg-config \ xvfb \ libgtk-3-0 \ + libx11-dev \ + libx11-xcb-dev \ libxkbfile-dev \ libkrb5-dev \ libgbm1 \