From a50dbafc5ce62e4d4e3b048c1ef6a9359e3a3773 Mon Sep 17 00:00:00 2001 From: Najuna Date: Wed, 25 Feb 2026 13:41:58 +0300 Subject: [PATCH] fix: close zip file handle before saving bundle.zip --- synkronus/pkg/appbundle/versioning.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/synkronus/pkg/appbundle/versioning.go b/synkronus/pkg/appbundle/versioning.go index 48279b4f7..d2399ea7b 100644 --- a/synkronus/pkg/appbundle/versioning.go +++ b/synkronus/pkg/appbundle/versioning.go @@ -39,7 +39,7 @@ func (s *Service) PushBundle(ctx context.Context, zipReader io.Reader) (*Manifes if err != nil { return nil, fmt.Errorf("failed to open zip file: %w", err) } - defer zipFile.Close() + // Note: We'll close zipFile explicitly before copying tempZipFile to bundle.zip // Validate the bundle structure if err := s.validateBundleStructure(&zipFile.Reader); err != nil { @@ -123,6 +123,9 @@ func (s *Service) PushBundle(ctx context.Context, zipReader io.Reader) (*Manifes dstFile.Close() } + // Close the zip reader before copying the temp file + zipFile.Close() + // Save the original zip to the version directory for direct download if _, err := tempZipFile.Seek(0, 0); err != nil { return nil, fmt.Errorf("failed to rewind zip for saving: %w", err)