diff --git a/resources/regexes.ts b/resources/regexes.ts index 711f05a31c8..588c8c3264a 100644 --- a/resources/regexes.ts +++ b/resources/regexes.ts @@ -321,6 +321,9 @@ const parseHelper = ( defaultFieldValue, ); } else { + // FIXME: handle lint error here + // ref: https://github.com/OverlayPlugin/cactbot/pull/274#discussion_r1692439720 + // eslint-disable-next-line @typescript-eslint/restrict-plus-operands str += fieldValue; } } diff --git a/ui/config/config.ts b/ui/config/config.ts index ea3b898adab..d25f10317a3 100644 --- a/ui/config/config.ts +++ b/ui/config/config.ts @@ -433,6 +433,8 @@ export class CactbotConfigurator { const args = Array.isArray(path) ? path : [path]; const info = JSON.stringify([group, ...args].join(', ')); console.error( + // FIXME: + // eslint-disable-next-line @typescript-eslint/no-base-to-string `Unexpected type: ${info}, ${objOrValue.toString()}, ${typeof objOrValue}, ${typeof defaultValue}`, ); return defaultValue; diff --git a/ui/pullcounter/pullcounter.ts b/ui/pullcounter/pullcounter.ts index 67c6d33f471..6121a95cccc 100644 --- a/ui/pullcounter/pullcounter.ts +++ b/ui/pullcounter/pullcounter.ts @@ -402,6 +402,8 @@ class PullCounter { try { if (typeof e.data !== 'string') + // FIXME: + // eslint-disable-next-line @typescript-eslint/no-base-to-string throw new Error(e.data.toString()); const parsed: unknown = JSON.parse(e.data); diff --git a/ui/raidboss/popup-text.ts b/ui/raidboss/popup-text.ts index faa8dec698b..6a40ffe0497 100644 --- a/ui/raidboss/popup-text.ts +++ b/ui/raidboss/popup-text.ts @@ -1482,6 +1482,8 @@ export class PopupText { if (result !== undefined) { // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions if (result) + // FIXME: + // eslint-disable-next-line @typescript-eslint/no-base-to-string triggerHelper.ttsText = result?.toString(); } else { triggerHelper.ttsText = triggerHelper.defaultTTSText; diff --git a/ui/raidboss/raidboss_config.ts b/ui/raidboss/raidboss_config.ts index 63df805b7f4..a3d69988b39 100644 --- a/ui/raidboss/raidboss_config.ts +++ b/ui/raidboss/raidboss_config.ts @@ -527,6 +527,9 @@ const setOptionsFromOutputValue = ( options.SoundAlertsEnabled = false; options.SpokenAlertsEnabled = false; } else { + // FIXME: handle lint error here + // ref: https://github.com/OverlayPlugin/cactbot/pull/274#discussion_r1692375852 + // eslint-ignore-next-line @typescript-eslint/no-base-to-string console.error(`unknown output type: ${value.toString()}`); } }; @@ -762,6 +765,7 @@ class RaidbossConfigurator { detailText = this.base.translate(kMiscTranslations.valueIsFunction); detailCls.push('function-text'); } else { + // eslint-disable-next-line @typescript-eslint/no-base-to-string detailText = trigFunc.toString(); } @@ -1345,7 +1349,8 @@ class RaidbossConfigurator { if (result === null || result === undefined) return false; - // Super hack: + // FIXME: Super hack: + // eslint-disable-next-line @typescript-eslint/no-base-to-string const resultStr = result.toString(); if (resultStr.includes('undefined') || resultStr.includes('NaN')) return false; diff --git a/util/logtools/generate_triggers.ts b/util/logtools/generate_triggers.ts index e18f3bef146..0ab9f534406 100644 --- a/util/logtools/generate_triggers.ts +++ b/util/logtools/generate_triggers.ts @@ -109,6 +109,11 @@ type XIVAPINpcYellResponse = { type XIVAPIBattleTalk2Response = XIVAPINpcYellResponse; type TriggerSuggestTypes = typeof triggerSuggestOptions[number]; +type TriggerSuggestTypesFull = + | TriggerSuggestTypes + | `AoE (circle, range = ${number})` + | `Rectangle AoE, CastType = ${number}` + | 'Plus AoE'; type GenerateTriggersArgs = { 'files': string[] | null; @@ -1249,7 +1254,7 @@ const generateTriggersTextFromTriggerInfo = async ( // TODO: More default suggestions. Figure out how things work for square (CastType=12) // vs left/right/etc positioning const castTypeSuggestions = new Set(); - const castTypeFullSuggestions = new Set(); + const castTypeFullSuggestions = new Set(); if (xivapiAbilityInfo !== undefined) { const xivApiAbilities = mapInfo.fights .flatMap((fight) => fight.instances.filter((instance) => instance.groups?.type === '20'))