From f29a0f903cf7e6d2a6a928d9cc69eca29ff0260f Mon Sep 17 00:00:00 2001 From: Alex Cicovic <23142906+acicovic@users.noreply.github.com> Date: Tue, 22 Apr 2025 12:24:44 +0300 Subject: [PATCH] Remove outdated GitHub release issue template --- .../ISSUE_TEMPLATE/release-template-new.md | 68 ------------------- .github/ISSUE_TEMPLATE/release-template.md | 17 +++-- 2 files changed, 8 insertions(+), 77 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/release-template-new.md diff --git a/.github/ISSUE_TEMPLATE/release-template-new.md b/.github/ISSUE_TEMPLATE/release-template-new.md deleted file mode 100644 index 6b01e2418e..0000000000 --- a/.github/ISSUE_TEMPLATE/release-template-new.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -name: Release template [NEW] -about: Internally used for new releases -title: Release wp-parsely x.y.z -labels: "wp-parsely, Maintenance" ---- - -This is an issue for tracking the next `wp-parsely` release. This ticket is to be opened the week before the actual release, so we have enough time to complete all the related tasks. - -The actual release of the plugin should be done on Mondays so we can catch the Tuesday WordPress VIP release window. - -## Before releasing - -**1. Merge all outstanding work** -- [ ] Merge any outstanding PRs due for this release to the target branch (usually `develop`). -- [ ] Verify that all important PRs have an appropriate `Changelog` tag. PRs without a `Changelog` tag won't be added to the changelog. - -**2. Conduct additional testing** -We've got automated testing in place and also test under our local development environment during development. For impactful releases we should also: -- [ ] Conduct an additional [smoke test](https://github.com/Parsely/wp-parsely/blob/develop/docs/TESTING.md#manual-smoke-test) under our local development environment. -- [ ] Test under a regular non-local WordPress installation. -- [ ] Test under a real WordPress VIP environment. - -**3. Communicate** -- [ ] Inform Parse.ly support of the upcoming release. - -The following additional tasks might be needed depending on the release and its impact: -- [ ] Write any needed internal documentation. -- [ ] Write an internal P2 post about the release (to be posted immediately so folks are aware of the release ahead of time). -- [ ] Write a WordPress VIP Lobby post about the release (to be posted immediately to preannounce next week's VIP release - don't forget to get someone to proofread!). -- [ ] Prepare any public documentation (to be posted after the WordPress.org release). - -## Release process - -**1. Update version numbers and changelog** -- [ ] [Run the Bump wp-parsely version](https://github.com/Parsely/wp-parsely/actions/workflows/bump-version.yml) GitHub Action to update the version numbers in the plugin files. Use the branch you want to release from (usually `develop`). -- [ ] Verify that the generated PR looks correct. You can amend it with new commits if needed. -- [ ] Merge the PR into the target branch (usually `develop`). - -**2. Merge develop into trunk** -- [ ] [Create a PR](https://github.com/Parsely/wp-parsely/compare/trunk...develop?quick_pull=1&title=Release+wp-parsely+x.y.z&body=This+PR+merges+the+`develop`+branch+into+the+`trunk`+branch+in+order+to+release+wp-parsely+x.y.z.) that merges the target branch (usually `develop`) into `trunk`, named _Release wp-parsely x.y.z_. -- [ ] Merge the PR into `trunk`. - -**3. Create Release and Deploy to WordPress.org** -- [ ] Check if the `develop` and `trunk` branches built successfully. You can check it in the [GitHub Actions](https://github.com/Parsely/wp-parsely/actions/workflows/build-plugin.yml) tab. -- [ ] [Run the Release wp-parsely](https://github.com/Parsely/wp-parsely/actions/workflows/release-plugin.yml) GitHub Action, on the `trunk-built` branch, inputting the new version number, and without selecting Dry run. -- [ ] Check the action logs for any errors. If there are any, fix them and rerun the action. -- [ ] Check the new release on the [GitHub releases page](https://github.com/Parsely/wp-parsely/releases) and verify that it is correct. -- [ ] Verify that the release was successful by checking the [WordPress.org plugin page](https://wordpress.org/plugins/wp-parsely/). - -## After releasing - -**1. Communicate** -- [ ] If needed, update the public documentation. -- [ ] Inform the concerned Slack channels about the new release, also preannouncing the WordPress VIP release. - -**2. Merge trunk back into develop** -- [ ] [Create a PR](https://github.com/Parsely/wp-parsely/compare/develop...trunk?quick_pull=1&title=Merge+trunk+into+develop+after+the+wp-parsely+x.y.z+release&body=This+PR+merges+the+`trunk`+branch+into+the+`develop`+branch+after+the+release+of+wp-parsely+x.y.z.) that merges `trunk` into `develop`, named _Merge trunk into develop after the wp-parsely x.y.z release_. -- [ ] Merge the PR into `develop`. - -**3. Manage milestones** -- [ ] Close the current milestone. -- [ ] If needed, open a new milestone for the next release. - -**4. Release to other platforms** -- [ ] Update the `vip-go-mu-plugins` submodule to the latest version. -- [ ] Release the plugin for WordPress VIP. -- [ ] Release the plugin for WordPress.com. diff --git a/.github/ISSUE_TEMPLATE/release-template.md b/.github/ISSUE_TEMPLATE/release-template.md index aebccb3cde..b300f7dc1b 100644 --- a/.github/ISSUE_TEMPLATE/release-template.md +++ b/.github/ISSUE_TEMPLATE/release-template.md @@ -33,21 +33,20 @@ The following additional tasks might be needed depending on the release and its ## Release process **1. Update version numbers and changelog** -- [ ] Run `php bin/release.php $OLD_VERSION $NEW_VERSION` to update version numbers, the changelog, and to push the PR to GitHub. Copy the changelog's new release text for later use. -- [ ] Verify that the PR code looks correct. You can amend it with new commits if needed. +- [ ] [Run the "Bump wp-parsely version"](https://github.com/Parsely/wp-parsely/actions/workflows/bump-version.yml) GitHub Action to update the version numbers in the plugin files. Use the branch you want to release from (usually `develop`). +- [ ] Verify that the generated PR looks correct. You can amend it with new commits if needed. - [ ] Merge the PR into the target branch (usually `develop`). **2. Merge develop into trunk** - [ ] [Create a PR](https://github.com/Parsely/wp-parsely/compare/trunk...develop?quick_pull=1&title=Release+wp-parsely+x.y.z&body=This+PR+merges+the+`develop`+branch+into+the+`trunk`+branch+in+order+to+release+wp-parsely+x.y.z.) that merges the target branch (usually `develop`) into `trunk`, named _Release wp-parsely x.y.z_. - [ ] Merge the PR into `trunk`. -**3. Create the GitHub release** -- [ ] [Create a GitHub release](https://github.com/Parsely/wp-parsely/releases/new?target=trunk) that targets `trunk`. -- [ ] For the release's text, use the changelog text that was posted by the `bin/release.php` script into the PR in step 1. -- [ ] Verify that you're using the appropriate name and tag (should be the version that is being released, without a leading 'v' character), and publish the release. - -**4. Deploy the release to wordpress.org** -- [ ] Run the [Deploy to WordPress.org](https://github.com/Parsely/wp-parsely/actions/workflows/deploy.yml) GitHub workflow, selecting the new version tag. +**3. Create release and deploy to WordPress.org** +- [ ] Check if the `develop` and `trunk` branches built successfully. You can check it in the [GitHub Actions](https://github.com/Parsely/wp-parsely/actions/workflows/build-plugin.yml) tab. +- [ ] [Run the "Release wp-parsely"](https://github.com/Parsely/wp-parsely/actions/workflows/release-plugin.yml) GitHub Action, on the `trunk-built` branch, inputting the new version number, and without selecting Dry run. +- [ ] Check the action logs for any errors. If there are any, fix them and rerun the action. +- [ ] Check the new release on the [GitHub releases page](https://github.com/Parsely/wp-parsely/releases) and verify that it is correct. +- [ ] Verify that the release was successful by checking the [WordPress.org plugin page](https://wordpress.org/plugins/wp-parsely/). ## After releasing