-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Description
Description
The cd command implementation for absolute paths needs improved error handling and has a typo that should be addressed.
Issues to Address
- Missing error message: When a path doesn't exist or isn't a directory, no error message is printed to the user
- Typo: There's a "or or" typo that should be corrected to "or"
- Misleading error message: When
set_current_dirfails after confirming the path exists and is a directory, the error message may be misleading (likely a permissions issue rather than path not found)
Context
This issue was identified during code review of PR #11 which implements cd navigation for absolute paths.
Backlinks:
- PR: feat(cd): implement cd navigation for absolute paths #11
- Review comment: feat(cd): implement cd navigation for absolute paths #11 (comment)
- Requested by: @Pawank06
Affected File
src/main.rs - the cd command handling branch for absolute paths
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels