Code Optimisation

[ElGrenier]

Simple subject, big impact:
I'v found an code optimisation for datapacks that lint things that can be optimized, so my question is simple : would you mind if i do a big patch of simple (that alone don't change anything, but on the scale of the map optimise a lot) optimisation of the datapacks ? (If there is room for optimisation obviously)

[ElGrenier]

One of the major issue is: if we want to optimise to the max, ALL fakeplayer used will need to be renamed, i know its like.. A lot, but if its done the map will be much more optimized (precisely: the game checks for an # to be optimized)

[ElGrenier]

Precisely look at this code (from Minecraft source) : https://mcsrc.dev/#1/26.1-snapshot-2/net/minecraft/commands/arguments/ScoreHolderArgument

[ElGrenier]

To further explain how the code can be optimized, see this image, it show everything that can be done to make the code the most efficient possible:
https://cdn.discordapp.com/attachments/157097006500806656/1455833327788363859/codes.png?ex=696401b1&is=6962b031&hm=bea4612fb8d2d61c9243c78606cbd53e6cf6cf0a31d2c7b0c2c17a12947edc66&

[ATT2CNTranslationTeam]

Of course, but some scoreboard entries are used to match the UUIDs of pre-placed entities, such as an armor stand placed in an unloaded area. Using scoreboard commands to assign its UUID allows direct modification of scores, so some commands cannot be virtualized with #. This is something to keep in mind.

Just like this.

scoreboard players set 000aa559-000c-f189-0000-1e5f000030fa ElytraRacing 539
scoreboard players set 000aa559-000c-f189-0000-1e5f000030fb ElytraRacing 540
scoreboard players set 000aa559-000c-f189-0000-1e5f000030fc ElytraRacing 541
scoreboard players set 000aa559-000c-f189-0000-1e5f000030fd ElytraRacing 542
scoreboard players set 000aa559-000c-f189-0000-1e5f000030fe ElytraRacing 543
scoreboard players set 000aa559-000c-f189-0000-1e5f000030ff ElytraRacing 544
scoreboard players set 000aa559-000c-f189-0000-1e5f00003100 ElytraRacing 545

[Piccomaster]

From what I see, most optimization examples have already been done, but there's certainly still room for further optimization. However, we're not even in the testing phase yet to see if everything that's been coded works together on the map.
Afterwards, it could indeed be done... But to avoid breaking any functionality, we need to be certain of what the person is modifying, because we don't want everything to have to be tested again after optimizing the entire codebase.

Or we need to work something out. If you're willing to start now, tell us what you want to optimize and which specific parts, so we don't overlap on features that are still under development.

[ATT2CNTranslationTeam]

In terms of testing, based on this version under development, I used a new save file to conduct some tests. Currently, the main storyline progress has reached Billgart, and most of the other content has been experienced. There are almost no issues (if there were any, they should have been fixed in earlier updates).