Skip to content

Firmware, Remove Code Dependent on LIMIT_POWER_DRAW, GPAD_API, Rev 46, #332

@ForrestErickson

Description

@ForrestErickson

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

GPAD_API version 0.46, There is code dependent on a #define LIMIT_POWER_DRAW
Here is an email describing why it was created (and why it is not for final product deployment).

Subject: Development, Firmware, LIMIT_POWER_DRAW make false
Date 20260119
Juhandre,

Following up on our discussion at the end of today's Discord.
There is a #define, LIMIT_POWER_DRAW  in the code. See below.

It was created because of a single Rev1 Krake assembly (Perhaps US0005) which at Roberts residence was experience a run time software reset error which started when on a single unit the LCD back light was turned on. 

Robert modified the code to change during setup() the order of some of the LCD initialization and  perhaps some of the functionality. I forget the details. It was back last June or July. This allowed that unit to work but degrades the user experience I and Nagham are having.

The code should be changed so that LIMIT_POWER_DRAW is false.
Please change this in your next version released.

And assuming all of the Rev 2 assemblies operate with out the software reset the code dependent on LIMIT_POWER_DRAW should be removed at a versioned release.

I will make a Krake issue for removing the stale code when appropriate.

Lee

Image

Describe the solution you'd like
A clear and concise description of what you want to happen.

The code dependent on LIMIT_POWER_DRAW should be removed at a versioned release.

CC: @nk25719

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions