From de46c31ae9f7a9e7d21dc416a90b3adbf39cd349 Mon Sep 17 00:00:00 2001 From: mikelau13 Date: Tue, 29 May 2018 10:30:27 -0400 Subject: [PATCH 1/3] Fixed issues: missing
and ; when target directory does not already exist, create it first. --- PxtlCa.XmlCommentMarkDownGenerator/Program.cs | 5 +++++ PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/PxtlCa.XmlCommentMarkDownGenerator/Program.cs b/PxtlCa.XmlCommentMarkDownGenerator/Program.cs index 9a03bf9..fca24a9 100644 --- a/PxtlCa.XmlCommentMarkDownGenerator/Program.cs +++ b/PxtlCa.XmlCommentMarkDownGenerator/Program.cs @@ -18,6 +18,11 @@ static void Main(string[] args) Console.WriteLine(options.GetUsage()); return; } + // for in case the target directory does not already exist, create it now + if (!System.IO.Directory.Exists(Path.GetDirectoryName(options.OutputFile))) + { + System.IO.Directory.CreateDirectory(Path.GetDirectoryName(options.OutputFile)); + } // consume Options instance properties var inReader = options.ConsoleIn ? Console.In diff --git a/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs b/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs index 79014c9..25a2184 100644 --- a/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs +++ b/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs @@ -29,6 +29,14 @@ public Func< x.Element("members").Elements("member").ToMarkDown(context.MutateAssemblyName(x.Element("assembly").Element("name").Value)) } ), + ["br"] = new TagRenderer( + "\n", + (x, context) => new string[0] + ), + ["seealso"] = new TagRenderer( + "## \n\n", + (x, context) => new[] { x.Nodes().ToMarkDown(context) } + ), ["type"] = new TagRenderer( "## {0}\n\n{1}\n\n---\n", (x, context) => XmlToMarkdown.ExtractNameAndBodyFromMember(x, context) From 827083ed46c8536987933ab97fa6fae862ff2d2e Mon Sep 17 00:00:00 2001 From: mikelau13 Date: Tue, 29 May 2018 11:06:00 -0400 Subject: [PATCH 2/3] removed codes to makedir --- PxtlCa.XmlCommentMarkDownGenerator/Program.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/PxtlCa.XmlCommentMarkDownGenerator/Program.cs b/PxtlCa.XmlCommentMarkDownGenerator/Program.cs index fca24a9..9a03bf9 100644 --- a/PxtlCa.XmlCommentMarkDownGenerator/Program.cs +++ b/PxtlCa.XmlCommentMarkDownGenerator/Program.cs @@ -18,11 +18,6 @@ static void Main(string[] args) Console.WriteLine(options.GetUsage()); return; } - // for in case the target directory does not already exist, create it now - if (!System.IO.Directory.Exists(Path.GetDirectoryName(options.OutputFile))) - { - System.IO.Directory.CreateDirectory(Path.GetDirectoryName(options.OutputFile)); - } // consume Options instance properties var inReader = options.ConsoleIn ? Console.In From 9e1ada712eb3239a1bca512e95351fc12d6e4dc3 Mon Sep 17 00:00:00 2001 From: mikelau13 Date: Tue, 29 May 2018 15:12:06 -0400 Subject: [PATCH 3/3] Fixed "seealso" --- PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs b/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs index 25a2184..08199f3 100644 --- a/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs +++ b/PxtlCa.XmlCommentMarkDownGenerator/TagRenderers.cs @@ -34,8 +34,8 @@ public Func< (x, context) => new string[0] ), ["seealso"] = new TagRenderer( - "## \n\n", - (x, context) => new[] { x.Nodes().ToMarkDown(context) } + "##### See also: {0}\n", + (x, context) => XmlToMarkdown.ExtractNameAndBody("cref", x, context) ), ["type"] = new TagRenderer( "## {0}\n\n{1}\n\n---\n",