build issue -

[LRA-QC]

Hi, I cloned the repo following the instructions but when I launch 'make' it cannot compile the 'box.c' source. Thanks to anyone for the help.

❯ make --version
GNU Make 4.4

❯ gcc --version
gcc (GCC) 12.2.1 20230201

OS: Arch Linux x86_64 
Kernel: 6.1.11-arch1-1 
CPU: AMD Ryzen 9 5950X (32) @ 3.400GHz 
GPU: AMD ATI Radeon RX 6800 XT
Memory: 128GiB 

qbRayTrace/qbPrimatives/box.cpp: In member function ‘virtual bool qbRT::Box::TestIntersection(const qbRT::Ray&, qbRT::DATA::hitData&)’:
qbRayTrace/qbPrimatives/box.cpp:65:31: error: aggregate ‘std::array<double, 6> t’ has incomplete type and cannot be defined
   65 |         std::array<double, 6> t;
      |                               ^
qbRayTrace/qbPrimatives/box.cpp:66:31: error: aggregate ‘std::array<double, 6> u’ has incomplete type and cannot be defined
   66 |         std::array<double, 6> u;
      |                               ^
qbRayTrace/qbPrimatives/box.cpp:67:31: error: aggregate ‘std::array<double, 6> v’ has incomplete type and cannot be defined
   67 |         std::array<double, 6> v;
      |                               ^
qbRayTrace/qbPrimatives/box.cpp: In member function ‘bool qbRT::Box::TestIntersection(const qbRT::Ray&)’:
qbRayTrace/qbPrimatives/box.cpp:229:31: error: variable ‘std::array<double, 6> t’ has initializer but incomplete type
  229 |         std::array<double, 6> t {100e6, 100e6, 100e6, 100e6, 100e6, 100e6};
      |                               ^
qbRayTrace/qbPrimatives/box.cpp:230:31: error: variable ‘std::array<double, 6> u’ has initializer but incomplete type
  230 |         std::array<double, 6> u {0.0, 0.0, 0.0, 0.0, 0.0, 0.0};
      |                               ^
qbRayTrace/qbPrimatives/box.cpp:231:31: error: variable ‘std::array<double, 6> v’ has initializer but incomplete type
  231 |         std::array<double, 6> v {0.0, 0.0, 0.0, 0.0, 0.0, 0.0};
      |                               ^
make: *** [makefile:31: qbRayTrace/qbPrimatives/box.o] Error 1

[QuantitativeBytes]

Thank you for raising this issue. I have been unable to replicate it on my system though, so I was wondering whether you'd managed to get it working yet? If you have, it would be good to know what the solution was!

[LRA-QC]

Hi, just worked on it tonight! I tried GCC and CLANG and had the same errors. Ended up that it was missing the array definition. I added an include for the array header in the following files (see below) and it worked.

After the changes, it worked on GCC and gave additionnal errors for CLANG. They were related to not specifying the math library which seems to be optional for GCC. If you wish to broaden the use of the project, I have included the change needed to support both. I don't think CLANG offer any advantages in this case, but it may please some people, so why not.

Cheers!

Clang compatibility (if wou want)
if you modify the makefile for the following:
LIBS = -lSDL2
to
LIBS = -lSDL2 -lm -ldl

Adding this doesn't affect GCC in any way. They both work with the new parameters.

After that modification, anyone could simply modify the g++ reference for clang++ and it works.

For fun the score of the GCC build is :
./qbRay
Loaded 3126 by 2344.
Bytes per pixel = 3
Pitch = 9380
Loaded 1024 by 1024.
Bytes per pixel = 3
Pitch = 3072
Processing line 719 of 720.

Rendering time: 3.56599s

For fun the score of the CLANG build is :
./qbRay
Loaded 3126 by 2344.
Bytes per pixel = 3
Pitch = 9380
Loaded 1024 by 1024.
Bytes per pixel = 3
Pitch = 3072
Processing line 719 of 720.

Rendering time: 4.1231s

List of files that missed the array include

diff --git a/qbRayTrace/qbNormals/image.cpp b/qbRayTrace/qbNormals/image.cpp
index 4566423..5b2929c 100644
--- a/qbRayTrace/qbNormals/image.cpp
+++ b/qbRayTrace/qbNormals/image.cpp
@@ -30,6 +30,7 @@
 ***********************************************************/
 
 #include "image.hpp"
+#include <array>
 
 // Constructor / destructor.
 qbRT::Normal::Image::Image()
diff --git a/qbRayTrace/qbPrimatives/box.cpp b/qbRayTrace/qbPrimatives/box.cpp
index b4ae545..2600d6a 100644
--- a/qbRayTrace/qbPrimatives/box.cpp
+++ b/qbRayTrace/qbPrimatives/box.cpp
@@ -33,6 +33,7 @@
 #include "box.hpp"
 #include "../qbutils.hpp"
 #include <cmath>
+#include <array>
 
 // The default constructor.
 qbRT::Box::Box()
diff --git a/qbRayTrace/qbPrimatives/cone.cpp b/qbRayTrace/qbPrimatives/cone.cpp
index f129247..6ae1759 100644
--- a/qbRayTrace/qbPrimatives/cone.cpp
+++ b/qbRayTrace/qbPrimatives/cone.cpp
@@ -36,6 +36,7 @@
 
 #include "cone.hpp"
 #include <cmath>
+#include <array>
 
 // The default constructor.
 qbRT::Cone::Cone()
diff --git a/qbRayTrace/qbPrimatives/cylinder.cpp b/qbRayTrace/qbPrimatives/cylinder.cpp
index 4b14ed9..a0fa2ae 100644
--- a/qbRayTrace/qbPrimatives/cylinder.cpp
+++ b/qbRayTrace/qbPrimatives/cylinder.cpp
@@ -36,6 +36,7 @@
 
 #include "cylinder.hpp"
 #include <cmath>
+#include <array>
 
 // The default constructor.
 qbRT::Cylinder::Cylinder()
diff --git a/qbRayTrace/qbTextures/image.cpp b/qbRayTrace/qbTextures/image.cpp
index 673090f..878f963 100644
--- a/qbRayTrace/qbTextures/image.cpp
+++ b/qbRayTrace/qbTextures/image.cpp
@@ -30,6 +30,7 @@
 ***********************************************************/
 
 #include "image.hpp"
+#include <array>