From 2a3752f274e9a903fdd9ec61d390eb26981f8ea6 Mon Sep 17 00:00:00 2001 From: Stephen Shao Date: Tue, 16 Sep 2025 19:17:15 -0400 Subject: [PATCH 1/3] The deprecated models will now be properly recorded in the performance CSV with a "SKIPPED" status, making it clear in reports which models were skipped due to deprecation. --- src/madengine/tools/run_models.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index 90741744..bdf264c6 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -923,11 +923,18 @@ def run_model(self, model_info: typing.Dict) -> bool: # Check if model is deprecated if model_info.get("is_deprecated", False): print(f"WARNING: Model {model_info['name']} has been deprecated.") - if self.args.ignore_deprecated_flag: - print(f"WARNING: Running deprecated model {model_info['name']} due to --ignore-deprecated-flag.") - else: + if not self.args.ignore_deprecated_flag: print(f"WARNING: Skipping execution. No bypass flags mentioned.") - return True # exit early + print(f"Skipping model {run_details.model} as it has been deprecated.") + # add result to output + self.return_status = True + run_details.status = "SKIPPED" + # generate exception for testing + run_details.generate_json("perf_entry.json") + update_perf_csv(exception_result="perf_entry.json", perf_csv=self.args.output) + return self.return_status # exit early + else: + print(f"WARNING: Running deprecated model {model_info['name']} due to --ignore-deprecated-flag.") # check if model is supported on current gpu architecture, if not skip. list_skip_gpu_arch = [] From 9c7a8b648ee8facde7425786a8b10ee216fa89b3 Mon Sep 17 00:00:00 2001 From: Stephen Shao Date: Wed, 17 Sep 2025 11:18:55 -0400 Subject: [PATCH 2/3] Update src/madengine/tools/run_models.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/madengine/tools/run_models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index bdf264c6..aef790b7 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -929,7 +929,7 @@ def run_model(self, model_info: typing.Dict) -> bool: # add result to output self.return_status = True run_details.status = "SKIPPED" - # generate exception for testing + # generate performance entry for CSV update run_details.generate_json("perf_entry.json") update_perf_csv(exception_result="perf_entry.json", perf_csv=self.args.output) return self.return_status # exit early From 3914ae682448200765ea2b0d0f28b1928631db04 Mon Sep 17 00:00:00 2001 From: Stephen Shao Date: Wed, 17 Sep 2025 11:24:13 -0400 Subject: [PATCH 3/3] Update src/madengine/tools/run_models.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/madengine/tools/run_models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index aef790b7..2b47b3f2 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -925,7 +925,7 @@ def run_model(self, model_info: typing.Dict) -> bool: print(f"WARNING: Model {model_info['name']} has been deprecated.") if not self.args.ignore_deprecated_flag: print(f"WARNING: Skipping execution. No bypass flags mentioned.") - print(f"Skipping model {run_details.model} as it has been deprecated.") + print(f"Skipping model {model_info['name']} as it has been deprecated.") # add result to output self.return_status = True run_details.status = "SKIPPED"