Volumes not working properly in Ray_tracing_in_one_week

[abdulrehman1612]

hello there! i have been implementing all of this ray tracing in python and so far i have had great success. until i got to volumes. as far as i have tested, the volumes return false for me when:

case1: ray origin is on the surface of the boundry
case2: ray origin is inside the boundries
volume works when camera outside sphere

it also doesn't work for box but lets not get there yet, first i want to keep it simple and solve the issue with sphere

while in book, the final render of volume 2, the camera is inside a giant sphere volume, giving this fogg.
and there is dense fogg (volume) in one of the dielectric spheres, where the case1 takes place.

i did follow exact book's implementation of the volumes and rechecked it multiple times
i also don't really understand the book's implementation of the volumes because according to that, the volumes can't return True for case1 and case2
i have attached a diagram i made to clear my point
i have also given my github which has all code files

all code files: https://github.com/abdulrehman1612/ray-tracing/tree/main/volume2

[abdulrehman1612]

update: i have fixed them. there were two bugs in my codes