Skip to content
This repository was archived by the owner on Oct 26, 2024. It is now read-only.
This repository was archived by the owner on Oct 26, 2024. It is now read-only.

feat(twitch): expand block-embedded-ads with more adblocking techniques #348

@ghost

Description

Type

Functionality

Issue

Right now the Twitch embedded ad patch supports proxy adblocking. But this comes with some issues such as(but not limited to)buffering, loading delay and sometimes twitch gives some purple screen and then I have to wait 30 seconds before the stream actually starts.

Feature

What I am requesting is adding the approach of muleyo/VideoAdBlockForTwitch#96. It works very good for me on my desktop. It doesn't need to be the default, but a toggle for it would be nice

Motivation

Adding this way of adblocking of blocking twitch ads will accomplish:
More privacy. Connecting to unknown proxies is privacy wise not a good idea
More security: Even if the owner of the proxy has no bad intentions it is still possible that senstive information gets leaked through this proxy or that scary mitm attacks appear of bad actors. Or for example the proxy owner can stop with the website and a malicious actor buys the domain which is a massive security risk
Less buffering and delays: If everything happens directly on your device(including the adblocking) then you don't need to wait for the proxy to respond
Reliability: Not dependent of the uptime of a proxy far away, not depend of the politicial situaiton in Russia for if Twitch starts serving ads again

Additional context

All of the twitch adblocking techniques that are working right now have their pro's and cons. This twitch adblocking technique is very effective, but will lower the twitch's stream resolution to 360p in the first 5 seconds

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature requestRequesting a new feature that's not implemented yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions