From fbafc281fbe12fd437d4e95ebf705a61a2e6250f Mon Sep 17 00:00:00 2001 From: Tasso Date: Tue, 13 Jan 2026 17:49:44 -0300 Subject: [PATCH] refactor(eslint): Enable `react/no-children-prop` --- .../meteor/client/components/PageSkeleton.tsx | 4 +- .../components/UserCard/UserCardRole.tsx | 2 +- .../UserInfo/UserInfoABACAttribute.tsx | 2 +- .../attachments/structure/AttachmentBlock.tsx | 5 +- .../client/portals/SidebarPortal/index.tsx | 4 +- apps/meteor/client/providers/AppsProvider.tsx | 2 +- .../client/providers/AttachmentProvider.tsx | 2 +- .../AuthenticationProvider.tsx | 2 +- .../providers/AuthorizationProvider.tsx | 2 +- .../client/providers/AvatarUrlProvider.tsx | 2 +- .../CustomSoundProvider.tsx | 2 +- .../client/providers/LayoutProvider.tsx | 5 +- .../client/providers/OmnichannelProvider.tsx | 2 +- .../client/providers/RouterProvider.tsx | 2 +- .../client/providers/ServerProvider.tsx | 2 +- .../client/providers/SessionProvider.tsx | 4 +- .../client/providers/SettingsProvider.tsx | 2 +- .../providers/ToastMessagesProvider.tsx | 4 +- .../client/providers/TranslationProvider.tsx | 4 +- .../providers/UserProvider/UserProvider.tsx | 2 +- .../FederatedRoomListErrorBoundary.tsx | 5 +- .../client/sidebar/hooks/useRoomList.spec.tsx | 5 +- .../stories/contexts/ModalContextMock.tsx | 2 +- .../stories/contexts/RouterContextMock.tsx | 2 +- .../stories/contexts/ServerContextMock.tsx | 2 +- .../contexts/TranslationContextMock.tsx | 2 +- .../CustomUserStatusDisabledModal.tsx | 16 +++---- .../EngagementDashboardCardErrorBoundary.tsx | 5 +- .../EngagementDashboardPage.stories.tsx | 2 +- .../channels/ChannelsTab.stories.tsx | 2 +- .../dataView/LegendSymbol.stories.tsx | 2 +- .../messages/MessagesTab.stories.tsx | 2 +- .../users/UsersTab.stories.tsx | 2 +- .../views/admin/invites/InvitesPage.tsx | 5 +- .../SettingsGroupPage/SettingsGroupPage.tsx | 11 ++--- .../SettingsSection/SettingsSection.tsx | 11 ++--- .../admin/settings/groups/LDAPGroupPage.tsx | 12 +++-- .../client/views/home/cards/AddUsersCard.tsx | 6 ++- .../views/home/cards/CreateChannelsCard.tsx | 6 ++- .../views/home/cards/DesktopAppsCard.tsx | 12 +++-- .../views/home/cards/DocumentationCard.tsx | 6 ++- .../client/views/home/cards/JoinRoomsCard.tsx | 6 ++- .../views/home/cards/MobileAppsCard.tsx | 8 +++- .../directory/providers/ChatsProvider.tsx | 2 +- .../omnichannel/modals/ForwardChatModal.tsx | 2 +- .../MessageList/MessageListErrorBoundary.tsx | 5 +- .../hooks/useToggleFavoriteMutation.spec.tsx | 2 +- .../DeleteMessageConfirmModal.tsx | 5 +- .../room/providers/ComposerPopupProvider.tsx | 2 +- .../root/MainLayout/AuthenticationCheck.tsx | 2 +- .../views/root/MainLayout/LoginPage.tsx | 2 +- .../tests/mocks/client/FakeChatProvider.tsx | 5 +- .../tests/mocks/client/ModalContextMock.tsx | 2 +- .../tests/mocks/client/ServerProviderMock.tsx | 2 +- apps/uikit-playground/.eslintrc.json | 2 + apps/uikit-playground/package.json | 1 + .../Components/Draggable/DraggableList.tsx | 48 +++++++++---------- .../Components/NavBar/BurgerIcon/Wrapper.tsx | 5 +- .../Templates/Container/Container.tsx | 2 +- .../Templates/Container/Section.tsx | 4 +- .../src/Components/ToggleTabs/index.tsx | 5 +- .../src/Components/navMenu/Menu/Wrapper.tsx | 5 +- .../markup/blocks/OrderedListBlock.tsx | 2 +- .../markup/blocks/ParagraphBlock.tsx | 2 +- .../markup/blocks/UnorderedListBlock.tsx | 2 +- .../markup/elements/BoldSpan.tsx | 4 +- .../markup/elements/InlineElements.tsx | 6 +-- .../markup/elements/ItalicSpan.tsx | 4 +- .../markup/elements/LinkSpan.tsx | 9 ++-- .../markup/elements/StrikeSpan.tsx | 4 +- packages/eslint-config/react.js | 1 + .../fuselage-ui-kit/.storybook/preview.tsx | 2 +- packages/gazzodown/src/Markup.tsx | 10 ++-- packages/gazzodown/src/PreviewMarkup.tsx | 8 ++-- .../gazzodown/src/blocks/OrderedListBlock.tsx | 2 +- .../gazzodown/src/blocks/ParagraphBlock.tsx | 2 +- packages/gazzodown/src/blocks/QuoteBlock.tsx | 2 +- .../gazzodown/src/blocks/TaskListBlock.tsx | 2 +- .../src/blocks/UnorderedListBlock.tsx | 2 +- packages/gazzodown/src/elements/BoldSpan.tsx | 4 +- .../gazzodown/src/elements/InlineElements.tsx | 10 ++-- .../gazzodown/src/elements/ItalicSpan.tsx | 4 +- packages/gazzodown/src/elements/LinkSpan.tsx | 6 +-- .../src/elements/PreviewInlineElements.tsx | 14 +++--- .../gazzodown/src/elements/StrikeSpan.tsx | 4 +- .../src/katex/KatexErrorBoundary.tsx | 6 ++- packages/livechat/.eslintrc.json | 1 + .../Messages/MessageBlocks/stories.tsx | 2 +- .../uiKit/message/ActionsBlock.stories.tsx | 7 +-- .../src/components/uiKit/message/Block.tsx | 5 +- .../uiKit/message/ButtonElement/index.tsx | 5 +- .../uiKit/message/ButtonElement/stories.tsx | 5 +- .../uiKit/message/ContextBlock.stories.tsx | 2 +- .../uiKit/message/DividerBlock.stories.tsx | 2 +- .../uiKit/message/ImageBlock.stories.tsx | 2 +- .../uiKit/message/ImageBlock/index.tsx | 5 +- .../uiKit/message/SectionBlock.stories.tsx | 9 ++-- .../src/components/uiKit/message/Surface.tsx | 5 +- .../livechat/src/providers/ServerProvider.tsx | 2 +- .../src/components/AnchorPortal.spec.tsx | 36 +++++++++++--- .../src/components/Modal/ModalBackdrop.tsx | 5 +- .../src/components/Page/Page.stories.tsx | 4 +- .../providers/ModalProvider/ModalProvider.tsx | 2 +- .../web-ui-registration/src/LoginServices.tsx | 6 ++- yarn.lock | 1 + 105 files changed, 296 insertions(+), 213 deletions(-) diff --git a/apps/meteor/client/components/PageSkeleton.tsx b/apps/meteor/client/components/PageSkeleton.tsx index 69606f6c3d7ce..ca6b78d3c0257 100644 --- a/apps/meteor/client/components/PageSkeleton.tsx +++ b/apps/meteor/client/components/PageSkeleton.tsx @@ -6,7 +6,9 @@ const PageSkeleton = (): ReactElement => ( }> - diff --git a/apps/meteor/client/components/UserCard/UserCardRole.tsx b/apps/meteor/client/components/UserCard/UserCardRole.tsx index 882b8d6f5c558..6687e4eb430b1 100644 --- a/apps/meteor/client/components/UserCard/UserCardRole.tsx +++ b/apps/meteor/client/components/UserCard/UserCardRole.tsx @@ -3,7 +3,7 @@ import type { ReactNode, ReactElement } from 'react'; const UserCardRole = ({ children }: { children: ReactNode }): ReactElement => ( - + {children} ); diff --git a/apps/meteor/client/components/UserInfo/UserInfoABACAttribute.tsx b/apps/meteor/client/components/UserInfo/UserInfoABACAttribute.tsx index 5605bd91d7cd7..babc25832b05b 100644 --- a/apps/meteor/client/components/UserInfo/UserInfoABACAttribute.tsx +++ b/apps/meteor/client/components/UserInfo/UserInfoABACAttribute.tsx @@ -5,7 +5,7 @@ type UserInfoABACAttributeProps = { }; const UserInfoABACAttribute = ({ attribute }: UserInfoABACAttributeProps) => { - return ; + return {attribute}; }; export default UserInfoABACAttribute; diff --git a/apps/meteor/client/components/message/content/attachments/structure/AttachmentBlock.tsx b/apps/meteor/client/components/message/content/attachments/structure/AttachmentBlock.tsx index c357b06c56936..089c350b43536 100644 --- a/apps/meteor/client/components/message/content/attachments/structure/AttachmentBlock.tsx +++ b/apps/meteor/client/components/message/content/attachments/structure/AttachmentBlock.tsx @@ -16,8 +16,9 @@ const AttachmentBlock = ({ pre, color = 'annotation', children }: AttachmentBloc borderInlineStartStyle='solid' borderInlineStartWidth='default' borderInlineStartColor={color} - children={children} - /> + > + {children} + ); diff --git a/apps/meteor/client/portals/SidebarPortal/index.tsx b/apps/meteor/client/portals/SidebarPortal/index.tsx index 9f253b274013f..fa0166ffc6dad 100644 --- a/apps/meteor/client/portals/SidebarPortal/index.tsx +++ b/apps/meteor/client/portals/SidebarPortal/index.tsx @@ -8,10 +8,10 @@ const SidebarPortal = ({ children }: { children: ReactNode }) => { return ( - + {children} - + {children} ); diff --git a/apps/meteor/client/providers/AppsProvider.tsx b/apps/meteor/client/providers/AppsProvider.tsx index df741ef976412..93e05376222e2 100644 --- a/apps/meteor/client/providers/AppsProvider.tsx +++ b/apps/meteor/client/providers/AppsProvider.tsx @@ -8,7 +8,7 @@ type AppsProviderProps = { }; const AppsProvider = ({ children }: AppsProviderProps) => { - return ; + return {children}; }; export default AppsProvider; diff --git a/apps/meteor/client/providers/AttachmentProvider.tsx b/apps/meteor/client/providers/AttachmentProvider.tsx index 9e44b1c6adf57..4ee8cc199cc5b 100644 --- a/apps/meteor/client/providers/AttachmentProvider.tsx +++ b/apps/meteor/client/providers/AttachmentProvider.tsx @@ -32,7 +32,7 @@ const AttachmentProvider = ({ children, width = 360, height = 360 }: AttachmentP [collapsedByDefault, reducedData, autoLoadEmbedMedias, saveMobileBandwidth, isMobile, width, height], ); - return ; + return {children}; }; export default AttachmentProvider; diff --git a/apps/meteor/client/providers/AuthenticationProvider/AuthenticationProvider.tsx b/apps/meteor/client/providers/AuthenticationProvider/AuthenticationProvider.tsx index 8b5d8d904607f..d32e6ec52a411 100644 --- a/apps/meteor/client/providers/AuthenticationProvider/AuthenticationProvider.tsx +++ b/apps/meteor/client/providers/AuthenticationProvider/AuthenticationProvider.tsx @@ -130,7 +130,7 @@ const AuthenticationProvider = ({ children }: AuthenticationProviderProps): Reac [isLoggingIn, loginMethod], ); - return ; + return {children}; }; export default AuthenticationProvider; diff --git a/apps/meteor/client/providers/AuthorizationProvider.tsx b/apps/meteor/client/providers/AuthorizationProvider.tsx index 52e0d6e37decf..43bab7852c273 100644 --- a/apps/meteor/client/providers/AuthorizationProvider.tsx +++ b/apps/meteor/client/providers/AuthorizationProvider.tsx @@ -35,7 +35,7 @@ const AuthorizationProvider = ({ children }: AuthorizationProviderProps) => { [userId], ); - return ; + return {children}; }; export default AuthorizationProvider; diff --git a/apps/meteor/client/providers/AvatarUrlProvider.tsx b/apps/meteor/client/providers/AvatarUrlProvider.tsx index 161e4cc531ee2..85538a36b9ca0 100644 --- a/apps/meteor/client/providers/AvatarUrlProvider.tsx +++ b/apps/meteor/client/providers/AvatarUrlProvider.tsx @@ -34,7 +34,7 @@ const AvatarUrlProvider = ({ children }: AvatarUrlProviderProps) => { }; }, []); - return ; + return {children}; }; export default AvatarUrlProvider; diff --git a/apps/meteor/client/providers/CustomSoundProvider/CustomSoundProvider.tsx b/apps/meteor/client/providers/CustomSoundProvider/CustomSoundProvider.tsx index 4fced774af5b5..03499b5a214c4 100644 --- a/apps/meteor/client/providers/CustomSoundProvider/CustomSoundProvider.tsx +++ b/apps/meteor/client/providers/CustomSoundProvider/CustomSoundProvider.tsx @@ -126,7 +126,7 @@ const CustomSoundProvider = ({ children }: CustomSoundProviderProps) => { }); }, [queryClient, streamAll]); - return ; + return {children}; }; export default CustomSoundProvider; diff --git a/apps/meteor/client/providers/LayoutProvider.tsx b/apps/meteor/client/providers/LayoutProvider.tsx index 2ef162b26c3c9..9a1fb57979deb 100644 --- a/apps/meteor/client/providers/LayoutProvider.tsx +++ b/apps/meteor/client/providers/LayoutProvider.tsx @@ -54,7 +54,6 @@ const LayoutProvider = ({ children }: LayoutProviderProps) => { return ( ({ isMobile, @@ -108,7 +107,9 @@ const LayoutProvider = ({ children }: LayoutProviderProps) => { router, ], )} - /> + > + {children} + ); }; diff --git a/apps/meteor/client/providers/OmnichannelProvider.tsx b/apps/meteor/client/providers/OmnichannelProvider.tsx index d95c4e5774793..edf4adb630f3d 100644 --- a/apps/meteor/client/providers/OmnichannelProvider.tsx +++ b/apps/meteor/client/providers/OmnichannelProvider.tsx @@ -220,7 +220,7 @@ const OmnichannelProvider = ({ children }: OmnichannelProviderProps) => { isOverMacLimit, ]); - return ; + return {children}; }; export default memo(OmnichannelProvider); diff --git a/apps/meteor/client/providers/RouterProvider.tsx b/apps/meteor/client/providers/RouterProvider.tsx index 099835e672894..77fc0e28c50b8 100644 --- a/apps/meteor/client/providers/RouterProvider.tsx +++ b/apps/meteor/client/providers/RouterProvider.tsx @@ -11,6 +11,6 @@ type RouterProviderProps = { children?: ReactNode; }; -const RouterProvider = ({ children }: RouterProviderProps) => ; +const RouterProvider = ({ children }: RouterProviderProps) => {children}; export default RouterProvider; diff --git a/apps/meteor/client/providers/ServerProvider.tsx b/apps/meteor/client/providers/ServerProvider.tsx index b37d86b5fea48..e8f546d73f064 100644 --- a/apps/meteor/client/providers/ServerProvider.tsx +++ b/apps/meteor/client/providers/ServerProvider.tsx @@ -104,7 +104,7 @@ const ServerProvider = ({ children }: ServerProviderProps) => { [connected, retryCount, retryTime, status], ); - return ; + return {children}; }; export default ServerProvider; diff --git a/apps/meteor/client/providers/SessionProvider.tsx b/apps/meteor/client/providers/SessionProvider.tsx index faa3157762dfa..00d33729bad9a 100644 --- a/apps/meteor/client/providers/SessionProvider.tsx +++ b/apps/meteor/client/providers/SessionProvider.tsx @@ -15,6 +15,8 @@ type SessionProviderProps = { children?: ReactNode; }; -const SessionProvider = ({ children }: SessionProviderProps) => ; +const SessionProvider = ({ children }: SessionProviderProps) => ( + {children} +); export default SessionProvider; diff --git a/apps/meteor/client/providers/SettingsProvider.tsx b/apps/meteor/client/providers/SettingsProvider.tsx index bb9c4e9128257..d90f167e6feaf 100644 --- a/apps/meteor/client/providers/SettingsProvider.tsx +++ b/apps/meteor/client/providers/SettingsProvider.tsx @@ -121,7 +121,7 @@ const SettingsProvider = ({ children }: SettingsProviderProps) => { [canManageSettings, querySetting, querySettings, dispatch], ); - return ; + return {children}; }; export default SettingsProvider; diff --git a/apps/meteor/client/providers/ToastMessagesProvider.tsx b/apps/meteor/client/providers/ToastMessagesProvider.tsx index e0c831889976b..8df55abd71dbb 100644 --- a/apps/meteor/client/providers/ToastMessagesProvider.tsx +++ b/apps/meteor/client/providers/ToastMessagesProvider.tsx @@ -71,7 +71,7 @@ const ToastMessageInnerProvider = ({ children }: ToastMessageInnerProviderProps) [dispatchToastBar], ); - return ; + return {children}; }; type ToastMessagesProviderProps = { @@ -81,7 +81,7 @@ type ToastMessagesProviderProps = { // eslint-disable-next-line react/no-multi-comp const ToastMessagesProvider = ({ children }: ToastMessagesProviderProps) => ( - + {children} ); diff --git a/apps/meteor/client/providers/TranslationProvider.tsx b/apps/meteor/client/providers/TranslationProvider.tsx index 5a29aa248140e..c8aaabbf8470c 100644 --- a/apps/meteor/client/providers/TranslationProvider.tsx +++ b/apps/meteor/client/providers/TranslationProvider.tsx @@ -245,7 +245,7 @@ const TranslationProvider = ({ children }: TranslationProviderProps): ReactEleme return ( - + {children} ); }; @@ -286,7 +286,7 @@ const TranslationProviderInner = ({ [availableLanguages, i18n, t], ); - return ; + return {children}; }; export default TranslationProvider; diff --git a/apps/meteor/client/providers/UserProvider/UserProvider.tsx b/apps/meteor/client/providers/UserProvider/UserProvider.tsx index 1faeac2f31dab..a2aa71db30f31 100644 --- a/apps/meteor/client/providers/UserProvider/UserProvider.tsx +++ b/apps/meteor/client/providers/UserProvider/UserProvider.tsx @@ -187,7 +187,7 @@ const UserProvider = ({ children }: UserProviderProps): ReactElement => { previousUserId.current = userId; }, [queryClient, userId]); - return ; + return {children}; }; export default UserProvider; diff --git a/apps/meteor/client/sidebar/header/MatrixFederationSearch/FederatedRoomListErrorBoundary.tsx b/apps/meteor/client/sidebar/header/MatrixFederationSearch/FederatedRoomListErrorBoundary.tsx index a8c29daa16475..31f51006661d0 100644 --- a/apps/meteor/client/sidebar/header/MatrixFederationSearch/FederatedRoomListErrorBoundary.tsx +++ b/apps/meteor/client/sidebar/header/MatrixFederationSearch/FederatedRoomListErrorBoundary.tsx @@ -16,7 +16,6 @@ const FederatedRoomListErrorBoundary = ({ children, resetKeys }: FederatedRoomLi {({ reset }) => ( ( @@ -35,7 +34,9 @@ const FederatedRoomListErrorBoundary = ({ children, resetKeys }: FederatedRoomLi )} - /> + > + {children} + )} ); diff --git a/apps/meteor/client/sidebar/hooks/useRoomList.spec.tsx b/apps/meteor/client/sidebar/hooks/useRoomList.spec.tsx index 4472104644e2b..ea8ca667ec079 100644 --- a/apps/meteor/client/sidebar/hooks/useRoomList.spec.tsx +++ b/apps/meteor/client/sidebar/hooks/useRoomList.spec.tsx @@ -83,8 +83,9 @@ const getWrapperSettings = ({ queryIncomingCalls: () => [() => () => undefined, () => emptyArr], } as any } - children={children} - /> + > + {children} + )) .withUser(user) .withSubscriptions([...fakeRooms, fakeRoom && fakeRoom].filter(Boolean) as unknown as SubscriptionWithRoom[]) diff --git a/apps/meteor/client/stories/contexts/ModalContextMock.tsx b/apps/meteor/client/stories/contexts/ModalContextMock.tsx index 2e5f4171ba65c..ee8074ddd64c5 100644 --- a/apps/meteor/client/stories/contexts/ModalContextMock.tsx +++ b/apps/meteor/client/stories/contexts/ModalContextMock.tsx @@ -28,7 +28,7 @@ const ModalContextMock = ({ children }: ModalContextMockProps): ReactElement => [context], ); - return ; + return {children}; }; export default ModalContextMock; diff --git a/apps/meteor/client/stories/contexts/RouterContextMock.tsx b/apps/meteor/client/stories/contexts/RouterContextMock.tsx index 73a12a7abe625..793baab27641b 100644 --- a/apps/meteor/client/stories/contexts/RouterContextMock.tsx +++ b/apps/meteor/client/stories/contexts/RouterContextMock.tsx @@ -28,7 +28,7 @@ const RouterContextMock = ({ children }: RouterContextMockProps): ReactElement = [parent], ); - return ; + return {children}; }; export default RouterContextMock; diff --git a/apps/meteor/client/stories/contexts/ServerContextMock.tsx b/apps/meteor/client/stories/contexts/ServerContextMock.tsx index 43c1f058e92fa..86aba2337f96a 100644 --- a/apps/meteor/client/stories/contexts/ServerContextMock.tsx +++ b/apps/meteor/client/stories/contexts/ServerContextMock.tsx @@ -181,7 +181,7 @@ const ServerContextMock = ({ }; }, [baseURL, callEndpoint, callMethod, overrides, parent]); - return ; + return {children}; }; export default ServerContextMock; diff --git a/apps/meteor/client/stories/contexts/TranslationContextMock.tsx b/apps/meteor/client/stories/contexts/TranslationContextMock.tsx index 4d1764160a235..20d0128316f9e 100644 --- a/apps/meteor/client/stories/contexts/TranslationContextMock.tsx +++ b/apps/meteor/client/stories/contexts/TranslationContextMock.tsx @@ -61,7 +61,7 @@ const TranslationContextMock = ({ children }: TranslationContextMockProps): Reac }; }, [parent]); - return ; + return {children}; }; export default TranslationContextMock; diff --git a/apps/meteor/client/views/admin/customUserStatus/CustomUserStatusDisabledModal.tsx b/apps/meteor/client/views/admin/customUserStatus/CustomUserStatusDisabledModal.tsx index ace971977c1d9..7f8ad4a25a6bd 100644 --- a/apps/meteor/client/views/admin/customUserStatus/CustomUserStatusDisabledModal.tsx +++ b/apps/meteor/client/views/admin/customUserStatus/CustomUserStatusDisabledModal.tsx @@ -10,22 +10,18 @@ const CustomUserStatusDisabledModal = ({ isAdmin, onConfirm, onClose }: CustomUs title={t('User_status_disabled_learn_more')} cancelText={t('Close')} confirmText={t('Go_to_workspace_settings')} - children={t('User_status_disabled_learn_more_description')} onConfirm={onConfirm} onClose={onClose} onCancel={onClose} icon={null} variant='warning' - /> + > + {t('User_status_disabled_learn_more_description')} + ) : ( - + + {t('User_status_disabled_learn_more_description')} + ); }; diff --git a/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardErrorBoundary.tsx b/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardErrorBoundary.tsx index dcfe34ff50e2f..02ae71e06d698 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardErrorBoundary.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardErrorBoundary.tsx @@ -24,7 +24,6 @@ const EngagementDashboardCardErrorBoundary = ({ children }: EngagementDashboardC {({ reset }): ReactElement => ( ( @@ -37,7 +36,9 @@ const EngagementDashboardCardErrorBoundary = ({ children }: EngagementDashboardC )} - /> + > + {children} + )} ); diff --git a/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardPage.stories.tsx b/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardPage.stories.tsx index 63a13b55ce204..b81858049a6c7 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardPage.stories.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardPage.stories.tsx @@ -5,7 +5,7 @@ import EngagementDashboardPage from './EngagementDashboardPage'; export default { component: EngagementDashboardPage, - decorators: [(fn): ReactElement =>
], + decorators: [(fn): ReactElement =>
{fn()}
], } satisfies Meta; export const Default: StoryFn = () => ; diff --git a/apps/meteor/client/views/admin/engagementDashboard/channels/ChannelsTab.stories.tsx b/apps/meteor/client/views/admin/engagementDashboard/channels/ChannelsTab.stories.tsx index 52d970e5dfa75..2456c122aecd2 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/channels/ChannelsTab.stories.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/channels/ChannelsTab.stories.tsx @@ -5,7 +5,7 @@ import ChannelsTab from './ChannelsOverview'; export default { component: ChannelsTab, - decorators: [(fn) => ], + decorators: [(fn) => {fn()}], } satisfies Meta; export const Default: StoryFn = () => ; diff --git a/apps/meteor/client/views/admin/engagementDashboard/dataView/LegendSymbol.stories.tsx b/apps/meteor/client/views/admin/engagementDashboard/dataView/LegendSymbol.stories.tsx index ff89692a3a82b..ad40db0535954 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/dataView/LegendSymbol.stories.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/dataView/LegendSymbol.stories.tsx @@ -7,7 +7,7 @@ import { monochromaticColors, polychromaticColors } from './colors'; export default { component: LegendSymbol, - decorators: [(fn): ReactElement => ], + decorators: [(fn): ReactElement => {fn()}], } satisfies Meta; export const withoutColor: StoryFn = () => ( diff --git a/apps/meteor/client/views/admin/engagementDashboard/messages/MessagesTab.stories.tsx b/apps/meteor/client/views/admin/engagementDashboard/messages/MessagesTab.stories.tsx index 201555c51fb87..5b57acaef630d 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/messages/MessagesTab.stories.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/messages/MessagesTab.stories.tsx @@ -5,7 +5,7 @@ import MessagesTab from './MessagesTab'; export default { component: MessagesTab, - decorators: [(fn) => ], + decorators: [(fn) => {fn()}], } satisfies Meta; export const Default: StoryFn = () => ; diff --git a/apps/meteor/client/views/admin/engagementDashboard/users/UsersTab.stories.tsx b/apps/meteor/client/views/admin/engagementDashboard/users/UsersTab.stories.tsx index 165ee34b56f8a..b89f32efad5ec 100644 --- a/apps/meteor/client/views/admin/engagementDashboard/users/UsersTab.stories.tsx +++ b/apps/meteor/client/views/admin/engagementDashboard/users/UsersTab.stories.tsx @@ -6,7 +6,7 @@ import UsersTab from './UsersTab'; export default { component: UsersTab, - decorators: [(fn): ReactElement => ], + decorators: [(fn): ReactElement => {fn()}], } satisfies Meta; export const Default: StoryFn = () => ; diff --git a/apps/meteor/client/views/admin/invites/InvitesPage.tsx b/apps/meteor/client/views/admin/invites/InvitesPage.tsx index e123d50b2379d..efc94915cdf7a 100644 --- a/apps/meteor/client/views/admin/invites/InvitesPage.tsx +++ b/apps/meteor/client/views/admin/invites/InvitesPage.tsx @@ -55,14 +55,15 @@ const InvitesPage = (): ReactElement => { setModal( setModal()} onCancel={(): void => setModal()} onConfirm={confirmRemove} - />, + > + {t('Are_you_sure_you_want_to_delete_this_record')} + , ); }; diff --git a/apps/meteor/client/views/admin/settings/SettingsGroupPage/SettingsGroupPage.tsx b/apps/meteor/client/views/admin/settings/SettingsGroupPage/SettingsGroupPage.tsx index 2ae5eea8cd127..10947f5758f28 100644 --- a/apps/meteor/client/views/admin/settings/SettingsGroupPage/SettingsGroupPage.tsx +++ b/apps/meteor/client/views/admin/settings/SettingsGroupPage/SettingsGroupPage.tsx @@ -163,14 +163,9 @@ const SettingsGroupPage = ({ {t('Cancel')} )} - diff --git a/apps/meteor/client/views/admin/settings/SettingsSection/SettingsSection.tsx b/apps/meteor/client/views/admin/settings/SettingsSection/SettingsSection.tsx index 1f2eb77b4f64e..9a59aaffb2070 100644 --- a/apps/meteor/client/views/admin/settings/SettingsSection/SettingsSection.tsx +++ b/apps/meteor/client/views/admin/settings/SettingsSection/SettingsSection.tsx @@ -89,14 +89,9 @@ function SettingsSection({ groupId, hasReset = true, sectionName, currentTab, so {children} {hasReset && canReset && ( - )} ); diff --git a/apps/meteor/client/views/admin/settings/groups/LDAPGroupPage.tsx b/apps/meteor/client/views/admin/settings/groups/LDAPGroupPage.tsx index 85f4dca30267c..2ae03dbb563ff 100644 --- a/apps/meteor/client/views/admin/settings/groups/LDAPGroupPage.tsx +++ b/apps/meteor/client/views/admin/settings/groups/LDAPGroupPage.tsx @@ -138,9 +138,15 @@ function LDAPGroupPage({ _id, i18nLabel, onClickBack, ...group }: LDAPGroupPageP {...group} headerButtons={ <> - + + diff --git a/apps/meteor/client/views/home/cards/AddUsersCard.tsx b/apps/meteor/client/views/home/cards/AddUsersCard.tsx index bc5265bfac083..dea1090f786b7 100644 --- a/apps/meteor/client/views/home/cards/AddUsersCard.tsx +++ b/apps/meteor/client/views/home/cards/AddUsersCard.tsx @@ -16,7 +16,11 @@ const AddUsersCard = (props: Omit, 'type'>): ReactEl ]} + buttons={[ + + {t('Add_users')} + , + ]} width='x340' {...props} /> diff --git a/apps/meteor/client/views/home/cards/CreateChannelsCard.tsx b/apps/meteor/client/views/home/cards/CreateChannelsCard.tsx index ed363c51fae95..8083f005aa3c7 100644 --- a/apps/meteor/client/views/home/cards/CreateChannelsCard.tsx +++ b/apps/meteor/client/views/home/cards/CreateChannelsCard.tsx @@ -15,7 +15,11 @@ const CreateChannelsCard = (props: Omit, 'type'>): R ]} + buttons={[ + + {t('Create_channel')} + , + ]} width='x340' {...props} /> diff --git a/apps/meteor/client/views/home/cards/DesktopAppsCard.tsx b/apps/meteor/client/views/home/cards/DesktopAppsCard.tsx index 674385f6ca27d..d4165f0f746b9 100644 --- a/apps/meteor/client/views/home/cards/DesktopAppsCard.tsx +++ b/apps/meteor/client/views/home/cards/DesktopAppsCard.tsx @@ -19,9 +19,15 @@ const DesktopAppsCard = (props: Omit, 'type'>): Reac title={t('Desktop_apps')} body={t('Install_rocket_chat_on_your_preferred_desktop_platform')} buttons={[ - handleOpenLink(WINDOWS_APP_URL)} children={t('Platform_Windows')} role='link' />, - handleOpenLink(LINUX_APP_URL)} children={t('Platform_Linux')} role='link' />, - handleOpenLink(MAC_APP_URL)} children={t('Platform_Mac')} role='link' />, + handleOpenLink(WINDOWS_APP_URL)} role='link'> + {t('Platform_Windows')} + , + handleOpenLink(LINUX_APP_URL)} role='link'> + {t('Platform_Linux')} + , + handleOpenLink(MAC_APP_URL)} role='link'> + {t('Platform_Mac')} + , ]} width='x340' {...props} diff --git a/apps/meteor/client/views/home/cards/DocumentationCard.tsx b/apps/meteor/client/views/home/cards/DocumentationCard.tsx index 104b2f1938660..7854b4dfc718b 100644 --- a/apps/meteor/client/views/home/cards/DocumentationCard.tsx +++ b/apps/meteor/client/views/home/cards/DocumentationCard.tsx @@ -16,7 +16,11 @@ const DocumentationCard = (props: Omit, 'type'>): Re handleOpenLink(DOCS_URL)} children={t('See_documentation')} role='link' />]} + buttons={[ + handleOpenLink(DOCS_URL)} role='link'> + {t('See_documentation')} + , + ]} width='x340' {...props} /> diff --git a/apps/meteor/client/views/home/cards/JoinRoomsCard.tsx b/apps/meteor/client/views/home/cards/JoinRoomsCard.tsx index 8ff00d2d5dc09..f0ff5b45de9d5 100644 --- a/apps/meteor/client/views/home/cards/JoinRoomsCard.tsx +++ b/apps/meteor/client/views/home/cards/JoinRoomsCard.tsx @@ -16,7 +16,11 @@ const JoinRoomsCard = (props: Omit, 'type'>): ReactE ]} + buttons={[ + + {t('Open_directory')} + , + ]} width='x340' {...props} /> diff --git a/apps/meteor/client/views/home/cards/MobileAppsCard.tsx b/apps/meteor/client/views/home/cards/MobileAppsCard.tsx index e91cf3fabcfc3..bc88d2bc8d43e 100644 --- a/apps/meteor/client/views/home/cards/MobileAppsCard.tsx +++ b/apps/meteor/client/views/home/cards/MobileAppsCard.tsx @@ -18,8 +18,12 @@ const MobileAppsCard = (props: Omit, 'type'>): React title={t('Mobile_apps')} body={t('Take_rocket_chat_with_you_with_mobile_applications')} buttons={[ - handleOpenLink(GOOGLE_PLAY_URL)} children={t('Google_Play')} role='link' />, - handleOpenLink(APP_STORE_URL)} children={t('App_Store')} role='link' />, + handleOpenLink(GOOGLE_PLAY_URL)} role='link'> + {t('Google_Play')} + , + handleOpenLink(APP_STORE_URL)} role='link'> + {t('App_Store')} + , ]} width='x340' {...props} diff --git a/apps/meteor/client/views/omnichannel/directory/providers/ChatsProvider.tsx b/apps/meteor/client/views/omnichannel/directory/providers/ChatsProvider.tsx index 545c0bcfc08e1..13362ed52977e 100644 --- a/apps/meteor/client/views/omnichannel/directory/providers/ChatsProvider.tsx +++ b/apps/meteor/client/views/omnichannel/directory/providers/ChatsProvider.tsx @@ -45,7 +45,7 @@ const ChatsProvider = ({ children }: ChatsProviderProps) => { [displayFilters, filtersQuery, setFiltersQuery], ); - return ; + return {children}; }; export default ChatsProvider; diff --git a/apps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsx b/apps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsx index 0f99674040599..a0b59d9add935 100644 --- a/apps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsx +++ b/apps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsx @@ -110,7 +110,7 @@ const ForwardChatModal = ({ onForward, onCancel, room, ...props }: ForwardChatMo /> - + {t('or')} {t('Forward_to_user')} diff --git a/apps/meteor/client/views/room/MessageList/MessageListErrorBoundary.tsx b/apps/meteor/client/views/room/MessageList/MessageListErrorBoundary.tsx index b8a3e32fa8479..4b32e954c93a6 100644 --- a/apps/meteor/client/views/room/MessageList/MessageListErrorBoundary.tsx +++ b/apps/meteor/client/views/room/MessageList/MessageListErrorBoundary.tsx @@ -11,7 +11,6 @@ const MessageListErrorBoundary = ({ children }: { children: ReactNode }): ReactE return ( @@ -29,7 +28,9 @@ const MessageListErrorBoundary = ({ children }: { children: ReactNode }): ReactE } - /> + > + {children} + ); }; diff --git a/apps/meteor/client/views/room/hooks/useToggleFavoriteMutation.spec.tsx b/apps/meteor/client/views/room/hooks/useToggleFavoriteMutation.spec.tsx index a005a4ef5c694..5843aefeb5f9f 100644 --- a/apps/meteor/client/views/room/hooks/useToggleFavoriteMutation.spec.tsx +++ b/apps/meteor/client/views/room/hooks/useToggleFavoriteMutation.spec.tsx @@ -28,7 +28,7 @@ it('should invalidate any subscription queries', async () => { const { result } = renderHook(() => useToggleFavoriteMutation(), { wrapper: mockAppRoot() .withEndpoint('POST', '/v1/rooms.favorite', async () => null) - .wrap((children) => ) + .wrap((children) => {children}) .build(), }); diff --git a/apps/meteor/client/views/room/modals/DeleteMessageConfirmModal/DeleteMessageConfirmModal.tsx b/apps/meteor/client/views/room/modals/DeleteMessageConfirmModal/DeleteMessageConfirmModal.tsx index 40c8486a03691..0a3103f290cf9 100644 --- a/apps/meteor/client/views/room/modals/DeleteMessageConfirmModal/DeleteMessageConfirmModal.tsx +++ b/apps/meteor/client/views/room/modals/DeleteMessageConfirmModal/DeleteMessageConfirmModal.tsx @@ -56,11 +56,12 @@ const DeleteMessageConfirmModal = ({ variant='danger' title={t('Are_you_sure')} confirmText={t('Yes_delete_it')} - children={room ? t('The_message_is_a_discussion_you_will_not_be_able_to_recover') : t('You_will_not_be_able_to_recover')} onConfirm={deleteMessageMutation.mutate} onCancel={onCancel} confirmDisabled={deleteMessageMutation.isPending} - /> + > + {room ? t('The_message_is_a_discussion_you_will_not_be_able_to_recover') : t('You_will_not_be_able_to_recover')} + ); }; diff --git a/apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx b/apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx index c1133eef6cc0a..0074e07a0a61b 100644 --- a/apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx +++ b/apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx @@ -402,7 +402,7 @@ const ComposerPopupProvider = ({ children, room }: ComposerPopupProviderProps) = userSpotlight, ]); - return ; + return {children}; }; export default ComposerPopupProvider; diff --git a/apps/meteor/client/views/root/MainLayout/AuthenticationCheck.tsx b/apps/meteor/client/views/root/MainLayout/AuthenticationCheck.tsx index 822acfc22562b..928f3e38d762c 100644 --- a/apps/meteor/client/views/root/MainLayout/AuthenticationCheck.tsx +++ b/apps/meteor/client/views/root/MainLayout/AuthenticationCheck.tsx @@ -29,7 +29,7 @@ const AuthenticationCheck = ({ children, guest }: { children: ReactNode; guest?: } if (!forceLogin && guest) { - return ; + return {children}; } if (!forceLogin && allowAnonymousRead) { diff --git a/apps/meteor/client/views/root/MainLayout/LoginPage.tsx b/apps/meteor/client/views/root/MainLayout/LoginPage.tsx index d270bcba6c465..7b4574419b37a 100644 --- a/apps/meteor/client/views/root/MainLayout/LoginPage.tsx +++ b/apps/meteor/client/views/root/MainLayout/LoginPage.tsx @@ -28,7 +28,7 @@ const LoginPage = ({ defaultRoute, children }: { defaultRoute?: LoginRoutes; chi return ( <> {showForcedLogoutBanner && } - + {children} ); }; diff --git a/apps/meteor/tests/mocks/client/FakeChatProvider.tsx b/apps/meteor/tests/mocks/client/FakeChatProvider.tsx index 542b5e3313394..a71e49df666e8 100644 --- a/apps/meteor/tests/mocks/client/FakeChatProvider.tsx +++ b/apps/meteor/tests/mocks/client/FakeChatProvider.tsx @@ -10,7 +10,6 @@ type FakeChatProviderProps = { const FakeChatProvider = ({ children }: FakeChatProviderProps): ReactElement => { return ( }, } as any } - /> + > + {children} + ); }; diff --git a/apps/meteor/tests/mocks/client/ModalContextMock.tsx b/apps/meteor/tests/mocks/client/ModalContextMock.tsx index 1bbdb2270bcb9..07d97156b1ac5 100644 --- a/apps/meteor/tests/mocks/client/ModalContextMock.tsx +++ b/apps/meteor/tests/mocks/client/ModalContextMock.tsx @@ -16,7 +16,7 @@ const ModalContextMock = ({ children }: ModalContextMockProps): ReactElement => [], ); - return } />; + return }>{children}; }; export default ModalContextMock; diff --git a/apps/meteor/tests/mocks/client/ServerProviderMock.tsx b/apps/meteor/tests/mocks/client/ServerProviderMock.tsx index 0013872b1038d..f59649eaae083 100644 --- a/apps/meteor/tests/mocks/client/ServerProviderMock.tsx +++ b/apps/meteor/tests/mocks/client/ServerProviderMock.tsx @@ -83,7 +83,7 @@ type ServerProviderMockProps = { const ServerProviderMock = ({ children, callEndpoint }: ServerProviderMockProps) => { const value = useMemo(() => ({ ...contextValue, callEndpoint: callEndpoint ?? contextValue.callEndpoint }), [callEndpoint]); - return ; + return {children}; }; export default ServerProviderMock; diff --git a/apps/uikit-playground/.eslintrc.json b/apps/uikit-playground/.eslintrc.json index 972542b9e3ceb..bf9b095684aee 100644 --- a/apps/uikit-playground/.eslintrc.json +++ b/apps/uikit-playground/.eslintrc.json @@ -3,6 +3,8 @@ "extends": [ "eslint:recommended", "plugin:@typescript-eslint/recommended", + "plugin:react/recommended", + "plugin:react/jsx-runtime", "plugin:react-hooks/recommended" ], "parser": "@typescript-eslint/parser", diff --git a/apps/uikit-playground/package.json b/apps/uikit-playground/package.json index c6065db01545d..845d53be559b7 100644 --- a/apps/uikit-playground/package.json +++ b/apps/uikit-playground/package.json @@ -52,6 +52,7 @@ "@typescript-eslint/parser": "~5.60.1", "@vitejs/plugin-react": "~4.5.2", "eslint": "~8.45.0", + "eslint-plugin-react": "~7.37.5", "eslint-plugin-react-hooks": "^5.0.0", "eslint-plugin-react-refresh": "^0.4.24", "typescript": "~5.9.3", diff --git a/apps/uikit-playground/src/Components/Draggable/DraggableList.tsx b/apps/uikit-playground/src/Components/Draggable/DraggableList.tsx index a94ebbefbe95c..db7b3968a3d91 100644 --- a/apps/uikit-playground/src/Components/Draggable/DraggableList.tsx +++ b/apps/uikit-playground/src/Components/Draggable/DraggableList.tsx @@ -17,30 +17,28 @@ export type DraggableListProps = { onDragEnd: OnDragEndResponder; }; -const DraggableList = memo( - ({ blocks, surface, onDragEnd }: DraggableListProps) => ( - - - {(provided) => ( -
- {blocks.map((block, index) => ( - - ))} - {provided.placeholder} -
- )} -
-
- ) +const DraggableList = ({ blocks, surface, onDragEnd }: DraggableListProps) => ( + + + {(provided) => ( +
+ {blocks.map((block, index) => ( + + ))} + {provided.placeholder} +
+ )} +
+
); -export default DraggableList; +export default memo(DraggableList); diff --git a/apps/uikit-playground/src/Components/NavBar/BurgerIcon/Wrapper.tsx b/apps/uikit-playground/src/Components/NavBar/BurgerIcon/Wrapper.tsx index 661e0a67d0d37..2decc3d2eff60 100644 --- a/apps/uikit-playground/src/Components/NavBar/BurgerIcon/Wrapper.tsx +++ b/apps/uikit-playground/src/Components/NavBar/BurgerIcon/Wrapper.tsx @@ -12,13 +12,14 @@ const Wrapper = ({ children }: { children: ReactNode }): ReactElement => ( paddingBlock={4} paddingInline={2} verticalAlign="middle" - children={children} height="x24" className={css` cursor: pointer; `} width="x24" - /> + > + {children} + ); export default Wrapper; diff --git a/apps/uikit-playground/src/Components/Templates/Container/Container.tsx b/apps/uikit-playground/src/Components/Templates/Container/Container.tsx index f52f3a3005b6f..bc2194e1a8c58 100644 --- a/apps/uikit-playground/src/Components/Templates/Container/Container.tsx +++ b/apps/uikit-playground/src/Components/Templates/Container/Container.tsx @@ -6,7 +6,7 @@ import Section from './Section'; const Container = ({ templates }: { templates: templateType[] }) => ( {templates && - templates.map((template, i) =>
)} + templates.map((template, i) =>
)} ); diff --git a/apps/uikit-playground/src/Components/Templates/Container/Section.tsx b/apps/uikit-playground/src/Components/Templates/Container/Section.tsx index 954020bcf2dfa..a7408bbcd740a 100644 --- a/apps/uikit-playground/src/Components/Templates/Container/Section.tsx +++ b/apps/uikit-playground/src/Components/Templates/Container/Section.tsx @@ -19,8 +19,8 @@ const Section = ({ - {template.payloads.map((payload) => ( - + {template.payloads.map((payload, i) => ( + ))} ); diff --git a/apps/uikit-playground/src/Components/ToggleTabs/index.tsx b/apps/uikit-playground/src/Components/ToggleTabs/index.tsx index 1a949b5c1a02b..bd10524a02a04 100644 --- a/apps/uikit-playground/src/Components/ToggleTabs/index.tsx +++ b/apps/uikit-playground/src/Components/ToggleTabs/index.tsx @@ -25,8 +25,9 @@ const ToggleTabs = ({ selected={selectedTab === index} onClick={() => onChange(index)} className={disableBorder} - children={item} - /> + > + {item} + ))} ); diff --git a/apps/uikit-playground/src/Components/navMenu/Menu/Wrapper.tsx b/apps/uikit-playground/src/Components/navMenu/Menu/Wrapper.tsx index cbbd1fa94d694..a1cbc36b43a46 100644 --- a/apps/uikit-playground/src/Components/navMenu/Menu/Wrapper.tsx +++ b/apps/uikit-playground/src/Components/navMenu/Menu/Wrapper.tsx @@ -10,10 +10,11 @@ const Wrapper = ({ children }: { children: ReactNode }): ReactElement => ( alignItems="center" justifyContent="space-between" verticalAlign="middle" - children={children} height="max-content" width="100%" - /> + > + {children} + ); export default Wrapper; diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/OrderedListBlock.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/OrderedListBlock.tsx index fbfecc379651f..9bdcc0553f223 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/OrderedListBlock.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/OrderedListBlock.tsx @@ -24,7 +24,7 @@ const OrderedListBlock = ({ items }: OrderedListBlockProps) => ( {items.map(({ value, number }, index) => ( - {number}. + {number}. {value} ))} diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/ParagraphBlock.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/ParagraphBlock.tsx index 9d3f8db9071d6..d0ffe33a7a8bc 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/ParagraphBlock.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/ParagraphBlock.tsx @@ -6,6 +6,6 @@ type ParagraphBlockProps = { items: MessageParser.Inlines[]; }; -const ParagraphBlock = ({ items }: ParagraphBlockProps) => ; +const ParagraphBlock = ({ items }: ParagraphBlockProps) => {items}; export default ParagraphBlock; diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/UnorderedListBlock.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/UnorderedListBlock.tsx index ec074fc77d9fb..964c9023520f0 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/UnorderedListBlock.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/UnorderedListBlock.tsx @@ -24,7 +24,7 @@ const UnorderedListBlock = ({ items }: UnorderedListBlockProps) => ( {items.map(({ value }, index) => ( - + {value} ))} diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/BoldSpan.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/BoldSpan.tsx index 043d05e9ae0f7..a1c1ef3363e14 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/BoldSpan.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/BoldSpan.tsx @@ -48,10 +48,10 @@ const renderBlockComponent = (child: MessageBlock, index: number) => { return {child.value}; case 'STRIKE': - return ; + return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'EMOJI': return ; diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/InlineElements.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/InlineElements.tsx index 64b99cfd30e9f..b55f96ea2fd29 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/InlineElements.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/InlineElements.tsx @@ -17,13 +17,13 @@ const InlineElements = ({ children }: InlineElementsProps) => ( {children.map((child, index) => { switch (child.type) { case 'BOLD': - return ; + return {child.value}; case 'STRIKE': - return ; + return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'LINK': return ; diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/ItalicSpan.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/ItalicSpan.tsx index 1b7cc2abe9da7..b568d23609df0 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/ItalicSpan.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/ItalicSpan.tsx @@ -48,10 +48,10 @@ const renderBlockComponent = (child: MessageBlock, index: number) => { return {child.value}; case 'STRIKE': - return ; + return {child.value}; case 'BOLD': - return ; + return {child.value}; case 'EMOJI': return ; diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx index 3d9f15cb07e63..e0a274b49e7e1 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx @@ -21,14 +21,11 @@ const LinkSpan = ({ label }: LinkSpanProps): ReactElement => { return {child.value.trim()}; case 'STRIKE': - return ; - + return {child.value}; case 'ITALIC': - return ; - + return {child.value}; case 'BOLD': - return ; - + return {child.value}; default: return null; } diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/StrikeSpan.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/StrikeSpan.tsx index 94ce0f113938d..a4ce9473971f7 100644 --- a/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/StrikeSpan.tsx +++ b/ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/StrikeSpan.tsx @@ -49,10 +49,10 @@ const renderBlockComponent = (child: MessageBlock, index: number) => { return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'BOLD': - return ; + return {child.value}; case 'EMOJI': return ; diff --git a/packages/eslint-config/react.js b/packages/eslint-config/react.js index b11bcea6a1edb..a5b7d88652309 100644 --- a/packages/eslint-config/react.js +++ b/packages/eslint-config/react.js @@ -12,6 +12,7 @@ const config = { 'react/jsx-no-undef': 'error', 'react/jsx-uses-react': 'error', 'react/jsx-uses-vars': 'error', + 'react/no-children-prop': 'error', 'react/no-multi-comp': 'error', 'jsx-a11y/no-autofocus': [2, { ignoreNonDOM: true }], }, diff --git a/packages/fuselage-ui-kit/.storybook/preview.tsx b/packages/fuselage-ui-kit/.storybook/preview.tsx index d3080e682f608..77bd05598cf73 100644 --- a/packages/fuselage-ui-kit/.storybook/preview.tsx +++ b/packages/fuselage-ui-kit/.storybook/preview.tsx @@ -62,7 +62,7 @@ export const decorators: Decorator[] = [ ); }, - (fn) => , + (fn) => {fn()}, ]; export const tags = ['autodocs']; diff --git a/packages/gazzodown/src/Markup.tsx b/packages/gazzodown/src/Markup.tsx index 96da5408e50c4..0e0f62ff16f1e 100644 --- a/packages/gazzodown/src/Markup.tsx +++ b/packages/gazzodown/src/Markup.tsx @@ -26,10 +26,14 @@ const Markup = ({ tokens }: MarkupProps): ReactElement => ( return ; case 'PARAGRAPH': - return ; + return {block.value}; case 'HEADING': - return ; + return ( + + {block.value} + + ); case 'UNORDERED_LIST': return ; @@ -41,7 +45,7 @@ const Markup = ({ tokens }: MarkupProps): ReactElement => ( return ; case 'QUOTE': - return ; + return {block.value}; case 'CODE': return ; diff --git a/packages/gazzodown/src/PreviewMarkup.tsx b/packages/gazzodown/src/PreviewMarkup.tsx index d14af4af9255a..bb5a4d08ef943 100644 --- a/packages/gazzodown/src/PreviewMarkup.tsx +++ b/packages/gazzodown/src/PreviewMarkup.tsx @@ -28,7 +28,7 @@ const PreviewMarkup = ({ tokens }: PreviewMarkupProps): ReactElement | null => { switch (firstBlock.type) { case 'PARAGRAPH': - return ; + return {firstBlock.value}; case 'HEADING': return <>{firstBlock.value.map((plain) => plain.value).join('')}; @@ -39,7 +39,7 @@ const PreviewMarkup = ({ tokens }: PreviewMarkupProps): ReactElement | null => { return ( <> - {firstItem.number ? `${firstItem.number}.` : '-'} + {firstItem.number ? `${firstItem.number}.` : '-'} {firstItem.value} ); } @@ -49,7 +49,7 @@ const PreviewMarkup = ({ tokens }: PreviewMarkupProps): ReactElement | null => { return ( <> - {firstTask.status ? '\u2611' : '\u2610'} + {firstTask.status ? '\u2611' : '\u2610'} {firstTask.value} ); } @@ -59,7 +59,7 @@ const PreviewMarkup = ({ tokens }: PreviewMarkupProps): ReactElement | null => { return ( <> - > + > {firstParagraph.value} ); } diff --git a/packages/gazzodown/src/blocks/OrderedListBlock.tsx b/packages/gazzodown/src/blocks/OrderedListBlock.tsx index 276ab6c2b2752..6c6fc2734e34b 100644 --- a/packages/gazzodown/src/blocks/OrderedListBlock.tsx +++ b/packages/gazzodown/src/blocks/OrderedListBlock.tsx @@ -11,7 +11,7 @@ const OrderedListBlock = ({ items }: OrderedListBlockProps): ReactElement => (
    {items.map(({ value, number }, index) => (
  1. - + {value}
  2. ))}
diff --git a/packages/gazzodown/src/blocks/ParagraphBlock.tsx b/packages/gazzodown/src/blocks/ParagraphBlock.tsx index 146786a6493c5..c8e578d2e2653 100644 --- a/packages/gazzodown/src/blocks/ParagraphBlock.tsx +++ b/packages/gazzodown/src/blocks/ParagraphBlock.tsx @@ -9,7 +9,7 @@ type ParagraphBlockProps = { const ParagraphBlock = ({ children }: ParagraphBlockProps): ReactElement => (
- + {children}
); diff --git a/packages/gazzodown/src/blocks/QuoteBlock.tsx b/packages/gazzodown/src/blocks/QuoteBlock.tsx index 3e4cb15dee73a..4e56bbfe21535 100644 --- a/packages/gazzodown/src/blocks/QuoteBlock.tsx +++ b/packages/gazzodown/src/blocks/QuoteBlock.tsx @@ -10,7 +10,7 @@ type QuoteBlockProps = { const QuoteBlock = ({ children }: QuoteBlockProps): ReactElement => (
{children.map((paragraph, index) => ( - + {paragraph.value} ))}
); diff --git a/packages/gazzodown/src/blocks/TaskListBlock.tsx b/packages/gazzodown/src/blocks/TaskListBlock.tsx index de24fbbf5d079..8e1e67596d0d5 100644 --- a/packages/gazzodown/src/blocks/TaskListBlock.tsx +++ b/packages/gazzodown/src/blocks/TaskListBlock.tsx @@ -17,7 +17,7 @@ const TaksListBlock = ({ tasks }: TaskListBlockProps): ReactElement => {
    {tasks.map((item, index) => (
  • - + {item.value}
  • ))}
diff --git a/packages/gazzodown/src/blocks/UnorderedListBlock.tsx b/packages/gazzodown/src/blocks/UnorderedListBlock.tsx index 93874fd14010b..500e525011107 100644 --- a/packages/gazzodown/src/blocks/UnorderedListBlock.tsx +++ b/packages/gazzodown/src/blocks/UnorderedListBlock.tsx @@ -11,7 +11,7 @@ const UnorderedListBlock = ({ items }: UnorderedListBlockProps): ReactElement =>
    {items.map((item, index) => (
  • - + {item.value}
  • ))}
diff --git a/packages/gazzodown/src/elements/BoldSpan.tsx b/packages/gazzodown/src/elements/BoldSpan.tsx index 81fcc91f66c6b..00aa8743d0e84 100644 --- a/packages/gazzodown/src/elements/BoldSpan.tsx +++ b/packages/gazzodown/src/elements/BoldSpan.tsx @@ -57,10 +57,10 @@ const renderBlockComponent = (block: MessageBlock, index: number): ReactElement return ; case 'STRIKE': - return ; + return {block.value}; case 'ITALIC': - return ; + return {block.value}; case 'INLINE_CODE': return ; diff --git a/packages/gazzodown/src/elements/InlineElements.tsx b/packages/gazzodown/src/elements/InlineElements.tsx index 5ef947460d16b..4da143180cfb3 100644 --- a/packages/gazzodown/src/elements/InlineElements.tsx +++ b/packages/gazzodown/src/elements/InlineElements.tsx @@ -27,13 +27,13 @@ const InlineElements = ({ children }: InlineElementsProps): ReactElement => ( {children.map((child, index) => { switch (child.type) { case 'BOLD': - return ; + return {child.value}; case 'STRIKE': - return ; + return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'LINK': return ( @@ -73,12 +73,12 @@ const InlineElements = ({ children }: InlineElementsProps): ReactElement => ( ); case 'TIMESTAMP': { - return ; + return {child}; } default: { if ('fallback' in child) { - return ; + return {[child.fallback]}; } return null; } diff --git a/packages/gazzodown/src/elements/ItalicSpan.tsx b/packages/gazzodown/src/elements/ItalicSpan.tsx index 946a28bdac3f8..0e683120f7d9d 100644 --- a/packages/gazzodown/src/elements/ItalicSpan.tsx +++ b/packages/gazzodown/src/elements/ItalicSpan.tsx @@ -57,10 +57,10 @@ const renderBlockComponent = (block: MessageBlock, index: number): ReactElement return ; case 'STRIKE': - return ; + return {block.value}; case 'BOLD': - return ; + return {block.value}; case 'INLINE_CODE': return ; diff --git a/packages/gazzodown/src/elements/LinkSpan.tsx b/packages/gazzodown/src/elements/LinkSpan.tsx index 78120c376fb25..ba234e65d3c42 100644 --- a/packages/gazzodown/src/elements/LinkSpan.tsx +++ b/packages/gazzodown/src/elements/LinkSpan.tsx @@ -29,13 +29,13 @@ const LinkSpan = ({ href, label }: LinkSpanProps): ReactElement => { return ; case 'STRIKE': - return ; + return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'BOLD': - return ; + return {child.value}; default: return null; diff --git a/packages/gazzodown/src/elements/PreviewInlineElements.tsx b/packages/gazzodown/src/elements/PreviewInlineElements.tsx index 3b17c7a279349..37f1e0d189f43 100644 --- a/packages/gazzodown/src/elements/PreviewInlineElements.tsx +++ b/packages/gazzodown/src/elements/PreviewInlineElements.tsx @@ -22,24 +22,26 @@ const PreviewInlineElements = ({ children }: PreviewInlineElementsProps): ReactE {children.map((child, index) => { switch (child.type) { case 'BOLD': - return ; + return {child.value}; case 'STRIKE': - return ; + return {child.value}; case 'ITALIC': - return ; + return {child.value}; case 'LINK': return ( - + + {Array.isArray(child.value.label) ? child.value.label : [child.value.label]} + ); case 'PLAIN_TEXT': - return ; + return {child.value}; case 'IMAGE': - return ; + return {[child.value.label]}; case 'MENTION_USER': return ; diff --git a/packages/gazzodown/src/elements/StrikeSpan.tsx b/packages/gazzodown/src/elements/StrikeSpan.tsx index 138a9c359ddea..ac2875559c879 100644 --- a/packages/gazzodown/src/elements/StrikeSpan.tsx +++ b/packages/gazzodown/src/elements/StrikeSpan.tsx @@ -58,10 +58,10 @@ const renderBlockComponent = (block: MessageBlock, index: number): ReactElement return ; case 'ITALIC': - return ; + return {block.value}; case 'BOLD': - return ; + return {block.value}; case 'INLINE_CODE': return ; diff --git a/packages/gazzodown/src/katex/KatexErrorBoundary.tsx b/packages/gazzodown/src/katex/KatexErrorBoundary.tsx index 14139fd7b8d69..a1bdeffdb9a35 100644 --- a/packages/gazzodown/src/katex/KatexErrorBoundary.tsx +++ b/packages/gazzodown/src/katex/KatexErrorBoundary.tsx @@ -13,7 +13,11 @@ const Fallback = styled('span')` const KatexErrorBoundary = ({ children, code }: KatexErrorBoundaryProps): ReactElement => { const [error, setError] = useState(null); - return {code}} />; + return ( + {code}}> + {children} + + ); }; export default KatexErrorBoundary; diff --git a/packages/livechat/.eslintrc.json b/packages/livechat/.eslintrc.json index d547f05ea619c..575d6b1bc5040 100644 --- a/packages/livechat/.eslintrc.json +++ b/packages/livechat/.eslintrc.json @@ -43,6 +43,7 @@ ], "react/jsx-uses-react": "error", "react/jsx-uses-vars": "error", + "react/no-children-prop": "error", "react/no-danger": "warn", "react/no-deprecated": "error", "react/no-did-mount-set-state": "error", diff --git a/packages/livechat/src/components/Messages/MessageBlocks/stories.tsx b/packages/livechat/src/components/Messages/MessageBlocks/stories.tsx index 9631d5303ae24..693f91aa1a925 100644 --- a/packages/livechat/src/components/Messages/MessageBlocks/stories.tsx +++ b/packages/livechat/src/components/Messages/MessageBlocks/stories.tsx @@ -10,7 +10,7 @@ export default { parameters: { layout: 'fullscreen', }, - decorators: [(storyFn) => ], + decorators: [(storyFn) => {storyFn()}], } satisfies Meta>; export const WithBlocks: StoryFn> = () => ( diff --git a/packages/livechat/src/components/uiKit/message/ActionsBlock.stories.tsx b/packages/livechat/src/components/uiKit/message/ActionsBlock.stories.tsx index ca104eea52bd5..37d4ebfdab10c 100644 --- a/packages/livechat/src/components/uiKit/message/ActionsBlock.stories.tsx +++ b/packages/livechat/src/components/uiKit/message/ActionsBlock.stories.tsx @@ -10,15 +10,16 @@ export default { layout: 'centered', }, decorators: [ - (storyFn) =>
, + (storyFn) =>
{storyFn()}
, (storyFn) => ( { await new Promise((resolve) => setTimeout(resolve, 1000)); action('dispatchAction')(payload); }} - /> + > + {storyFn()} + ), ], } satisfies Meta; diff --git a/packages/livechat/src/components/uiKit/message/Block.tsx b/packages/livechat/src/components/uiKit/message/Block.tsx index a6b8e371de8b3..485a3992c2851 100644 --- a/packages/livechat/src/components/uiKit/message/Block.tsx +++ b/packages/livechat/src/components/uiKit/message/Block.tsx @@ -16,12 +16,13 @@ type BlockProps = { const Block = ({ appId, blockId, children }: BlockProps) => ( + > + {children} + ); export const usePerformAction = (actionId: string) => { diff --git a/packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx b/packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx index cab76bddad55c..d2c60cd591865 100644 --- a/packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx +++ b/packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx @@ -42,7 +42,6 @@ const ButtonElement = ({ text, actionId, url, value, style, context, confirm, pa return ( ); }; diff --git a/packages/livechat/src/components/uiKit/message/ButtonElement/stories.tsx b/packages/livechat/src/components/uiKit/message/ButtonElement/stories.tsx index 32675b61e505d..e06d5ea36c75b 100644 --- a/packages/livechat/src/components/uiKit/message/ButtonElement/stories.tsx +++ b/packages/livechat/src/components/uiKit/message/ButtonElement/stories.tsx @@ -29,12 +29,13 @@ export default { decorators: [ (storyFn) => ( { await new Promise((resolve) => setTimeout(resolve, 1000)); action('dispatchAction')(payload); }} - /> + > + {storyFn()} + ), ], parameters: { diff --git a/packages/livechat/src/components/uiKit/message/ContextBlock.stories.tsx b/packages/livechat/src/components/uiKit/message/ContextBlock.stories.tsx index 4438897c1caf7..04ad34ed012fe 100644 --- a/packages/livechat/src/components/uiKit/message/ContextBlock.stories.tsx +++ b/packages/livechat/src/components/uiKit/message/ContextBlock.stories.tsx @@ -8,7 +8,7 @@ export default { parameters: { layout: 'centered', }, - decorators: [(storyFn) =>
], + decorators: [(storyFn) =>
{storyFn()}
], } satisfies Meta; export const PlainText = () => diff --git a/packages/livechat/src/components/uiKit/message/DividerBlock.stories.tsx b/packages/livechat/src/components/uiKit/message/DividerBlock.stories.tsx index 17e952248c13b..03cdf0485f238 100644 --- a/packages/livechat/src/components/uiKit/message/DividerBlock.stories.tsx +++ b/packages/livechat/src/components/uiKit/message/DividerBlock.stories.tsx @@ -7,7 +7,7 @@ export default { parameters: { layout: 'centered', }, - decorators: [(storyFn) =>
], + decorators: [(storyFn) =>
{storyFn()}
], } satisfies Meta; export const Default = () => diff --git a/packages/livechat/src/components/uiKit/message/ImageBlock.stories.tsx b/packages/livechat/src/components/uiKit/message/ImageBlock.stories.tsx index ed24559f7878a..46a304d5f08bd 100644 --- a/packages/livechat/src/components/uiKit/message/ImageBlock.stories.tsx +++ b/packages/livechat/src/components/uiKit/message/ImageBlock.stories.tsx @@ -8,7 +8,7 @@ export default { parameters: { layout: 'centered', }, - decorators: [(storyFn) =>
], + decorators: [(storyFn) =>
{storyFn()}
], } satisfies Meta; export const WithTitle = () => diff --git a/packages/livechat/src/components/uiKit/message/ImageBlock/index.tsx b/packages/livechat/src/components/uiKit/message/ImageBlock/index.tsx index b9801b13ebe47..2ce10824be32d 100644 --- a/packages/livechat/src/components/uiKit/message/ImageBlock/index.tsx +++ b/packages/livechat/src/components/uiKit/message/ImageBlock/index.tsx @@ -70,14 +70,15 @@ const ImageBlock = ({ appId, blockId, title, imageUrl, altText, parser }: ImageB
diff --git a/packages/livechat/src/components/uiKit/message/SectionBlock.stories.tsx b/packages/livechat/src/components/uiKit/message/SectionBlock.stories.tsx index 23c656a425d7b..a108c31da7652 100644 --- a/packages/livechat/src/components/uiKit/message/SectionBlock.stories.tsx +++ b/packages/livechat/src/components/uiKit/message/SectionBlock.stories.tsx @@ -12,16 +12,17 @@ export default { layout: 'centered', }, decorators: [ - (storyFn) =>
, - (storyFn) => , + (storyFn) =>
{storyFn()}
, + (storyFn) => {storyFn()}, (storyFn) => ( { await new Promise((resolve) => setTimeout(resolve, 1000)); action('dispatchAction')(payload); }} - /> + > + {storyFn()} + ), ], } satisfies Meta; diff --git a/packages/livechat/src/components/uiKit/message/Surface.tsx b/packages/livechat/src/components/uiKit/message/Surface.tsx index 2ca22907c502b..255d382517042 100644 --- a/packages/livechat/src/components/uiKit/message/Surface.tsx +++ b/packages/livechat/src/components/uiKit/message/Surface.tsx @@ -17,11 +17,12 @@ type SurfaceProps = { const Surface = ({ children, dispatchAction }: SurfaceProps) => ( + > + {children} + ); export const useDispatchAction = () => useContext(SurfaceContext).dispatchAction; diff --git a/packages/livechat/src/providers/ServerProvider.tsx b/packages/livechat/src/providers/ServerProvider.tsx index 606cb75ddd66c..6f3eedd97369f 100644 --- a/packages/livechat/src/providers/ServerProvider.tsx +++ b/packages/livechat/src/providers/ServerProvider.tsx @@ -155,7 +155,7 @@ const ServerProvider = ({ children }: { children: ComponentChildren }) => { return contextValue; }, [sdk, status, token]); - return ; + return {children}; }; export default ServerProvider; diff --git a/packages/ui-client/src/components/AnchorPortal.spec.tsx b/packages/ui-client/src/components/AnchorPortal.spec.tsx index dd9a5a3dae9ea..20423f777e157 100644 --- a/packages/ui-client/src/components/AnchorPortal.spec.tsx +++ b/packages/ui-client/src/components/AnchorPortal.spec.tsx @@ -3,16 +3,28 @@ import { render, screen } from '@testing-library/react'; import AnchorPortal from './AnchorPortal'; it('should render children', () => { - render(} />); + render( + +
+ , + ); expect(screen.getByRole('presentation', { name: 'example' })).toBeInTheDocument(); }); it('should not recreate the anchor element', () => { - render(} />); + render( + +
+ , + ); const anchorA = document.getElementById('test-anchor'); - render(} />); + render( + +
+ , + ); const anchorB = document.getElementById('test-anchor'); expect(anchorA).toBe(anchorB); @@ -21,7 +33,11 @@ it('should not recreate the anchor element', () => { }); it('should remove the anchor element when unmounted', () => { - const { unmount } = render(} />); + const { unmount } = render( + +
+ , + ); expect(document.getElementById('test-anchor')).toBeInTheDocument(); unmount(); @@ -29,10 +45,18 @@ it('should remove the anchor element when unmounted', () => { }); it('should not remove the anchor element after unmounting if there are other portals with the same id', () => { - const { unmount } = render(} />); + const { unmount } = render( + +
+ , + ); expect(document.getElementById('test-anchor')).toBeInTheDocument(); - render(} />); + render( + +
+ , + ); unmount(); expect(document.getElementById('test-anchor')).toBeInTheDocument(); diff --git a/packages/ui-client/src/components/Modal/ModalBackdrop.tsx b/packages/ui-client/src/components/Modal/ModalBackdrop.tsx index 4a11349d10796..9ae1b9cacdc92 100644 --- a/packages/ui-client/src/components/Modal/ModalBackdrop.tsx +++ b/packages/ui-client/src/components/Modal/ModalBackdrop.tsx @@ -81,7 +81,6 @@ const ModalBackdrop = ({ children, onDismiss }: ModalBackdropProps) => { return ( { flexDirection='column' onMouseDown={onMouseDown} onMouseUp={onMouseUp} - /> + > + {children} + ); }; diff --git a/packages/ui-client/src/components/Page/Page.stories.tsx b/packages/ui-client/src/components/Page/Page.stories.tsx index f51996eecbc3e..e77b0db9d6ba2 100644 --- a/packages/ui-client/src/components/Page/Page.stories.tsx +++ b/packages/ui-client/src/components/Page/Page.stories.tsx @@ -24,7 +24,9 @@ export default { const DummyContent = ({ rows = 10 }: { rows?: number }) => ( <> {Array.from({ length: rows }, (_, i) => ( - + + Content slice + ))} ); diff --git a/packages/ui-client/src/providers/ModalProvider/ModalProvider.tsx b/packages/ui-client/src/providers/ModalProvider/ModalProvider.tsx index ac97ce8d89fef..4fed55cec20fd 100644 --- a/packages/ui-client/src/providers/ModalProvider/ModalProvider.tsx +++ b/packages/ui-client/src/providers/ModalProvider/ModalProvider.tsx @@ -35,7 +35,7 @@ const ModalProvider = ({ children, region }: ModalProviderProps) => { [currentModal?.node, currentModal?.region, region, setModal], ); - return ; + return {children}; }; export default memo(ModalProvider); diff --git a/packages/web-ui-registration/src/LoginServices.tsx b/packages/web-ui-registration/src/LoginServices.tsx index a5068fbaac3fc..e36c032e0436f 100644 --- a/packages/web-ui-registration/src/LoginServices.tsx +++ b/packages/web-ui-registration/src/LoginServices.tsx @@ -23,7 +23,11 @@ const LoginServices = ({ return ( <> - {showFormLogin && } + {showFormLogin && ( + + {t('registration.component.form.divider')} + + )} {services.map((service) => ( diff --git a/yarn.lock b/yarn.lock index 1651c307f759f..f751484c0b8c7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10523,6 +10523,7 @@ __metadata: "@vitejs/plugin-react": "npm:~4.5.2" codemirror: "npm:^6.0.2" eslint: "npm:~8.45.0" + eslint-plugin-react: "npm:~7.37.5" eslint-plugin-react-hooks: "npm:^5.0.0" eslint-plugin-react-refresh: "npm:^0.4.24" eslint4b-prebuilt: "npm:^6.7.2"