fix _replace_query_for_model now requires **kwargs & specifically "is_snapshot_deployable" for grants application.

Author: newtonapple

examples/custom_materializations/custom_materializations/custom_kind.py

@@ -29,4 +29,4 @@ def insert(
     ) -> None:
         assert type(model.kind).__name__ == "ExtendedCustomKind"
 
-        self._replace_query_for_model(model, table_name, query_or_df, render_kwargs)
+        self._replace_query_for_model(model, table_name, query_or_df, render_kwargs, **kwargs)

examples/custom_materializations/custom_materializations/full.py

@@ -20,4 +20,4 @@ def insert(
         render_kwargs: t.Dict[str, t.Any],
         **kwargs: t.Any,
     ) -> None:
-        self._replace_query_for_model(model, table_name, query_or_df, render_kwargs)
+        self._replace_query_for_model(model, table_name, query_or_df, render_kwargs, **kwargs)

tests/core/test_integration.py

@@ -2351,7 +2351,7 @@ def insert(
             nonlocal custom_insert_called
             custom_insert_called = True
 
-            self._replace_query_for_model(model, table_name, query_or_df, render_kwargs)
+            self._replace_query_for_model(model, table_name, query_or_df, render_kwargs, **kwargs)
 
     model = context.get_model("sushi.top_waiters")
     kwargs = {
@@ -2399,7 +2399,7 @@ def insert(
             nonlocal custom_insert_calls
             custom_insert_calls.append(model.kind.custom_property)
 
-            self._replace_query_for_model(model, table_name, query_or_df, render_kwargs)
+            self._replace_query_for_model(model, table_name, query_or_df, render_kwargs, **kwargs)
 
     model = context.get_model("sushi.top_waiters")
     kwargs = {
@@ -10287,14 +10287,14 @@ def test_restatement_plan_interval_external_visibility(tmp_path: Path):
     )  # python model creates this file if it's in the wait loop and deletes it once done
 
     # Note: to make execution block so we can test stuff, we use a Python model that blocks until it no longer detects the presence of a file
-    (models_dir / "model_a.py").write_text(f"""                                           
+    (models_dir / "model_a.py").write_text(f"""
 from sqlmesh.core.model import model
 from sqlmesh.core.macros import MacroEvaluator
 
 @model(
     "test.model_a",
     is_sql=True,
-    kind="FULL"    
+    kind="FULL"
 )
 def entrypoint(evaluator: MacroEvaluator) -> str:
     from pathlib import Path
@@ -10318,7 +10318,7 @@ def entrypoint(evaluator: MacroEvaluator) -> str:
         name test.model_b,
         kind FULL
     );
-                  
+
     select a.m as m, 'model_b' as mb from test.model_a as a
     """)
 
@@ -10348,7 +10348,7 @@ def entrypoint(evaluator: MacroEvaluator) -> str:
         name test.model_b,
         kind FULL
     );
-                  
+
     select a.m as m, 'model_b' as mb, 'dev' as dev_version from test.model_a as a
     """)
 
@@ -10358,7 +10358,7 @@ def entrypoint(evaluator: MacroEvaluator) -> str:
         name test.model_c,
         kind FULL
     );
-                  
+
     select b.*, 'model_c' as mc from test.model_b as b
     """)
 
@@ -10436,7 +10436,7 @@ def _run_restatement_plan(tmp_path: Path, config: Config, q: queue.Queue):
         name test.model_b,
         kind FULL
     );
-                  
+
     select a.m as m, 'model_b' as mb, 'dev2' as dev_version from test.model_a as a
     """)
     ctx.load()
@@ -10529,14 +10529,14 @@ def test_restatement_plan_detects_prod_deployment_during_restatement(tmp_path: P
     )  # python model creates this file if it's in the wait loop and deletes it once done
 
     # Note: to make execution block so we can test stuff, we use a Python model that blocks until it no longer detects the presence of a file
-    (models_dir / "model_a.py").write_text(f"""                                           
+    (models_dir / "model_a.py").write_text(f"""
 from sqlmesh.core.model import model
 from sqlmesh.core.macros import MacroEvaluator
 
 @model(
     "test.model_a",
     is_sql=True,
-    kind="FULL"    
+    kind="FULL"
 )
 def entrypoint(evaluator: MacroEvaluator) -> str:
     from pathlib import Path
@@ -10578,7 +10578,7 @@ def entrypoint(evaluator: MacroEvaluator) -> str:
         name test.model_a,
         kind FULL
     );
-                  
+
     select 1 as changed
     """)