Skip to content

Commit 2897b4e

Browse files
authored
fix: selector use provided models and fix mypy (#5148)
1 parent e4ea4c8 commit 2897b4e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

sqlmesh/core/selector.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,10 @@ def expand_model_selections(
178178

179179
node = parse(" | ".join(f"({s})" for s in model_selections))
180180

181-
models = models or self._models
181+
all_models = models or self._models
182182
models_by_tags: t.Dict[str, t.Set[str]] = {}
183183

184-
for fqn, model in models.items():
184+
for fqn, model in all_models.items():
185185
for tag in model.tags:
186186
tag = tag.lower()
187187
models_by_tags.setdefault(tag, set())
@@ -193,27 +193,27 @@ def evaluate(node: exp.Expression) -> t.Set[str]:
193193
if "*" in pattern:
194194
return {
195195
fqn
196-
for fqn, model in models.items()
196+
for fqn, model in all_models.items()
197197
if fnmatch.fnmatchcase(model.name, node.this)
198198
}
199199
fqn = normalize_model_name(pattern, self._default_catalog, self._dialect)
200-
return {fqn} if fqn in models else set()
200+
return {fqn} if fqn in all_models else set()
201201
if isinstance(node, exp.And):
202202
return evaluate(node.left) & evaluate(node.right)
203203
if isinstance(node, exp.Or):
204204
return evaluate(node.left) | evaluate(node.right)
205205
if isinstance(node, exp.Paren):
206206
return evaluate(node.this)
207207
if isinstance(node, exp.Not):
208-
return set(models) - evaluate(node.this)
208+
return set(all_models) - evaluate(node.this)
209209
if isinstance(node, Git):
210210
target_branch = node.name
211211
git_modified_files = {
212212
*self._git_client.list_untracked_files(),
213213
*self._git_client.list_uncommitted_changed_files(),
214214
*self._git_client.list_committed_changed_files(target_branch=target_branch),
215215
}
216-
return {m.fqn for m in self._models.values() if m._path in git_modified_files}
216+
return {m.fqn for m in all_models.values() if m._path in git_modified_files}
217217
if isinstance(node, Tag):
218218
pattern = node.name.lower()
219219

@@ -232,7 +232,7 @@ def evaluate(node: exp.Expression) -> t.Set[str]:
232232
selected.add(model_name)
233233
if node.args.get("up"):
234234
for u in self._dag.upstream(model_name):
235-
if u in models:
235+
if u in all_models:
236236
selected.add(u)
237237
if node.args.get("down"):
238238
selected.update(self._dag.downstream(model_name))

0 commit comments

Comments
 (0)