improve tests

Author: izeigerman

tests/core/engine_adapter/test_base.py

@@ -14,7 +14,7 @@
 from sqlmesh.core.dialect import normalize_model_name
 from sqlmesh.core.engine_adapter import EngineAdapter, EngineAdapterWithIndexSupport
 from sqlmesh.core.engine_adapter.mixins import InsertOverwriteWithMergeMixin
-from sqlmesh.core.engine_adapter.shared import InsertOverwriteStrategy
+from sqlmesh.core.engine_adapter.shared import InsertOverwriteStrategy, DataObject
 from sqlmesh.core.schema_diff import SchemaDiffer, TableAlterOperation
 from sqlmesh.utils import columns_to_types_to_struct
 from sqlmesh.utils.date import to_ds
@@ -43,6 +43,23 @@ def test_create_view(make_mocked_engine_adapter: t.Callable):
     ]
 
 
+def test_create_view_existing_data_object_type_mismatch(
+    make_mocked_engine_adapter: t.Callable, mocker: MockerFixture
+):
+    adapter = make_mocked_engine_adapter(EngineAdapter)
+    mocker.patch.object(
+        adapter,
+        "_get_data_objects",
+        return_value=[DataObject(schema="", name="test_view", type="table")],
+    )
+    adapter.create_view("test_view", parse_one("SELECT a FROM tbl"))
+
+    assert to_sql_calls(adapter) == [
+        'DROP TABLE IF EXISTS "test_view"',
+        'CREATE OR REPLACE VIEW "test_view" AS SELECT "a" FROM "tbl"',
+    ]
+
+
 def test_create_view_pandas(make_mocked_engine_adapter: t.Callable):
     adapter = make_mocked_engine_adapter(EngineAdapter)
     adapter.create_view("test_view", pd.DataFrame({"a": [1, 2, 3]}), replace=False)
@@ -2713,6 +2730,27 @@ def test_replace_query(make_mocked_engine_adapter: t.Callable, mocker: MockerFix
     ]
 
 
+def test_replace_query_data_object_type_mismatch(
+    make_mocked_engine_adapter: t.Callable, mocker: MockerFixture
+):
+    adapter = make_mocked_engine_adapter(EngineAdapter)
+    mocker.patch.object(
+        adapter,
+        "_get_data_objects",
+        return_value=[DataObject(schema="", name="test_table", type="view")],
+    )
+
+    adapter.replace_query(
+        "test_table", parse_one("SELECT a FROM tbl"), {"a": exp.DataType.build("INT")}
+    )
+
+    # TODO: Shouldn't we enforce that `a` is casted to an int?
+    assert to_sql_calls(adapter) == [
+        'DROP VIEW IF EXISTS "test_table"',
+        'CREATE OR REPLACE TABLE "test_table" AS SELECT CAST("a" AS INT) AS "a" FROM (SELECT "a" FROM "tbl") AS "_subquery"',
+    ]
+
+
 def test_replace_query_pandas(make_mocked_engine_adapter: t.Callable):
     adapter = make_mocked_engine_adapter(EngineAdapter)
     adapter.DEFAULT_BATCH_SIZE = 1

tests/core/test_integration.py

@@ -2488,6 +2488,16 @@ def test_virtual_environment_mode_dev_only(init_and_plan_context: t.Callable):
             intervals=[(to_timestamp("2023-01-07"), to_timestamp("2023-01-08"))],
         ),
     ]
+    assert plan_dev.context_diff.snapshots[context.get_snapshot(model.name).snapshot_id].intervals
+    assert plan_dev.context_diff.snapshots[
+        context.get_snapshot("sushi.top_waiters").snapshot_id
+    ].intervals
+    assert plan_dev.context_diff.snapshots[
+        context.get_snapshot(model.name).snapshot_id
+    ].dev_intervals
+    assert plan_dev.context_diff.snapshots[
+        context.get_snapshot("sushi.top_waiters").snapshot_id
+    ].dev_intervals
     context.apply(plan_dev)
 
     # Make sure the waiter_revenue_by_day model is a table in prod and a view in dev
@@ -2539,6 +2549,9 @@ def test_virtual_environment_mode_dev_only_model_kind_change(init_and_plan_conte
     prod_plan = context.plan_builder("prod", skip_tests=True).build()
     assert prod_plan.missing_intervals
     assert prod_plan.requires_backfill
+    assert not prod_plan.context_diff.snapshots[
+        context.get_snapshot(model.name).snapshot_id
+    ].intervals
     context.apply(prod_plan)
     data_objects = context.engine_adapter.get_data_objects("sushi", {"top_waiters"})
     assert len(data_objects) == 1
@@ -2553,6 +2566,9 @@ def test_virtual_environment_mode_dev_only_model_kind_change(init_and_plan_conte
     prod_plan = context.plan_builder("prod", skip_tests=True).build()
     assert prod_plan.requires_backfill
     assert prod_plan.missing_intervals
+    assert not prod_plan.context_diff.snapshots[
+        context.get_snapshot(model.name).snapshot_id
+    ].intervals
     context.apply(prod_plan)
     data_objects = context.engine_adapter.get_data_objects("sushi", {"top_waiters"})
     assert len(data_objects) == 1
@@ -2565,6 +2581,24 @@ def test_virtual_environment_mode_dev_only_model_kind_change(init_and_plan_conte
     prod_plan = context.plan_builder("prod", skip_tests=True).build()
     assert prod_plan.requires_backfill
     assert prod_plan.missing_intervals
+    assert not prod_plan.context_diff.snapshots[
+        context.get_snapshot(model.name).snapshot_id
+    ].intervals
+    context.apply(prod_plan)
+    data_objects = context.engine_adapter.get_data_objects("sushi", {"top_waiters"})
+    assert len(data_objects) == 1
+    assert data_objects[0].type == "table"
+
+    # Change back to full
+    model = context.get_model("sushi.top_waiters")
+    model = model.copy(update={"kind": FullKind()})
+    context.upsert_model(model)
+    prod_plan = context.plan_builder("prod", skip_tests=True).build()
+    assert prod_plan.requires_backfill
+    assert prod_plan.missing_intervals
+    assert not prod_plan.context_diff.snapshots[
+        context.get_snapshot(model.name).snapshot_id
+    ].intervals
     context.apply(prod_plan)
     data_objects = context.engine_adapter.get_data_objects("sushi", {"top_waiters"})
     assert len(data_objects) == 1