Add tests

Author: treysp

sqlmesh/core/snapshot/evaluator.py

@@ -1015,29 +1015,27 @@ def _demote_snapshot(
         environment_naming_info: EnvironmentNamingInfo,
         on_complete: t.Optional[t.Callable[[SnapshotInfoLike], None]],
     ) -> None:
-        adapter = (
-            self.get_adapter(snapshot.model_gateway)
-            if environment_naming_info.gateway_managed
-            else self.adapter
-        )
-        view_name = snapshot.qualified_view_name.for_environment(
-            environment_naming_info, dialect=adapter.dialect
-        )
-        session_properties = (
-            snapshot.model.render_session_properties(
-                engine_adapter=adapter, runtime_stage=RuntimeStage.PROMOTING
+        if snapshot.is_model:
+            adapter = (
+                self.get_adapter(snapshot.model_gateway)
+                if environment_naming_info.gateway_managed
+                else self.adapter
             )
-            if snapshot.is_model
-            else {}
-        )
-        with (
-            adapter.transaction(),
-            adapter.session(session_properties),
-        ):
-            _evaluation_strategy(snapshot, adapter).demote(view_name)
+            view_name = snapshot.qualified_view_name.for_environment(
+                environment_naming_info, dialect=adapter.dialect
+            )
+            with (
+                adapter.transaction(),
+                adapter.session(
+                    snapshot.model.render_session_properties(
+                        engine_adapter=adapter, runtime_stage=RuntimeStage.PROMOTING
+                    )
+                ),
+            ):
+                _evaluation_strategy(snapshot, adapter).demote(view_name)
 
-        if on_complete is not None:
-            on_complete(snapshot)
+            if on_complete is not None:
+                on_complete(snapshot)
 
     def _cleanup_snapshot(
         self,

tests/core/test_snapshot_evaluator.py

@@ -294,6 +294,8 @@ def test_promote(mocker: MockerFixture, adapter_mock, make_snapshot):
 
     evaluator.promote([snapshot], EnvironmentNamingInfo(name="test_env"))
 
+    adapter_mock.transaction.assert_called()
+    adapter_mock.session.assert_called()
     adapter_mock.create_schema.assert_called_once_with(to_schema("test_schema__test_env"))
     adapter_mock.create_view.assert_called_once_with(
         "test_schema__test_env.test_model",
@@ -320,6 +322,8 @@ def test_demote(mocker: MockerFixture, adapter_mock, make_snapshot):
 
     evaluator.demote([snapshot], EnvironmentNamingInfo(name="test_env"))
 
+    adapter_mock.transaction.assert_called()
+    adapter_mock.session.assert_called()
     adapter_mock.drop_view.assert_called_once_with(
         "test_schema__test_env.test_model",
         cascade=False,