pr feedback

Author: sungchun12

docs/guides/linter.md

@@ -75,7 +75,7 @@ Here are all of SQLMesh's built-in linting rules:
 | `noselectstar`               | Stylistic   | The query's top-level selection may not be `SELECT *`, even if SQLMesh can expand the `SELECT *` into individual columns |
 | `nomissingaudits`             | Governance  | SQLMesh did not find any `audits` in the model's configuration to test data quality.                                                 |
 | `nomissingexternalmodels`   | Governance  | All external models must be registered in the external_models.yaml file                                                |
-| `cronvalidator`             | Governance  | Upstream model has a cron expression with longer intervals than downstream model. Example:  step_1(`@weekly`) -> step_2(`@daily`) -> step_3(`*/5 * * * *`). step_2 and step_3 are anchored to step_1's cron and will run on the same schedule as step_1. The fix is to align the schedules where a downstream model's cron is the same or has a longer cron interval than an upstream model's.                                         |
+| `cronintervalalignment`             | Governance  | Upstream model has a cron expression with longer intervals than downstream model. Example:  step_1(`@weekly`) -> step_2(`@daily`) -> step_3(`*/5 * * * *`). step_2 and step_3 are anchored to step_1's cron and will run on the same schedule as step_1. The fix is to align the schedules where a downstream model's cron is the same or has a longer cron interval than an upstream model's.                                         |
 
 ### User-defined rules
 

examples/sushi/config.py

@@ -49,7 +49,7 @@
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),
 )

sqlmesh/core/linter/rules/builtin.py

@@ -24,7 +24,7 @@
     CreateFile,
 )
 from sqlmesh.core.linter.definition import RuleSet
-from sqlmesh.core.model import Model, SqlModel, ExternalModel
+from sqlmesh.core.model import Model, SqlModel, ExternalModel, ModelKindName
 from sqlmesh.utils.lineage import extract_references_from_query, ExternalModelReference
 
 
@@ -274,7 +274,7 @@ def create_fix(self, model_name: str) -> t.Optional[Fix]:
         )
 
 
-class CronValidator(Rule):
+class CronIntervalAlignment(Rule):
     """Upstream model has a cron expression with longer intervals than downstream model."""
 
     def check_model(self, model: Model) -> t.Optional[RuleViolation]:
@@ -290,7 +290,7 @@ def check_model(self, model: Model) -> t.Optional[RuleViolation]:
                 continue
 
             # Skip model kinds since they don't run on cron schedules
-            skip_kinds = ["EXTERNAL", "EMBEDDED", "SEED"]
+            skip_kinds = [ModelKindName.EXTERNAL, ModelKindName.EMBEDDED, ModelKindName.SEED]
             if upstream_model.kind.name in skip_kinds:
                 continue
 

tests/core/linter/test_builtin.py

@@ -33,7 +33,7 @@ def test_no_missing_external_models(tmp_path, copy_to_temp_path) -> None:
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
     after = """linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),"""
@@ -87,7 +87,7 @@ def test_no_missing_external_models_with_existing_file_ending_in_newline(
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
     after = """linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),"""
@@ -145,7 +145,7 @@ def test_no_missing_external_models_with_existing_file_not_ending_in_newline(
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
     after = """linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),"""
@@ -196,10 +196,10 @@ def test_cron_validator(tmp_path, copy_to_temp_path) -> None:
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
-    after = """linter=LinterConfig(enabled=True, rules=["cronvalidator"]),"""
+    after = """linter=LinterConfig(enabled=True, rules=["cronintervalalignment"]),"""
     read_file = read_file.replace(before, after)
     assert after in read_file
     with open(sushi_path / "config.py", "w") as f:

tests/lsp/test_code_actions.py

@@ -131,7 +131,7 @@ def test_code_actions_create_file(copy_to_temp_path: t.Callable) -> None:
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
     after = """linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),"""

tests/lsp/test_reference_external_model.py

@@ -94,7 +94,7 @@ def test_unregistered_external_model_with_schema(
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],
     ),"""
     after = """linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),"""

vscode/extension/tests/quickfix.spec.ts

@@ -35,7 +35,7 @@ test.fixme(
             "nomissingaudits",
             "nomissingowner",
             "nomissingexternalmodels",
-            "cronvalidator",
+            "cronintervalalignment",
         ],`,
       targetRules,
     )