feat!: allow the linter to return fixes that affect other files (#5057)

Author: benfdking

sqlmesh/core/linter/rule.py

@@ -2,6 +2,7 @@
 
 import abc
 from dataclasses import dataclass
+from pathlib import Path
 
 from sqlmesh.core.model import Model
 
@@ -43,6 +44,7 @@ class Range:
 class TextEdit:
     """A text edit to apply to a file."""
 
+    path: Path
     range: Range
     new_text: str
 

sqlmesh/core/linter/rules/builtin.py

@@ -53,12 +53,16 @@ def _create_fixes(
         columns = model.columns_to_types
         if not columns:
             return None
+        path = model._path
+        if path is None:
+            return None
         new_text = ", ".join(columns.keys())
         return [
             Fix(
                 title="Replace SELECT * with explicit column list",
                 edits=[
                     TextEdit(
+                        path=path,
                         range=violation_range,
                         new_text=new_text,
                     )

sqlmesh/lsp/context.py

@@ -274,9 +274,13 @@ def get_code_actions(
                 # Create code actions for each fix
                 for fix in found_violation.fixes:
                     # Convert our Fix to LSP TextEdits
-                    text_edits = []
+                    changes: t.Dict[str, t.List[types.TextEdit]] = {}
                     for edit in fix.edits:
-                        text_edits.append(
+                        uri_key = URI.from_path(edit.path).value
+                        if uri_key not in changes:
+                            changes[uri_key] = []
+                        # Create a TextEdit for the LSP
+                        changes[uri_key].append(
                             types.TextEdit(
                                 range=types.Range(
                                     start=types.Position(
@@ -297,7 +301,7 @@ def get_code_actions(
                         title=fix.title,
                         kind=types.CodeActionKind.QuickFix,
                         diagnostics=[diagnostic],
-                        edit=types.WorkspaceEdit(changes={params.text_document.uri: text_edits}),
+                        edit=types.WorkspaceEdit(changes=changes),
                     )
                     code_actions.append(code_action)