Skip to content

Commit 6ac197e

Browse files
fix(fabric): Skip test_value_normalization for TIMESTAMPTZ
1 parent 4412fc9 commit 6ac197e

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

tests/core/engine_adapter/integration/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def pytest_marks(self) -> t.List[MarkDecorator]:
8282
IntegrationTestEngine("bigquery", native_dataframe_type="bigframe", cloud=True),
8383
IntegrationTestEngine("databricks", native_dataframe_type="pyspark", cloud=True),
8484
IntegrationTestEngine("snowflake", native_dataframe_type="snowpark", cloud=True),
85-
IntegrationTestEngine("fabric", cloud=True)
85+
IntegrationTestEngine("fabric", cloud=True),
8686
]
8787

8888
ENGINES_BY_NAME = {e.engine: e for e in ENGINES}

tests/core/engine_adapter/integration/test_integration.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2158,14 +2158,12 @@ def test_value_normalization(
21582158
input_data: t.Tuple[t.Any, ...],
21592159
expected_results: t.Tuple[str, ...],
21602160
) -> None:
2161-
if (
2162-
ctx.dialect == "trino"
2163-
and ctx.engine_adapter.current_catalog_type == "hive"
2164-
and column_type == exp.DataType.Type.TIMESTAMPTZ
2165-
):
2166-
pytest.skip(
2167-
"Trino on Hive doesnt support creating tables with TIMESTAMP WITH TIME ZONE fields"
2168-
)
2161+
# Skip TIMESTAMPTZ tests for engines that don't support it
2162+
if column_type == exp.DataType.Type.TIMESTAMPTZ:
2163+
if ctx.dialect == "trino" and ctx.engine_adapter.current_catalog_type == "hive":
2164+
pytest.skip("Trino on Hive doesn't support TIMESTAMP WITH TIME ZONE fields")
2165+
if ctx.dialect == "fabric":
2166+
pytest.skip("Fabric doesn't support TIMESTAMP WITH TIME ZONE fields")
21692167

21702168
if not isinstance(ctx.engine_adapter, RowDiffMixin):
21712169
pytest.skip(

0 commit comments

Comments
 (0)