added better message

Author: benfdking

sqlmesh/core/linter/rules/builtin.py

@@ -14,7 +14,7 @@
 
 
 class NoSelectStar(Rule):
-    """Query should not contain SELECT * on its outermost projections, even if it can be expanded."""
+    """Query should not contain SELECT * on its outer most projections, even if it can be expanded."""
 
     def check_model(self, model: Model) -> t.Optional[RuleViolation]:
         # Only applies to SQL models, as other model types do not have a query.
@@ -133,7 +133,7 @@ def check_model(self, model: Model) -> t.Optional[RuleViolation]:
             rule=self,
             violation_msg=f"Model '{model.name}' depends on unregistered external models: "
             f"{', '.join(m for m in not_registered_external_models)}. "
-            "Please register them in the external_models.yaml file.",
+            "Please register them in the external models file. This can be done by running 'sqlmesh create_external_models'.",
         )
 
 

vscode/extension/tests/quickfix.spec.ts

@@ -17,20 +17,29 @@ test('noselectstar quickfix', async ({ page, sharedCodeServer }) => {
   const configPath = path.join(tempDir, 'config.py')
   const read = await fs.readFile(configPath, 'utf8')
   // Replace linter to be on
+  const target = 'enabled=True'
   const replaced = read.replace('enabled=False', 'enabled=True')
+  // Assert replaced correctly
+  expect(replaced).toContain(target)
+
+  // Replace the rules to only have noselectstar
+  const targetRules = `rules=[
+            "noselectstar",
+        ],
+`
   const replacedTheOtherRules = replaced.replace(
     `rules=[
             "ambiguousorinvalidcolumn",
             "invalidselectstarexpansion",
             "noselectstar",
             "nomissingaudits",
             "nomissingowner",
+            "nomissingexternalmodels",
         ],`,
-    `rules=[
-            "noselectstar",
-        ],
-`,
+    target,
   )
+  expect(replacedTheOtherRules).toContain(targetRules)
+
   await fs.writeFile(configPath, replacedTheOtherRules)
   // Replace the file to cause the error
   const modelPath = path.join(tempDir, 'models', 'latest_order.sql')