Fix: ensure MacroEvaluator.columns_to_types returns types as DataTypes (#2694)

Author: georgesittas

sqlmesh/core/macros.py

@@ -413,7 +413,9 @@ def columns_to_types(self, model_name: TableName | exp.Column) -> t.Dict[str, ex
             default_catalog=self.default_catalog,
             dialect=self.dialect,
         )
-        columns_to_types = self._schema.find(exp.to_table(normalized_model_name))
+        columns_to_types = self._schema.find(
+            exp.to_table(normalized_model_name), ensure_data_types=True
+        )
         if columns_to_types is None:
             raise SQLMeshError(f"Schema for model '{model_name}' can't be statically determined.")
 

tests/core/test_macros.py

@@ -96,9 +96,15 @@ def test_default_arg_coercion(
 
 def test_star(assert_exp_eq) -> None:
     sql = """SELECT @STAR(foo) FROM foo"""
-    expected_sql = """SELECT CAST([foo].[a] AS DATETIMEOFFSET) AS [a] FROM foo"""
+    expected_sql = """SELECT CAST([foo].[a] AS DATETIMEOFFSET) AS [a], CAST([foo].[b] AS INTEGER) AS [b] FROM foo"""
     schema = MappingSchema(
-        {"foo": {"a": exp.DataType.build("datetimeoffset", dialect="tsql")}}, dialect="tsql"
+        {
+            "foo": {
+                "a": exp.DataType.build("datetimeoffset", dialect="tsql"),
+                "b": "int",
+            },
+        },
+        dialect="tsql",
     )
     evaluator = MacroEvaluator(schema=schema, dialect="tsql")
     assert_exp_eq(evaluator.transform(parse_one(sql, read="tsql")), expected_sql, dialect="tsql")