fix(vscode): force lsp to be single worker)

Author: benfdking

sqlmesh/lsp/main.py

@@ -105,7 +105,7 @@ def __init__(
         :param server_name: Name for the language server.
         :param version: Version string.
         """
-        self.server = LanguageServer(server_name, version)
+        self.server = LanguageServer(server_name, version, max_workers=1)
         self.context_class = context_class
         self.context_state: ContextState = NoContext()
         self.workspace_folders: t.List[Path] = []

vscode/extension/playwright.config.ts

@@ -1,11 +1,12 @@
 import { defineConfig } from '@playwright/test'
+import * as process from 'node:process'
 
 export default defineConfig({
   testDir: 'tests',
   timeout: 60_000,
   // TODO: When stable, allow retries in CI
   retries: process.env.CI ? 2 : 0,
-  workers: 4,
+  workers: process.env.CI ? 2 : 4,
   reporter: [['html', { outputFolder: 'playwright-report' }], ['list']],
   projects: [
     {

vscode/extension/tests/quickfix.spec.ts

@@ -3,6 +3,7 @@ import path from 'path'
 import os from 'os'
 import {
   openProblemsView,
+  saveFile,
   SUSHI_SOURCE_PATH,
   waitForLoadedSQLMesh,
 } from './utils'
@@ -80,11 +81,29 @@ test('noselectstar quickfix', async ({ page, sharedCodeServer }) => {
     .first()
     .click()
 
-  // Wait for the quick fix to be applied
-  await page.waitForTimeout(2_000)
+  await saveFile(page)
 
-  // Assert that the model no longer contains SELECT * but SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date
-  const readUpdatedFile = (await fs.readFile(modelPath)).toString('utf8')
+  // Wait for the quick fix to be applied and verify the change
+  const startTime = Date.now()
+  let readUpdatedFile = ''
+  let fileUpdated = false
+
+  while (Date.now() - startTime < 20_000 && !fileUpdated) {
+    readUpdatedFile = (await fs.readFile(modelPath)).toString('utf8')
+    if (
+      !readUpdatedFile.includes('SELECT *') &&
+      readUpdatedFile.includes(
+        'SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date',
+      )
+    ) {
+      fileUpdated = true
+      break
+    }
+    await page.waitForTimeout(500) // Short pause between checks
+  }
+
+  // Assert that the model was properly updated
+  expect(fileUpdated).toBeTruthy()
   expect(readUpdatedFile).not.toContain('SELECT *')
   expect(readUpdatedFile).toContain(
     'SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date',