Skip to content

Commit a652a10

Browse files
authored
fix: full_refresh is expected to be None as a default value but the v… (#2978)
1 parent baf192d commit a652a10

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

sqlmesh/dbt/basemodel.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
from sqlmesh.dbt.relation import Policy, RelationType
2727
from sqlmesh.dbt.test import TestConfig
2828
from sqlmesh.utils import AttributeDict
29-
from sqlmesh.utils.conversions import ensure_bool
3029
from sqlmesh.utils.errors import ConfigError
3130
from sqlmesh.utils.pydantic import field_validator
3231

@@ -144,11 +143,6 @@ def _validate_hooks(cls, v: t.Union[str, t.List[t.Union[SqlStr, str]]]) -> t.Lis
144143

145144
return hooks
146145

147-
@field_validator("full_refresh", mode="before")
148-
@classmethod
149-
def _validate_bool(cls, v: str) -> bool:
150-
return ensure_bool(v)
151-
152146
@field_validator("grants", mode="before")
153147
@classmethod
154148
def _validate_grants(cls, v: t.Dict[str, str]) -> t.Dict[str, t.List[str]]:

tests/dbt/test_transformation.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,10 @@ def test_model_kind():
229229
materialized=Materialization.INCREMENTAL, incremental_strategy="append"
230230
).model_kind(context) == IncrementalUnmanagedKind(disable_restatement=False)
231231

232+
assert ModelConfig(
233+
materialized=Materialization.INCREMENTAL, incremental_strategy="append", full_refresh=None
234+
).model_kind(context) == IncrementalUnmanagedKind(disable_restatement=False)
235+
232236
assert ModelConfig(
233237
materialized=Materialization.INCREMENTAL,
234238
incremental_strategy="insert_overwrite",

0 commit comments

Comments
 (0)