Add display_name to SnapshotIdAndVersion

Author: erindru

sqlmesh/core/plan/explainer.py

@@ -11,7 +11,6 @@
 from sqlmesh.core import constants as c
 from sqlmesh.core.console import Console, TerminalConsole, get_console
 from sqlmesh.core.environment import EnvironmentNamingInfo
-from sqlmesh.core.snapshot.definition import model_display_name
 from sqlmesh.core.plan.common import (
     SnapshotIntervalClearRequest,
     identify_restatement_intervals_across_snapshot_versions,
@@ -22,7 +21,7 @@
     PlanEvaluator,
 )
 from sqlmesh.core.state_sync import StateReader
-from sqlmesh.core.snapshot.definition import SnapshotInfoMixin, SnapshotNameVersionLike
+from sqlmesh.core.snapshot.definition import SnapshotInfoMixin, SnapshotIdAndVersion
 from sqlmesh.utils import Verbosity, rich as srich, to_snake_case
 from sqlmesh.utils.date import to_ts
 from sqlmesh.utils.errors import SQLMeshError
@@ -323,22 +322,17 @@ def visit_finalize_environment_stage(
 
     def _display_name(
         self,
-        snapshot: t.Union[SnapshotInfoMixin, SnapshotNameVersionLike],
+        snapshot: t.Union[SnapshotInfoMixin, SnapshotIdAndVersion],
         environment_naming_info: t.Optional[EnvironmentNamingInfo] = None,
     ) -> str:
-        naming_kwargs: t.Any = dict(
+        return snapshot.display_name(
             environment_naming_info=environment_naming_info or self.environment_naming_info,
             default_catalog=self.default_catalog
             if self.verbosity < Verbosity.VERY_VERBOSE
             else None,
             dialect=self.dialect,
         )
 
-        if isinstance(snapshot, SnapshotInfoMixin):
-            return snapshot.display_name(**naming_kwargs)
-
-        return model_display_name(node_name=snapshot.name, **naming_kwargs)
-
     def _limit_tree(self, tree: Tree) -> Tree:
         tree_length = len(tree.children)
         if tree_length <= MAX_TREE_LENGTH:

sqlmesh/core/snapshot/definition.py

@@ -638,6 +638,16 @@ def dev_version(self) -> str:
     def model_kind_name(self) -> t.Optional[ModelKindName]:
         return self.kind_name_
 
+    def display_name(
+        self,
+        environment_naming_info: EnvironmentNamingInfo,
+        default_catalog: t.Optional[str],
+        dialect: DialectType = None,
+    ) -> str:
+        return model_display_name(
+            self.name, environment_naming_info, default_catalog, dialect=dialect
+        )
+
 
 class Snapshot(PydanticModel, SnapshotInfoMixin):
     """A snapshot represents a node at a certain point in time.