migrate_ddl -> migrate_schemas, migrate_dml -> migrate_rows

Author: izeigerman

sqlmesh/core/state_sync/db/migrator.py

@@ -177,10 +177,10 @@ def _apply_migrations(
 
         for migration in migrations:
             logger.info(f"Applying migration {migration}")
-            migration.migrate_ddl(state_sync, default_catalog=default_catalog)
+            migration.migrate_schemas(state_sync, default_catalog=default_catalog)
             if state_table_exist:
                 # No need to run DML for the initial migration since all tables are empty
-                migration.migrate_dml(state_sync, default_catalog=default_catalog)
+                migration.migrate_rows(state_sync, default_catalog=default_catalog)
 
         snapshot_count_after = self.snapshot_state.count()
 

sqlmesh/migrations/v0001_init.py

@@ -9,7 +9,7 @@
 from sqlmesh.utils.migration import index_text_type
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     engine_adapter = state_sync.engine_adapter
     schema = state_sync.schema
     snapshots_table = "_snapshots"
@@ -60,5 +60,5 @@ def migrate_ddl(state_sync, **kwargs):  # type: ignore
     )
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0002_remove_identify.py

@@ -1,9 +1,9 @@
 """Remove identify=True kwarg for rendering sql"""
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     pass
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0003_move_batch_size.py

@@ -5,11 +5,11 @@
 from sqlglot import exp
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     pass
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     snapshots_table = "_snapshots"
     if state_sync.schema:
         snapshots_table = f"{state_sync.schema}.{snapshots_table}"

sqlmesh/migrations/v0004_environmnent_add_finalized_at.py

@@ -3,7 +3,7 @@
 from sqlglot import exp
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     engine_adapter = state_sync.engine_adapter
     environments_table = "_environments"
     if state_sync.schema:
@@ -23,5 +23,5 @@ def migrate_ddl(state_sync, **kwargs):  # type: ignore
     engine_adapter.execute(alter_table_exp)
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0005_create_seed_table.py

@@ -5,7 +5,7 @@
 from sqlmesh.utils.migration import index_text_type
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     engine_adapter = state_sync.engine_adapter
     seeds_table = "_seeds"
     if state_sync.schema:
@@ -24,5 +24,5 @@ def migrate_ddl(state_sync, **kwargs):  # type: ignore
     )
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0006_change_seed_hash.py

@@ -1,9 +1,9 @@
 """Seed hashes moved from to_string to to_json for performance."""
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     pass
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0007_env_table_info_to_kind.py

@@ -12,11 +12,11 @@ def _hash(data):  # type: ignore
     return str(zlib.crc32(";".join("" if d is None else d for d in data).encode("utf-8")))
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     pass
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     import pandas as pd
 
     engine_adapter = state_sync.engine_adapter

sqlmesh/migrations/v0008_create_intervals_table.py

@@ -5,7 +5,7 @@
 from sqlmesh.utils.migration import index_text_type
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     engine_adapter = state_sync.engine_adapter
     intervals_table = "_intervals"
     if state_sync.schema:
@@ -38,5 +38,5 @@ def migrate_ddl(state_sync, **kwargs):  # type: ignore
     )
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     pass

sqlmesh/migrations/v0009_remove_pre_post_hooks.py

@@ -7,11 +7,11 @@
 from sqlmesh.utils.migration import index_text_type
 
 
-def migrate_ddl(state_sync, **kwargs):  # type: ignore
+def migrate_schemas(state_sync, **kwargs):  # type: ignore
     pass
 
 
-def migrate_dml(state_sync, **kwargs):  # type: ignore
+def migrate_rows(state_sync, **kwargs):  # type: ignore
     import pandas as pd
 
     engine_adapter = state_sync.engine_adapter