addressing comments

Author: benfdking

sqlmesh/lsp/commands.py

@@ -1,7 +1 @@
-from sqlmesh.utils.pydantic import PydanticModel
-
 EXTERNAL_MODEL_UPDATE_COLUMNS = "sqlmesh.external_model_update_columns"
-
-
-class ExternalModelUpdateColumnsRequest(PydanticModel):
-    model_name: str

sqlmesh/lsp/context.py

@@ -236,7 +236,7 @@ def get_code_actions(
                         edit=types.WorkspaceEdit(changes={params.text_document.uri: text_edits}),
                     )
                     code_actions.append(code_action)
-        return code_actions
+        return code_actions if code_actions else None
 
     def get_code_lenses(self, uri: URI) -> t.Optional[t.List[types.CodeLens]]:
         models_in_file = self.map.get(uri.to_path())

sqlmesh/lsp/main.py

@@ -23,7 +23,7 @@
     ApiResponseGetLineage,
     ApiResponseGetModels,
 )
-from sqlmesh.lsp.commands import ExternalModelUpdateColumnsRequest, EXTERNAL_MODEL_UPDATE_COLUMNS
+from sqlmesh.lsp.commands import EXTERNAL_MODEL_UPDATE_COLUMNS
 from sqlmesh.lsp.completions import get_sql_completions
 from sqlmesh.lsp.context import (
     LSPContext,
@@ -325,31 +325,28 @@ def command_external_models_update_columns(ls: LanguageServer, raw: t.Any) -> No
                 if not isinstance(model_name, str):
                     raise ValueError("Command parameter must be a string")
 
-                request = ExternalModelUpdateColumnsRequest(model_name=model_name)
                 context = self._context_get_or_load()
                 if not isinstance(context, LSPContext):
                     raise ValueError("Context is not loaded or invalid")
-                model = context.context.get_model(request.model_name)
+                model = context.context.get_model(model_name)
                 if model is None:
-                    raise ValueError(f"External model '{request.model_name}' not found")
+                    raise ValueError(f"External model '{model_name}' not found")
                 if model._path is None:
-                    raise ValueError(
-                        f"External model '{request.model_name}' does not have a file path"
-                    )
+                    raise ValueError(f"External model '{model_name}' does not have a file path")
                 uri = URI.from_path(model._path)
                 updated = context.update_external_model_columns(
                     ls=ls,
                     uri=uri,
-                    model_name=request.model_name,
+                    model_name=model_name,
                 )
                 if updated:
                     ls.show_message(
-                        f"Updated columns for '{request.model_name}'",
+                        f"Updated columns for '{model_name}'",
                         types.MessageType.Info,
                     )
                 else:
                     ls.show_message(
-                        f"Columns for '{request.model_name}' are already up to date",
+                        f"Columns for '{model_name}' are already up to date",
                     )
             except Exception as e:
                 ls.show_message(f"Error executing command: {e}", types.MessageType.Error)