Skip to content

Commit b6e5eab

Browse files
committed
Improve test
1 parent 032b5fa commit b6e5eab

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

tests/dbt/test_adapter.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -367,13 +367,15 @@ def test_adapter_expand_target_column_types(
367367
"int_col": exp.DataType.build("int"),
368368
"same_text_col": exp.DataType.build("varchar(1)"), # varchar(1) -> varchar(1)
369369
"unexpandable_text_col": exp.DataType.build("varchar(2)"), # varchar(4) -> varchar(2)
370-
"expandable_text_col": exp.DataType.build("varchar(16)"), # varchar(8) -> varchar(16)
370+
"expandable_text_col1": exp.DataType.build("varchar(16)"), # varchar(8) -> varchar(16)
371+
"expandable_text_col2": exp.DataType.build("varchar(64)"), # varchar(32) -> varchar(64)
371372
}
372373
to_columns = {
373374
"int_col": exp.DataType.build("int"),
374375
"same_text_col": exp.DataType.build("varchar(1)"),
375376
"unexpandable_text_col": exp.DataType.build("varchar(4)"),
376-
"expandable_text_col": exp.DataType.build("varchar(8)"),
377+
"expandable_text_col1": exp.DataType.build("varchar(8)"),
378+
"expandable_text_col2": exp.DataType.build("varchar(32)"),
377379
}
378380
adapter_mock = mocker.MagicMock()
379381
adapter_mock.default_catalog = "test"
@@ -411,11 +413,18 @@ def test_adapter_expand_target_column_types(
411413
)
412414
assert len(adapter_mock.alter_table.call_args.args) == 1
413415
alter_expressions = adapter_mock.alter_table.call_args.args[0]
414-
assert len(alter_expressions) == 1
415-
alter_operation = alter_expressions[0]
416-
assert isinstance(alter_operation, TableAlterChangeColumnTypeOperation)
417-
assert alter_operation.expression == parse_one(
416+
assert len(alter_expressions) == 2
417+
alter_operation1 = alter_expressions[0]
418+
assert isinstance(alter_operation1, TableAlterChangeColumnTypeOperation)
419+
assert alter_operation1.expression == parse_one(
418420
"""ALTER TABLE "test"."foo"."to_table"
419-
ALTER COLUMN expandable_text_col
421+
ALTER COLUMN expandable_text_col1
420422
SET DATA TYPE VARCHAR(16)"""
421423
)
424+
alter_operation2 = alter_expressions[1]
425+
assert isinstance(alter_operation2, TableAlterChangeColumnTypeOperation)
426+
assert alter_operation2.expression == parse_one(
427+
"""ALTER TABLE "test"."foo"."to_table"
428+
ALTER COLUMN expandable_text_col2
429+
SET DATA TYPE VARCHAR(64)"""
430+
)

0 commit comments

Comments
 (0)