Fix: pass dialect to name field value converter (#1949)

* fix: pass dialect to name value converter

* chore: add tests and use field name

Author: z3z1ma

sqlmesh/core/model/definition.py

@@ -178,6 +178,13 @@ def render_definition(self, include_python: bool = True) -> t.List[exp.Expressio
                             value=field_value.to_expression(dialect=self.dialect),
                         )
                     )
+                elif field_name == "name":
+                    expressions.append(
+                        exp.Property(
+                            this=field_name,
+                            value=exp.to_table(field_value, dialect=self.dialect),
+                        )
+                    )
                 elif field_name not in ("column_descriptions_", "default_catalog"):
                     expressions.append(
                         exp.Property(
@@ -1928,7 +1935,6 @@ def _refs_to_sql(values: t.Any) -> exp.Expression:
 
 
 META_FIELD_CONVERTER: t.Dict[str, t.Callable] = {
-    "name": lambda value: exp.to_table(value),
     "start": lambda value: exp.Literal.string(value),
     "cron": lambda value: exp.Literal.string(value),
     "batch_size": lambda value: exp.Literal.number(value),

tests/core/test_model.py

@@ -2522,6 +2522,26 @@ def test_scd_type_2_overrides():
     assert not scd_type_2_model.kind.disable_restatement
 
 
+def test_model_dialect_name():
+    expressions = d.parse(
+        """
+        MODEL (
+            name `project-1`.`db`.`tbl1`,
+            dialect bigquery
+        );
+        SELECT 1;
+        """
+    )
+
+    model = load_sql_based_model(expressions)
+    assert model.fqn == '"project-1"."db"."tbl1"'
+
+    model = create_external_model(
+        "`project-1`.`db`.`tbl1`", columns={"x": "STRING"}, dialect="bigquery"
+    )
+    assert "name `project-1`.`db`.`tbl1`" in model.render_definition()[0].sql(dialect="bigquery")
+
+
 def test_model_allow_partials():
     expressions = d.parse(
         """