Skip to content

Commit cd4aa95

Browse files
fix: change varchar(max) to varchar(8000) in integration tests
1 parent f54b0f6 commit cd4aa95

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/core/engine_adapter/integration/test_integration.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ def test_insert_overwrite_by_time_partition(ctx_query_and_df: TestContext):
554554
if ctx.dialect == "bigquery":
555555
ds_type = "datetime"
556556
if ctx.dialect == "tsql":
557-
ds_type = "varchar(max)"
557+
ds_type = "varchar(8000)"
558558

559559
ctx.columns_to_types = {"id": "int", "ds": ds_type}
560560
table = ctx.table("test_table")
@@ -2255,7 +2255,7 @@ def test_table_diff_grain_check_single_key(ctx: TestContext):
22552255

22562256
columns_to_types = {
22572257
"key1": exp.DataType.build("int"),
2258-
"value": exp.DataType.build("varchar(max)"),
2258+
"value": exp.DataType.build("varchar(8000)"),
22592259
}
22602260

22612261
ctx.engine_adapter.create_table(src_table, columns_to_types)
@@ -2319,8 +2319,8 @@ def test_table_diff_grain_check_multiple_keys(ctx: TestContext):
23192319

23202320
columns_to_types = {
23212321
"key1": exp.DataType.build("int"),
2322-
"key2": exp.DataType.build("varchar(max)"),
2323-
"value": exp.DataType.build("varchar(max)"),
2322+
"key2": exp.DataType.build("varchar(8000)"),
2323+
"value": exp.DataType.build("varchar(8000)"),
23242324
}
23252325

23262326
ctx.engine_adapter.create_table(src_table, columns_to_types)
@@ -2377,13 +2377,13 @@ def test_table_diff_arbitrary_condition(ctx: TestContext):
23772377

23782378
columns_to_types_src = {
23792379
"id": exp.DataType.build("int"),
2380-
"value": exp.DataType.build("varchar(max)"),
2380+
"value": exp.DataType.build("varchar(8000)"),
23812381
"ts": exp.DataType.build("timestamp"),
23822382
}
23832383

23842384
columns_to_types_target = {
23852385
"item_id": exp.DataType.build("int"),
2386-
"value": exp.DataType.build("varchar(max)"),
2386+
"value": exp.DataType.build("varchar(8000)"),
23872387
"ts": exp.DataType.build("timestamp"),
23882388
}
23892389

@@ -2444,8 +2444,8 @@ def test_table_diff_identical_dataset(ctx: TestContext):
24442444

24452445
columns_to_types = {
24462446
"key1": exp.DataType.build("int"),
2447-
"key2": exp.DataType.build("varchar(max)"),
2448-
"value": exp.DataType.build("varchar(max)"),
2447+
"key2": exp.DataType.build("varchar(8000)"),
2448+
"value": exp.DataType.build("varchar(8000)"),
24492449
}
24502450

24512451
ctx.engine_adapter.create_table(src_table, columns_to_types)

0 commit comments

Comments
 (0)