feat(lsp): no missing external will create file

- before the fix would only apply if there was a file already there
- now it also has the quick fix if the external models file is not present

Author: benfdking

sqlmesh/core/linter/rule.py

@@ -62,7 +62,7 @@ class Fix:
     """A fix that can be applied to resolve a rule violation."""
 
     title: str
-    edits: t.List[TextEdit]
+    edits: t.List[TextEdit] = field(default_factory=list)
     create_files: t.List[CreateFile] = field(default_factory=list)
 
 

sqlmesh/lsp/context.py

@@ -278,10 +278,12 @@ def get_code_actions(
                         t.Union[
                             types.TextDocumentEdit,
                             types.CreateFile,
+                            types.RenameFile,
+                            types.DeleteFile,
                         ]
                     ] = []
 
-                    for create in getattr(fix, "create_files", []):
+                    for create in fix.create_files:
                         create_uri = URI.from_path(create.path).value
                         document_changes.append(types.CreateFile(uri=create_uri))
                         document_changes.append(

tests/core/linter/test_builtin.py

@@ -57,7 +57,7 @@ def test_no_missing_external_models(tmp_path, copy_to_temp_path) -> None:
     assert len(fix.create_files) == 1
     create = fix.create_files[0]
     assert create.path == sushi_path / "external_models.yaml"
-    assert create.text == "- name: '\"memory\".\"raw\".\"demographics\"'\n"
+    assert create.text == '- name: \'"memory"."raw"."demographics"\'\n'
 
 
 def test_no_missing_external_models_with_existing_file_ending_in_newline(

tests/lsp/test_code_actions.py

@@ -166,7 +166,9 @@ def test_code_actions_create_file(copy_to_temp_path: t.Callable) -> None:
 
     params = types.CodeActionParams(
         text_document=types.TextDocumentIdentifier(uri=uri.value),
-        range=types.Range(start=types.Position(line=0, character=0), end=types.Position(line=1, character=0)),
+        range=types.Range(
+            start=types.Position(line=0, character=0), end=types.Position(line=1, character=0)
+        ),
         context=types.CodeActionContext(diagnostics=diagnostics),
     )