Skip to content

Commit e4f3f1e

Browse files
committed
use raw sql for pre- / post- statements
1 parent 6b8828c commit e4f3f1e

File tree

11 files changed

+204
-157
lines changed

11 files changed

+204
-157
lines changed

sqlmesh/core/audit/definition.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,14 @@ def query(self) -> t.Union[exp.Query, d.JinjaQuery]:
7878

7979
@property
8080
def expressions(self) -> t.List[exp.Expression]:
81-
if self.expressions_:
82-
return [e.parse(self.dialect) for e in self.expressions_]
83-
return []
81+
if not self.expressions_:
82+
return []
83+
result = []
84+
for e in self.expressions_:
85+
parsed = e.parse(self.dialect)
86+
if not isinstance(parsed, exp.Semicolon):
87+
result.append(parsed)
88+
return result
8489

8590
@property
8691
def macro_definitions(self) -> t.List[d.MacroDef]:
@@ -281,8 +286,8 @@ def metadata_hash(self) -> str:
281286
self.cron_tz.key if self.cron_tz else None,
282287
]
283288

284-
query = self.render_audit_query() or self.query
285-
data.append(gen(query))
289+
data.append(self.query_.sql)
290+
data.extend([e.sql for e in self.expressions_ or []])
286291
self._metadata_hash = hash_data(data)
287292
return self._metadata_hash
288293

sqlmesh/core/model/common.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -616,11 +616,6 @@ def parse_strings_with_macro_refs(value: t.Any, dialect: DialectType) -> t.Any:
616616

617617

618618
expression_validator: t.Callable = field_validator(
619-
# "query",
620-
# "expressions_",
621-
"pre_statements_",
622-
"post_statements_",
623-
"on_virtual_update_",
624619
"unique_key",
625620
mode="before",
626621
check_fields=False,
@@ -719,9 +714,9 @@ def _validate_parsable_sql(
719714
return field_validator(
720715
"query_",
721716
"expressions_",
722-
# "pre_statements_",
723-
# "post_statements_",
724-
# "on_virtual_update_",
717+
"pre_statements_",
718+
"post_statements_",
719+
"on_virtual_update_",
725720
mode="before",
726721
check_fields=False,
727722
)(_validate_parsable_sql)

0 commit comments

Comments
 (0)