addressing comments

Author: benfdking

pnpm-lock.yaml

@@ -141,8 +141,10 @@
   "dependencies": {
     "@duckdb/node-api": "1.3.2-alpha.25",
     "@types/fs-extra": "^11.0.4",
+    "@types/shell-quote": "^1.7.5",
     "@vscode/python-extension": "^1.0.5",
     "fs-extra": "^11.3.0",
+    "shell-quote": "^1.8.3",
     "vscode-jsonrpc": "^8.2.1",
     "vscode-languageclient": "^9.0.1",
     "zod": "^3.25.76"

vscode/extension/package.json

@@ -3,6 +3,8 @@ import path from 'path'
 import fs from 'fs'
 import { Result, err, ok } from '@bus/result'
 import { traceVerbose, traceInfo } from './common/log'
+import { parse } from 'shell-quote'
+import { z } from 'zod'
 
 export interface SqlmeshConfiguration {
   projectPath: string
@@ -24,6 +26,8 @@ function getSqlmeshConfiguration(): SqlmeshConfiguration {
   }
 }
 
+const stringsArray = z.array(z.string())
+
 /**
  * Get the SQLMesh LSP entry point from VS Code settings. undefined if not set
  * it's expected to be a string in the format "command arg1 arg2 ...".
@@ -39,12 +43,16 @@ export function getSqlmeshLspEntryPoint():
     return undefined
   }
   // Split the entry point into command and arguments
-  const parts = config.lspEntryPoint.split(' ')
-  const entrypoint = parts[0]
-  const args = parts.slice(1)
-  if (args.length === 0) {
-    return { entrypoint, args: [] }
+  const parts = parse(config.lspEntryPoint)
+  const parsed = stringsArray.safeParse(parts)
+  if (!parsed.success) {
+    throw new Error(
+      `Invalid lspEntrypoint configuration: ${config.lspEntryPoint}. Expected a
+      string in the format "command arg1 arg2 ...".`,
+    )
   }
+  const entrypoint = parsed.data[0]
+  const args = parsed.data.slice(1)
   return { entrypoint, args }
 }
 

vscode/extension/src/utilities/config.ts

@@ -66,7 +66,7 @@ ${sqlmeshLSPFile} "$@"`,
 }
 
 test.describe('Test LSP Entrypoint configuration', () => {
-  test('specify single entrypoint relalative path', async ({
+  test('specify single entrypoint relative path', async ({
     page,
     sharedCodeServer,
     tempDir,