revise to only prompt once; move logic to console

Author: themisvaltinos

sqlmesh/core/console.py

@@ -186,9 +186,19 @@ class DestroyConsole(abc.ABC):
     """Console for describing a destroy operation"""
 
     @abc.abstractmethod
-    def start_destroy(self) -> bool:
+    def start_destroy(
+        self,
+        schemas_to_delete: t.Optional[t.Set[str]] = None,
+        views_to_delete: t.Optional[t.Set[str]] = None,
+        tables_to_delete: t.Optional[t.Set[str]] = None,
+    ) -> bool:
         """Start a destroy operation.
 
+        Args:
+            schemas_to_delete: Set of schemas that will be deleted
+            views_to_delete: Set of views that will be deleted
+            tables_to_delete: Set of tables that will be deleted
+
         Returns:
             Whether or not the destroy operation should proceed
         """
@@ -830,7 +840,12 @@ def print_connection_config(
     ) -> None:
         pass
 
-    def start_destroy(self) -> bool:
+    def start_destroy(
+        self,
+        schemas_to_delete: t.Optional[t.Set[str]] = None,
+        views_to_delete: t.Optional[t.Set[str]] = None,
+        tables_to_delete: t.Optional[t.Set[str]] = None,
+    ) -> bool:
         return True
 
     def stop_destroy(self, success: bool = True) -> None:
@@ -1282,22 +1297,57 @@ def stop_cleanup(self, success: bool = False) -> None:
         else:
             self.log_error("Cleanup failed!")
 
-    def start_destroy(self) -> bool:
+    def start_destroy(
+        self,
+        schemas_to_delete: t.Optional[t.Set[str]] = None,
+        views_to_delete: t.Optional[t.Set[str]] = None,
+        tables_to_delete: t.Optional[t.Set[str]] = None,
+    ) -> bool:
         self.log_error(
             (
                 "!!!  EXTREME CAUTION: DESTRUCTIVE OPERATION !!!\n\n"
-                "The 'destroy' command will PERMANENTLY DELETE:\n"
+                "The 'destroy' command will DELETE:\n"
                 "  • ALL state tables and metadata\n"
                 "  • ALL SQLMesh cache and build artifacts\n"
                 "  • ALL tables and views in the project's schemas/datasets\n"
                 "  • ALL schemas/datasets managed by SQLMesh in this project\n\n"
                 "!!! WARNING: This includes external tables created or managed by other tools !!!\n\n"
-                "The operation is irreversible and may disrupt any currently running or scheduled plans.\n"
+                "The operation may disrupt any currently running or scheduled plans.\n"
                 "Only use this command when you intend to COMPLETELY DESTROY the project.\n"
             )
         )
-        if not self._confirm("Do you understand the risks and want to see what will be deleted?"):
-            self.log_error("Destroy aborted!")
+
+        # Display what will be deleted
+        if schemas_to_delete or views_to_delete or tables_to_delete:
+            self.log_error("\n" + "=" * 50 + "\n")
+            if schemas_to_delete:
+                self.log_error("Schemas to be deleted:")
+                for schema in sorted(schemas_to_delete):
+                    self.log_error(f"  • {schema}")
+
+            if views_to_delete:
+                self.log_error("\nEnvironment views to be deleted:")
+                for view in sorted(views_to_delete):
+                    self.log_error(f"  • {view}")
+
+            if tables_to_delete:
+                self.log_error("\nSnapshot tables to be deleted:")
+                for table in sorted(tables_to_delete):
+                    self.log_error(f"  • {table}")
+
+            self.log_error("\nAll SQLMesh state tables will be deleted")
+            self.log_error("\n" + "=" * 50 + "\n")
+
+            # Final confirmation with stronger warning
+            self.log_error(
+                "!!! WARNING: This action will DELETE ALL the above resources managed by SQLMesh\n"
+                "AND potentially external resources created by other tools in these schemas !!!\n"
+            )
+
+        if not self._confirm(
+            "Do you understand the risks and are you ABSOLUTELY SURE you want to proceed with deletion?"
+        ):
+            self.log_error("Destroy operation cancelled.")
             return False
         return True
 

sqlmesh/core/context.py

@@ -858,7 +858,50 @@ def run_janitor(self, ignore_ttl: bool) -> bool:
     def destroy(self) -> bool:
         success = False
 
-        if self.console.start_destroy():
+        # Collect resources to be deleted
+        environments = self.state_reader.get_environments()
+        schemas_to_delete = set()
+        tables_to_delete = set()
+        views_to_delete = set()
+        all_snapshot_infos = set()
+
+        # For each environment find schemas and tables
+        for environment in environments:
+            all_snapshot_infos.update(environment.snapshots)
+            snapshots = self.state_reader.get_snapshots(environment.snapshots).values()
+            for snapshot in snapshots:
+                if snapshot.is_model and not snapshot.is_symbolic:
+                    # Get the appropriate adapter
+                    if environment.gateway_managed and snapshot.model_gateway:
+                        adapter = self.engine_adapters.get(
+                            snapshot.model_gateway, self.engine_adapter
+                        )
+                    else:
+                        adapter = self.engine_adapter
+
+                    if environment.suffix_target.is_schema or environment.suffix_target.is_catalog:
+                        schema = snapshot.qualified_view_name.schema_for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        catalog = snapshot.qualified_view_name.catalog_for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        if catalog:
+                            schemas_to_delete.add(f"{catalog}.{schema}")
+                        else:
+                            schemas_to_delete.add(schema)
+
+                    if environment.suffix_target.is_table:
+                        view_name = snapshot.qualified_view_name.for_environment(
+                            environment.naming_info, dialect=adapter.dialect
+                        )
+                        views_to_delete.add(view_name)
+
+                    # Add snapshot tables
+                    table_name = snapshot.table_name()
+                    tables_to_delete.add(table_name)
+
+        if self.console.start_destroy(schemas_to_delete, views_to_delete, tables_to_delete):
             try:
                 success = self._destroy()
             finally:
@@ -2723,80 +2766,6 @@ def _context_diff(
         )
 
     def _destroy(self) -> bool:
-        environments = self.state_reader.get_environments()
-
-        schemas_to_delete = set()
-        tables_to_delete = set()
-        views_to_delete = set()
-        all_snapshot_infos = set()
-
-        # For each environment find schemas and tables
-        for environment in environments:
-            all_snapshot_infos.update(environment.snapshots)
-            snapshots = self.state_reader.get_snapshots(environment.snapshots).values()
-            for snapshot in snapshots:
-                if snapshot.is_model and not snapshot.is_symbolic:
-                    # Get the appropriate adapter
-                    if environment.gateway_managed and snapshot.model_gateway:
-                        adapter = self.engine_adapters.get(
-                            snapshot.model_gateway, self.engine_adapter
-                        )
-                    else:
-                        adapter = self.engine_adapter
-
-                    if environment.suffix_target.is_schema or environment.suffix_target.is_catalog:
-                        schema = snapshot.qualified_view_name.schema_for_environment(
-                            environment.naming_info, dialect=adapter.dialect
-                        )
-                        catalog = snapshot.qualified_view_name.catalog_for_environment(
-                            environment.naming_info, dialect=adapter.dialect
-                        )
-                        if catalog:
-                            schemas_to_delete.add(f"{catalog}.{schema}")
-                        else:
-                            schemas_to_delete.add(schema)
-
-                    if environment.suffix_target.is_table:
-                        view_name = snapshot.qualified_view_name.for_environment(
-                            environment.naming_info, dialect=adapter.dialect
-                        )
-                        views_to_delete.add(view_name)
-
-                    # Add snapshot tables
-                    table_name = snapshot.table_name()
-                    tables_to_delete.add(table_name)
-
-        # Display what will be deleted
-        self.console.log_error("\n" + "=" * 50 + "\n")
-        if schemas_to_delete:
-            self.console.log_error("Schemas to be deleted:")
-            for schema in sorted(schemas_to_delete):
-                self.console.log_error(f"  • {schema}")
-
-        if views_to_delete:
-            self.console.log_error("\nEnvironment views to be deleted:")
-            for view in sorted(views_to_delete):
-                self.console.log_error(f"  • {view}")
-
-        if tables_to_delete:
-            self.console.log_error("\nSnapshot tables to be deleted:")
-            for table in sorted(tables_to_delete):
-                self.console.log_error(f"  • {table}")
-
-        self.console.log_error("\nAll SQLMesh state tables will be deleted")
-        self.console.log_error("\n" + "=" * 50 + "\n")
-
-        # Final confirmation with stronger warning
-        self.console.log_error(
-            "!!! CRITICAL WARNING: This action will PERMANENTLY DELETE ALL the above resources!\n"
-            "This includes ALL tables, views and schemas managed by SQLMesh AND potentially\n"
-            "external resources created by other tools in these schemas. This action is IRREVERSIBLE!\n"
-        )
-
-        if not self.console._confirm("Are you ABSOLUTELY SURE you want to proceed with deletion?"):  # type: ignore
-            self.console.log_error("Destroy operation cancelled.")
-            return False
-
         # Invalidate all environments, including prod
         for environment in self.state_reader.get_environments():
             self.state_sync.invalidate_environment(name=environment.name, protect_prod=False)

tests/integrations/jupyter/test_magics.py

@@ -900,31 +900,29 @@ def test_destroy(
     expected_messages = [
         (
             "!!!  EXTREME CAUTION: DESTRUCTIVE OPERATION !!!\n\n"
-            "The 'destroy' command will PERMANENTLY DELETE:\n"
+            "The 'destroy' command will DELETE:\n"
             "  • ALL state tables and metadata\n"
             "  • ALL SQLMesh cache and build artifacts\n"
             "  • ALL tables and views in the project's schemas/datasets\n"
             "  • ALL schemas/datasets managed by SQLMesh in this project\n\n"
             "!!! WARNING: This includes external tables created or managed by other tools !!!\n\n"
-            "The operation is irreversible and may disrupt any currently running or scheduled plans.\n"
+            "The operation may disrupt any currently running or scheduled plans.\n"
             "Only use this command when you intend to COMPLETELY DESTROY the project."
         ),
-        "Do you understand the risks and want to see what will be deleted? [y/n]:",
         "Schemas to be deleted:",
         "• memory.sushi",
         "Snapshot tables to be deleted:",
         "All SQLMesh state tables will be deleted",
+        "==================================================",
         (
-            "!!! CRITICAL WARNING: This action will PERMANENTLY DELETE ALL the above resources!\n"
-            "This includes ALL tables, views and schemas managed by SQLMesh AND potentially\n"
-            "external resources created by other tools in these schemas. This action is IRREVERSIBLE!"
+            "!!! WARNING: This action will DELETE ALL the above resources managed by SQLMesh\n"
+            "AND potentially external resources created by other tools in these schemas !!!"
         ),
-        "Are you ABSOLUTELY SURE you want to proceed with deletion? [y/n]:",
+        "Do you understand the risks and are you ABSOLUTELY SURE you want to proceed with deletion? [y/n]:",
         "Environment 'prod' invalidated.",
         "Deleted object memory.sushi",
         'Deleted object "memory"."raw"."model1"',
         'Deleted object "memory"."raw"."model2"',
-        'Deleted object "memory"."raw"."demographics"',
         "State tables removed.",
         "Destroy completed successfully.",
     ]