From b557f2ca9a0ecf09818242f044fd21de2c5aeb95 Mon Sep 17 00:00:00 2001 From: Matthew Barulic Date: Sun, 12 Oct 2025 19:20:22 -0400 Subject: [PATCH 1/2] Adds `reserve` workaround for compiler static analysis bug. --- ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp b/ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp index afbf82da2..a3c8e3335 100644 --- a/ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp +++ b/ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp @@ -159,6 +159,7 @@ bool isPointInOrBehindGoal( std::vector getAddedObstacles(const World & world) { std::vector obstacles; + obstacles.reserve(3); const auto half_field_length = world.field.field_length / 2.0; const auto half_goal_width = world.field.goal_width / 2.0; From a54363d2253af29a7d08f3e4243e9d27b66f35d7 Mon Sep 17 00:00:00 2001 From: Matthew Barulic Date: Sun, 12 Oct 2025 19:21:31 -0400 Subject: [PATCH 2/2] Puts PR validation builds in Release mode --- .github/workflows/pr_validation.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_validation.yml b/.github/workflows/pr_validation.yml index f58641bab..97e468aa1 100644 --- a/.github/workflows/pr_validation.yml +++ b/.github/workflows/pr_validation.yml @@ -37,14 +37,14 @@ jobs: shell: bash run: | source /opt/ros/jazzy/setup.bash - colcon build --packages-up-to ${{ steps.get-changed-packages.outputs.changed-packages }} + colcon build --packages-up-to ${{ steps.get-changed-packages.outputs.changed-packages }} --cmake-args -DCMAKE_BUILD_TYPE=Release - name: Build Above Changes if: ${{ steps.get-changed-packages.outputs.changed-packages != '' }} shell: bash run: | source /opt/ros/jazzy/setup.bash - colcon build --packages-above-and-dependencies ${{ steps.get-changed-packages.outputs.changed-packages }} + colcon build --packages-above-and-dependencies ${{ steps.get-changed-packages.outputs.changed-packages }} --cmake-args -DCMAKE_BUILD_TYPE=Release - name: Test Changed Packages shell: bash