Open
Conversation
dfloo
requested review from
Anchellon,
davidagustin,
jjfreund,
lgarofalo and
richardxia
richardxia
approved these changes
Feb 20, 2026
Member
richardxia
left a comment
richardxia
left a comment
There was a problem hiding this comment.
This LGTM aside from my one question about creating the Adult Shelter Reservation category. Did you run the migration locally on a copy of the prod DB? It's pretty important to do that to make sure that we won't hit any issues when trying to deploy the changes.
| delete_category_relationship 'sfsg-health', 'Coronavirus (COVID-19) Testing' | ||
|
|
||
| ## sfsg-shelter | ||
| create_category 'Adult Shelter Reservation' |
Member
There was a problem hiding this comment.
Do we need to create this as a real category? If we could make this a frontend-only thing, then it wouldn't pollute the actual DB and edit interface with this category.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new migration for category updates