General concerns with approach #39
dhruveonmars
started this conversation in
General
Replies: 1 comment
-
|
Related: #38 (comment) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Style settings seem cool at the surface. Settings you may not need are hidden, they adapt based on previous choices, eg align icons based on direction chosen. Once you start digging into it, it seems extremely unfriendly to devs, and large stores.
Using style settings would mean maintenance and config nightmare for large stores that need consistency. Adding a style setting on the theme level, doesn't allow mobile overrides. Is there any reason for the mixed behaviour? That would certainly cause confusion amongst users. How can we inherit from the theme to the section/block without then adding more settings?
Eg, defining section padding on theme level for consistency, but then we would need to add additional settings to inherit that, or then listen to the style setting on the section/block to override it, instead of just having the padding option not there by default and a way to remove it.
Are there any plans for devs to define their own style settings? What if some items should have gap settings, and some of the other style settings, but not all, eg the ability to wrap it?
Is there a reason mobile is not the first approach or standard, and mobile is the override instead, considering most browsing is done on phones. Will there be a way for devs to control this. This one change would mean a massive upgrade workflow for themes built as mobile-first.
Is there any reason settings are frozen when style settings are used on a block? Seems like odd behaviour, with no control, which may cause an issue, for eg if we provide an option to configure a different image between mobile and tablet+, how would that be possible? When overriding the style settings, it's highlighted in green and has the green indicator to show an override, while standard settings can't even be changed. This would mean users would constantly have to flip between mobile/tablet+ responsiveness to check and change items.
I still see no option for colour scheme to be inherited from section > block, which means if a user changes it at the top level, they could then have to change it in several other areas, instead of them automatically following it and changing it when they want a different colour scheme.
Resources
I didn't see this in the new reference theme. Is this not ready for dev preview? or is there a way we can enable it? Assuming it would be for devs to support it, and not automatically added everywhere/sections?
Beta Was this translation helpful? Give feedback.
All reactions