Mismatch between variable names at set_bc.cpp

[Eleven7825]

Description

set_bc_dir is set to use the new variables in the definitions:

svMultiPhysics/Code/Source/solver/set_bc.cpp

Lines 759 to 774 in 2a03051

	/// @brief Apply Dirichlet BCs strongly.
	///
	/// Parameters
	/// lA - New time derivative of variables (An)
	/// lY - New variables (Yn)
	/// lD - New integrated variables (Dn)
	///
	/// Modfies:
	/// lA(tDof, tnNo)
	/// lY(tDof, tnNo)
	/// lD(tDof, tnNo)
	/// com_mod.Ad - Time derivative of displacement
	///
	/// Reproduces 'SUBROUTINE SETBCDIR(lA, lY, lD)'
	//
	void set_bc_dir(ComMod& com_mod, Array<double>& lA, Array<double>& lY, Array<double>& lD)

However, we seem to use the old variables when calling the functions

svMultiPhysics/Code/Source/solver/initialize.cpp

Lines 831 to 838 in 2a03051

	// Making sure the old solution satisfies BCs
	//
	// Modifes
	// com_mod.Ao - Old time derivative of variables (acceleration)
	// com_mod.Yo - Old variables (velocity)
	// com_mod.Do - Old integrated variables (dissplacement)
	//
	set_bc::set_bc_dir(com_mod, com_mod.Ao, com_mod.Yo, com_mod.Do);

Any thoughts, @ktbolt ?

Expected behavior

Still pass the test, so we suspect it is just a naming issue?

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct and Contributing Guidelines

[ktbolt]

@Eleven7825 The comment above the call to set_bc::set_bc_dir states Making sure the old solution satisfies BCs so it seems that this is setting Ao,Yo,Do when initializing the simulation.

Why do you think this is wrong ?

[mrp089]

Further down in set_bc_dir, we're doing these subtractions:

svMultiPhysics/Code/Source/solver/set_bc.cpp

Lines 935 to 936 in 2a03051

	lA(j,Ac) = c1i*(lY(j,Ac) - com_mod.Yo(j,Ac) + c2*com_mod.Ao(j,Ac));
	com_mod.Ad(i,Ac) = c1i*(lD(j,Ac) - com_mod.Do(j,Ac) + c2*com_mod.Ad(i,Ac));

With the given arguments, we're subtracting lY - com_mod.Yo and lD - com_mod.Do. Given how set_bc_dir is called in initialize, this should always be zero. So @Eleven7825 and I weren't sure what the point of that subtraction was and if it works as intended.

[ktbolt]

@mrp089 The terms you mention will indeed be zero upon initialization which seems correct for what set_bc_dir is intended to do for these equations. There are other things going on in this function for other equations and perhaps if the simulation is being continued from a previous simulation.