-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Problem
We currently store the results for each test cases in a list, e.g.:
svOneDSolver/Tests/SystemTests/test_integration.py
Lines 198 to 212 in d98fd52
| def test_bifurcation_RCR(tmpdir): | |
| results = run_test_case_by_name('bifurcation_RCR', tmpdir) | |
| assert np.isclose(get_result(results, 'pressure', 0, 0, np.arange(100, 200), 'mean'), 123878.022943, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 0, 0, np.arange(100, 200), 'max'), 168182.372624, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 0, 0, np.arange(100, 200), 'min'), 89237.6441223, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 1, -1, np.arange(100, 200), 'mean'), 123855.677783, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 1, -1, np.arange(100, 200), 'max'), 171598.373528, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 1, -1, np.arange(100, 200), 'min'), 87624.0897929, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 2, -1, np.arange(100, 200), 'mean'), 123855.677783, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 2, -1, np.arange(100, 200), 'max'), 171598.373528, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'pressure', 2, -1, np.arange(100, 200), 'min'), 87624.0897929, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'flow', 0, 0, np.arange(100, 200), 'mean'), 7.557147487534, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'flow', 1, -1, np.arange(100, 200), 'mean'), 3.839024865141, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'flow', 1, -1, np.arange(100, 200), 'max'), 24.0553490482, rtol=1e-7) | |
| assert np.isclose(get_result(results, 'flow', 1, -1, np.arange(100, 200), 'min'), -3.35029015773, rtol=1e-7) |
While it's nice to explicitly see the results we're testing against, it makes it somewhat annoying to add new tests (especially if those are larger).
Solution
Store a reference solution for each case in a dedicated folder and compare every test against the reference.
Additional context
This has been done for svZeroDSolver in SimVascular/svZeroDSolver@ae38e9a
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers