Skip to content

Extend cycle to cycle error check for closed-loop models #212

@aabrown100-git

Description

@aabrown100-git

Problem

In #109, code was added to check for cycle-to-cycle convergence for an open-loop 0D model. To do so, it tracks cycle-to-cycle changes in mean pressure and flow at vessel caps, which seem to be limited to connections between vessels and boundary_conditions. For closed-loop model, there are no boundary_conditions, so the periodicity check does not work.

Solution

Modify the periodicity check to consider inlets and outlets of all vessels, regardless of if they are connected to boundary conditions.

Additional context

@mrp089 @menon-karthik was there a reason this periodicity check was originally limited to vessel-boundary_condition connections?

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions