-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
In #109, code was added to check for cycle-to-cycle convergence for an open-loop 0D model. To do so, it tracks cycle-to-cycle changes in mean pressure and flow at vessel caps, which seem to be limited to connections between vessels and boundary_conditions. For closed-loop model, there are no boundary_conditions, so the periodicity check does not work.
Solution
Modify the periodicity check to consider inlets and outlets of all vessels, regardless of if they are connected to boundary conditions.
Additional context
@mrp089 @menon-karthik was there a reason this periodicity check was originally limited to vessel-boundary_condition connections?
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request