同一コードを排除

Author: OneWalkDev

README.md

@@ -22,6 +22,9 @@
 
 他人のお金を確認
 /seecoin [playerName]
+
+お金をセットする
+/setcoin [playerName]
 ```
 
 ## API
@@ -72,3 +75,5 @@ https://github.com/SpaceServerDev/SecureCoinAPI/blob/87252872ac9dd25a450102f807d
 ```php
 $api->getCoin($player->getName());
 ```
+
+お金をセット

src/space/yurisi/SecureCoinAPI/command/SecureCoinCommand.php

@@ -1,14 +1,16 @@
 <?php
+declare(strict_types=1);
 
 namespace space\yurisi\SecureCoinAPI\command;
 
+use pocketmine\command\CommandSender;
 use pocketmine\command\defaults\VanillaCommand;
 use pocketmine\player\Player;
 use pocketmine\Server;
 
 abstract class SecureCoinCommand extends VanillaCommand {
 
-    public function getPlayer(string $name): string {
+    protected function getPlayer(string $name): string {
         $receive_player = Server::getInstance()->getPlayerByPrefix($name);
 
         if ($receive_player instanceof Player) {
@@ -19,4 +21,23 @@ public function getPlayer(string $name): string {
         return $receive_player;
     }
 
+    protected function getAmount(array $args, CommandSender $sender): ?int {
+        if (!isset($args[0]) || !isset($args[1])) {
+            $sender->sendMessage($this->getUsage());
+            return null;
+        }
+
+        if (!is_numeric($args[1])) {
+            $sender->sendMessage($this->getUsage());
+            return null;
+        }
+
+        if ((int)$args[1] < 0) {
+            $sender->sendMessage("数値は正の値を指定してください。");
+            return null;
+        }
+
+        return (int)floor((int)$args[1]);
+    }
+
 }

src/space/yurisi/SecureCoinAPI/command/addcoinCommand.php

@@ -16,17 +16,9 @@ public function __construct(private SecureCoinAPI $main) {
     }
 
     public function execute(CommandSender $sender, string $commandLabel, array $args) {
-        if (!isset($args[0]) || !isset($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
-
-        if (!is_numeric($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
+        $amount = $this->getAmount($args, $sender);
 
-        $amount = (int)floor((int)$args[1]);
+        if($amount == null) return;
 
         $receive_player = $this->getPlayer($args[0]);
 

src/space/yurisi/SecureCoinAPI/command/setcoinCommand.php

@@ -15,22 +15,9 @@ public function __construct(private SecureCoinAPI $main) {
     }
 
     public function execute(CommandSender $sender, string $commandLabel, array $args) {
-        if (!isset($args[0]) || !isset($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
-
-        if (!is_numeric($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
-
-        if ((int)$args[1] < 0) {
-            $sender->sendMessage("数値は正の値を指定してください。");
-            return;
-        }
+        $amount = $this->getAmount($args, $sender);
 
-        $amount = (int)floor((int)$args[1]);
+        if($amount == null) return;
 
         $receive_player = $this->getPlayer($args[0]);
 

src/space/yurisi/SecureCoinAPI/command/takecoinCommand.php

@@ -14,17 +14,9 @@ public function __construct(private SecureCoinAPI $main) {
     }
 
     public function execute(CommandSender $sender, string $commandLabel, array $args) {
-        if (!isset($args[0]) || !isset($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
-
-        if (!is_numeric($args[1])) {
-            $sender->sendMessage($this->getUsage());
-            return;
-        }
+        $amount = $this->getAmount($args, $sender);
 
-        $amount = (int)floor((int)$args[1]);
+        if($amount == null) return;
 
         $receive_player = $this->getPlayer($args[0]);