Skip to content

Error message should be send when client send invalid UUID field #18

@kestivvi

Description

@kestivvi

For example JoinRoom reaction is handling invalid UUID sent by the client, but just that in dataclass of this reaction, precisely in the RoomDTO for example there is UUID field, this is checked automatically for valid UUID by the JsonParser in the onMessage method in the WebSocketSplendorServer class. So checking for valid UUID is redundant in the reactions.

But for some reason, error response is not being sent by the server when this happen. There must be something wrong in the WebSocketSplendorServer class in its onMessage method.

This bug occures on current commit (faea176) when client send this request:

{
   "messageContextId":"80bdc250-5365-4caf-8dd9-a33e709a0116",
   "type":"CREATE_ROOM",
   "data":{
      "userDTO":{
         "uuid":"tajny",
         "name":"James"
      },
      "roomDTO":{
         "name":"TajnyPokoj",
         "password":"kjashjkasd"
      }
   }
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions