-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
difficulty: 🙂🙂Below average taskBelow average taskscope: 🛠️it's job for developersit's job for developerstype: bug 🪰issue: reporting a bugissue: reporting a bug
Description
For example JoinRoom reaction is handling invalid UUID sent by the client, but just that in dataclass of this reaction, precisely in the RoomDTO for example there is UUID field, this is checked automatically for valid UUID by the JsonParser in the onMessage method in the WebSocketSplendorServer class. So checking for valid UUID is redundant in the reactions.
But for some reason, error response is not being sent by the server when this happen. There must be something wrong in the WebSocketSplendorServer class in its onMessage method.
This bug occures on current commit (faea176) when client send this request:
{
"messageContextId":"80bdc250-5365-4caf-8dd9-a33e709a0116",
"type":"CREATE_ROOM",
"data":{
"userDTO":{
"uuid":"tajny",
"name":"James"
},
"roomDTO":{
"name":"TajnyPokoj",
"password":"kjashjkasd"
}
}
}
Metadata
Metadata
Assignees
Labels
difficulty: 🙂🙂Below average taskBelow average taskscope: 🛠️it's job for developersit's job for developerstype: bug 🪰issue: reporting a bugissue: reporting a bug