Unable to reload plugin command on Paper

[KioProject123]

Server: paper-1.21.8-35
I used the v1 plugin, then put the v2 plugin in the plugins/update folder, and reloaded it using Plugmanx. The output was still v1.
After restarting the server, the output was correctly v2.

[Test-Account666]

Please check, if v3.0.2-RC.3 fixes this issue for you

[KioProject123]

Please check, if v3.0.2-RC.3 fixes this issue for you

After testing, it seems that the problem still exists

[Test-Account666]

Please check, if v3.0.2-RC.3 fixes this issue for you

After testing, it seems that the problem still exists

Even if you use unload, wait a bit and load again?

[KioProject123]

Please check, if v3.0.2-RC.3 fixes this issue for you

After testing, it seems that the problem still exists

Even if you use unload, wait a bit and load again?

Using /reload, or /unload and /load, makes no difference.
And I found that even after the plugin was unloaded, the command was still valid.

[Test-Account666]

How exactly are you registering your commands btw? Are you using some kind of Command API?

[KioProject123]

How exactly are you registering your commands btw? Are you using some kind of Command API?

This is the sample code I used to register the command

public class TEST extends JavaPlugin implements Listener {
    @Override
    public void onEnable() {
        Bukkit.getCommandMap().register("rcon", new Command());
    }
}

public class Command extends org.bukkit.command.Command {
    public Command() {
        super("rcon", "", "", List.of());
    }

    @Override
    public boolean execute(@NotNull CommandSender sender, @NotNull String commandLabel, @NotNull String @NotNull [] args) {
        sender.sendMessage("version 1");
        return true;
    }
}

In addition, I tested using plugin.yml to register this command, which has been fixed on v3.0.2-RC.3

[Test-Account666]

Ah, that makes sense then.

I'll have a shot at fixing this either in a few hours or tomorrow ^^

[Test-Account666]

Please try v3.0.3-RC.1. From my tests, it worked though

[KioProject123]

Please try v3.0.3-RC.1. From my tests, it worked though

Looks like it's working now! Thanks for fixing it.

[MelodyYuuka]

When registering commands using Paper's LifecycleManager, using the plugman load/reload/unload commands cannot properly register or unregister these commands.

That's how I registered the command.

        plugin.getLifecycleManager().registerEventHandler(
            LifecycleEvents.COMMANDS,
            event -> event.registrar().register(
                rewardsCommand.register(),
                "OnlineReward"
            )
        );


public class RewardsCommand {

    public LiteralCommandNode<CommandSourceStack> register() {
        return Commands.literal("playrewards").executes(this::executeRewards).build();
    }

    private int executeRewards(CommandContext<CommandSourceStack> context) {
        // Some Logic
        return 0;
    }
}

[Test-Account666]

When registering commands using Paper's LifecycleManager, using the plugman load/reload/unload commands cannot properly register or unregister these commands.

That's how I registered the command.

        plugin.getLifecycleManager().registerEventHandler(
            LifecycleEvents.COMMANDS,
            event -> event.registrar().register(
                rewardsCommand.register(),
                "OnlineReward"
            )
        );


public class RewardsCommand {

    public LiteralCommandNode<CommandSourceStack> register() {
        return Commands.literal("playrewards").executes(this::executeRewards).build();
    }

    private int executeRewards(CommandContext<CommandSourceStack> context) {
        // Some Logic
        return 0;
    }
}

I'm guessing they're basically fully decoupled from the registering plugin...

This makes them hard to recognize for PlugManX since the Classloader doesn't point to your plugin and there's no fallback plugin:... registered for your command...

[MelodyYuuka]

I wonder if it's possible to achieve this: allowing plugin developers who use LifecycleManager to ensure compatibility with the loading and unloading functions of PlugManX by adding some extra code, as a temporary solution.

[Test-Account666]

I wonder if it's possible to achieve this: allowing plugin developers who use LifecycleManager to ensure compatibility with the loading and unloading functions of PlugManX by adding some extra code, as a temporary solution.

This is already possible for bukkit/paper using the "Gentle Unload" API

I might rename the method names in the future tho... I don't think they should be named like that...