Getting ValueError on ByteArray with values greater than 128

[McArdellje]

Problem is due to bytes being read in as values from 0 to 255 but being checked as -128 to 128 in _util.JavaByte.validate

[PapaMarky]

I have a fix for this problem. Should I (can I) submit a pull request with the fix?

[baoqi-zhong]

Encountered the same issue. The problem is that NBTTagByteArray did not use Struct for conversion when reading binary data, but instead directly used list(bytearray( )). Causing negative numbers to be converted to positive numbers greater than 128. So an error was reported during the data range check in the JavaByte.validate function.

Here is a possible fix:
in python_nbt\nbt.py:
in class NBTTagByteArray:
in _read_buffer:

Change:

length = NBTTagInt(buffer=buffer).value
self.extend(list(bytearray(buffer.read(length))))

To:

length = NBTTagInt(buffer=buffer).value
fmt = Struct(">" + str(length) + "b")
self.clear()
self.extend(list(fmt.unpack(buffer.read(fmt.size))))

In this way, the way binary data is read in NBTTagByteArray is consistent with that in NBTTagIntArray